chore: Add lockfile to integration-test project
#570
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I think this is failing because we do not observe a lockfile in the [integration-test project](https://github.com/guardian/cdk/blob/9b9a91bc03f507ba4d688024b4fc8059a617f9d0/integration-test/script/ci#L5-L8). As `eslint-plugin-import`'s version includes `^`, we cannot guarantee what version gets used in CI. We hadn't seen it locally as we don't do a fresh install. If you delete integration-test/node_modules and lint the integration-test project, the error can be seen. Options: - Use pinned versions in the integration-test project (I'm not sure if dependabot works with pinned dependency versions) - Do not lint the integration-test project - Use a lockfile and install @guardian/cdk into the integration-test project with `--no-package-lock` (not sure if this is possible as @guardian/cdk will remain in `package.json`) See: - import-js/eslint-plugin-import#2021 - https://docs.npmjs.com/cli/v6/commands/npm-install#:~:text=--no-package-lock
akash1810
force-pushed
the
aa-lockfile
branch
2 times, most recently
from
33ca0fe
to
6f119e7
Compare
akash1810
changed the title
We previously had issues with lockfiles in CI for the `integration-test` project. This caused a few issues and led to the changes in #569. This change reverts those commits and adds a lockfile. That is, I'm not sure what the previous issues were, but they don't seem to exist anymore and we can use lockfiles in CI and gain deterministic builds.
akash1810
changed the title
integration-test project
jacobwinch
approved these changes
May 19, 2021
|
🎉 This PR is included in version 15.1.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
We previously had issues with lockfiles in CI for the integration-test project. This caused a few issues and led to the changes in #569.
This change reverts those commits and adds a lockfile (might be easiest to review commits in order). That is, I'm not sure what the previous issues were, but they don't seem to exist anymore and we can use lockfiles in CI and gain deterministic builds.
Does this change require changes to existing projects or CDK CLI?
No.
Does this change require changes to the library documentation?
No.
How to test
Observe CI.
How can we measure success?
npm ciresults in a deterministic build in CIHave we considered potential risks?
n/a