Add integration for APsystems EZ1 microinverter #114531
Open
+471
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
home-assistant
bot
added
cla-signed
has-tests
integration: apsystems
new-integration
labels
This was referenced Mar 31, 2024
Kane610
reviewed
Apr 1, 2024
|
I've just checked the test coverage: 96% as the lines returning the successfully created config never get tested, as |
joostlek
requested changes
Apr 9, 2024
|
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
|
Maybe @CM000n, could you leave a review? |
|
@joostlek Pinging you in the hopes that you've got capacity for hopefully the last review for this PR. |
|
No, I'm still busy with my thesis |
mawoka-myblock
requested review from
dmulcahey,
Adminiuga,
puddly,
TheJulianJES,
starkillerOG,
a team,
bdraco,
jjlawren,
balloob and
bieniu
as code owners
balloob
reviewed
May 11, 2024
balloob
reviewed
May 11, 2024
balloob
reviewed
May 11, 2024
balloob
reviewed
May 11, 2024
balloob
reviewed
May 11, 2024
balloob
reviewed
May 11, 2024
balloob
reviewed
May 11, 2024
balloob
reviewed
May 11, 2024
balloob
reviewed
May 11, 2024
|
Somehow the translations for the sensor names don't show up and I don't know why. |
* Ensure coverage entries are sorted * Use autofix * Adjust * Add comment to coverage file * test CI * revert CI test --------- Co-authored-by: Martin Hjelmare <marhje52@gmail.com>
mawoka-myblock
force-pushed
the
apsystemsapi-local
branch
from
1972fe5
to
b89434a
Compare
|
Did you run |
|
Nope, that seemed to be the problem. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
The APsystems EZ1 microinverter has an open local HTTP api and I've created the integration over at https://github.com/SonnenladenGmbH/APsystems-EZ1-API-HomeAssistant but the people wanted to be integrated into HomeAssistant directly.
The following library is used: https://github.com/SonnenladenGmbH/APsystems-EZ1-API
Type of change
Additional information
This is my first PR, so I tried my best.
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.To help with the load of incoming pull requests: