Add integration for APsystems EZ1 microinverter #114531
Conversation
home-assistant
bot
added
cla-signed
has-tests
integration: apsystems
new-integration
labels
|
I've just checked the test coverage: 96% as the lines returning the successfully created config never get tested, as |
|
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
|
Maybe @CM000n, could you leave a review? |
|
@joostlek Pinging you in the hopes that you've got capacity for hopefully the last review for this PR. |
|
No, I'm still busy with my thesis |
mawoka-myblock
requested review from
dmulcahey,
Adminiuga,
puddly,
TheJulianJES,
starkillerOG,
a team,
bdraco,
jjlawren,
balloob and
bieniu
as code owners
* Ensure coverage entries are sorted * Use autofix * Adjust * Add comment to coverage file * test CI * revert CI test --------- Co-authored-by: Martin Hjelmare <marhje52@gmail.com>
mawoka-myblock
force-pushed
the
apsystemsapi-local
branch
from
1972fe5
to
b89434a
Compare
|
Did you run |
|
Nope, that seemed to be the problem. |
| @@ -81,6 +81,10 @@ omit = | |||
| homeassistant/components/aprilaire/climate.py | |||
| homeassistant/components/aprilaire/coordinator.py | |||
| homeassistant/components/aprilaire/entity.py | |||
| homeassistant/components/apsystems/__init__.py | |||
| homeassistant/components/apsystems/const.py | |||
There was a problem hiding this comment.
const doesn't have any coverage checks
|
|
||
| async def async_setup_entry(hass: HomeAssistant, entry: ConfigEntry) -> bool: | ||
| """Set up this integration using UI.""" | ||
| entry.runtime_data = {} |
| api = APsystemsEZ1M(ip_address=entry.data[CONF_IP_ADDRESS], timeout=8) | ||
| coordinator = ApSystemsDataCoordinator(hass, api) | ||
| await coordinator.async_config_entry_first_refresh() | ||
| entry.runtime_data = {"COORDINATOR": coordinator} |
There was a problem hiding this comment.
We should type the ConfigEntry using the generic type
| { | ||
| "config": { | ||
| "step": { | ||
| "user": { | ||
| "data": { | ||
| "host": "[%key:common::config_flow::data::host%]", | ||
| "username": "[%key:common::config_flow::data::username%]", | ||
| "password": "[%key:common::config_flow::data::password%]" | ||
| } | ||
| } | ||
| }, | ||
| "error": { | ||
| "cannot_connect": "[%key:common::config_flow::error::cannot_connect%]", | ||
| "invalid_auth": "[%key:common::config_flow::error::invalid_auth%]", | ||
| "unknown": "[%key:common::config_flow::error::unknown%]" | ||
| }, | ||
| "abort": { | ||
| "already_configured": "[%key:common::config_flow::abort::already_configured_device%]" | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
The strings are not updated. I am missing the config flow string and I am missing all of the entity translations
Proposed change
The APsystems EZ1 microinverter has an open local HTTP api and I've created the integration over at https://github.com/SonnenladenGmbH/APsystems-EZ1-API-HomeAssistant but the people wanted to be integrated into HomeAssistant directly.
The following library is used: https://github.com/SonnenladenGmbH/APsystems-EZ1-API
Type of change
Additional information
This is my first PR, so I tried my best.
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.To help with the load of incoming pull requests: