fix: update @typescript-eslint/experimental-utils to v5
#941
Conversation
| @@ -681,7 +681,7 @@ const isTestCaseName = (node: TSESTree.LeftHandSideExpression) => | |||
| TestCaseName.hasOwnProperty(node.name); | |||
|
|
|||
| const isTestCaseProperty = ( | |||
| node: TSESTree.Expression, | |||
| node: TSESTree.Expression | TSESTree.PrivateIdentifier, | |||
There was a problem hiding this comment.
not sure if this is correct, but seems safe enough? 😀
There was a problem hiding this comment.
hahah yeah I think it should be fine just technically incorrect/nonsensical as a private identifier will never be what we want; but if CI is happy let's ship it 🎉
There was a problem hiding this comment.
tbh actually thinking about it probably is actually fine because if we're got a node that could be one of those types, it'll be nicer on our rules to handle it here rather than having to check in each rule before calling this method 🤷
| @@ -681,7 +681,7 @@ const isTestCaseName = (node: TSESTree.LeftHandSideExpression) => | |||
| TestCaseName.hasOwnProperty(node.name); | |||
|
|
|||
| const isTestCaseProperty = ( | |||
| node: TSESTree.Expression, | |||
| node: TSESTree.Expression | TSESTree.PrivateIdentifier, | |||
There was a problem hiding this comment.
hahah yeah I think it should be fine just technically incorrect/nonsensical as a private identifier will never be what we want; but if CI is happy let's ship it 🎉
## [25.0.4](v25.0.3...v25.0.4) (2021-10-11) ### Bug Fixes * update `@typescript-eslint/experimental-utils` to v5 ([#941](#941)) ([afad49a](afad49a))
|
🎉 This PR is included in version 25.0.4 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This should enable compat with
eslint@8even if we can't test against it (thus add it topeerDependencies) yet