Add Font Awesome 5.12 to the JupyterLab Manager #2698
Conversation
| @@ -1,6 +1,9 @@ | |||
| // Copyright (c) Jupyter Development Team. | |||
| // Distributed under the terms of the Modified BSD License. | |||
|
|
|||
| import '@fortawesome/fontawesome-free/css/all.css'; | |||
| import '@fortawesome/fontawesome-free/css/v4-shims.css'; | |||
|
|
|||
There was a problem hiding this comment.
I wasn't sure where to put it, I'm of course open to better suggestions
There was a problem hiding this comment.
We are importing other css in plugin.ts. Can we move these imports to there?
martinRenou
force-pushed
the
add_fontawesome_jlab_manager
branch
from
e6d84d6
to
fa2d8b5
Compare
| @@ -35,6 +35,7 @@ | |||
| "test:unit:firefox:headless": "npm run test:unit:default -- --browsers=FirefoxHeadless" | |||
| }, | |||
| "dependencies": { | |||
| "@fortawesome/fontawesome-free": "^5.12.0", | |||
There was a problem hiding this comment.
FYI, this is not a typo. The org actually is fortawesome: https://github.com/FortAwesome/Font-Awesome/blob/d8db3d032d22e7a5e21f3b40905b7867be19bb02/js-packages/%40fortawesome/fontawesome-free/package.json#L51
Signed-off-by: martinRenou <martin.renou@gmail.com>
martinRenou
force-pushed
the
add_fontawesome_jlab_manager
branch
from
fa2d8b5
to
3df0763
Compare
|
As discussed offline and in this PR, it might not be a good idea to remove Font-Awesome from JupyterLab and expect third-party extensions to ship Font-Awesome from now on. It might create Font-Awesome version conflicts, for instance, Font-Awesome suggest not to mix v4 and v5 (see https://fontawesome.com/how-to-use/on-the-web/setup/upgrading-from-version-4). I will close this PR and open a PR on the JupyterLab repository, upgrading Font-Awesome to 5.12 there. |
lock
bot
added
the
resolved-locked
And update Font Awesome in the html-manager