Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make IFuture done typings more correct #8032

Merged
merged 1 commit into from Mar 12, 2020
Merged

Make IFuture done typings more correct #8032

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 2 additions & 3 deletions packages/services/src/kernel/kernel.ts
View file
Open in desktop
Expand Up @@ -685,10 +685,9 @@ export interface IFuture<
* The future is done when there are no more responses expected from the
* kernel.
*
* The `done` promise resolves to the reply message if there is one,
* otherwise it resolves to `undefined`.
* The `done` promise resolves to the reply message.
*/
readonly done: Promise<REPLY | undefined>;
readonly done: Promise<REPLY>;

/**
* The reply handler for the kernel future.
Expand Down