Support for better-sqlite3 Driver
#4871
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ter-sqlite3 Signed-off-by: blam <ben@blam.sh>
Signed-off-by: blam <ben@blam.sh>
Signed-off-by: blam <ben@blam.sh>
…aking good progress! Signed-off-by: blam <ben@blam.sh>
Signed-off-by: blam <ben@blam.sh>
Signed-off-by: blam <ben@blam.sh>
Signed-off-by: blam <ben@blam.sh>
kibertoad
reviewed
Dec 2, 2021
| @@ -174,6 +194,7 @@ const testConfigs = { | |||
| }; | |||
|
|
|||
| function getKnexForDb(db, configOverrides = {}) { | |||
| console.log(db); | |||
|
Wow, this is super impressive! Great job |
Signed-off-by: blam <ben@blam.sh>
|
@OlivierCavadenti Considering the great job that vscode is doing on their sqlite fork, I don't think we need to deprecate dialect, just switch to vscode version (for which you already created PR, I believe) |
…ests Signed-off-by: blam <ben@blam.sh>
Signed-off-by: blam <ben@blam.sh>
Signed-off-by: blam <ben@blam.sh>
|
Think this should be good to go now! |
|
LGTM. Could you please also send a PR for documentation, expanding list of supported drivers? |
|
@kibertoad yes of course, will round to that today! |
|
Sorry - got sidetracked @kibertoad. Had a quick pass at updating some of the docs, hope that's what was needed :) |
kibertoad
approved these changes
Dec 9, 2021
|
Looking forward to the release. Many thanks in advance! |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With
node-sqlite3no longer being maintained, we want to have the ability to support asqlitedriver that is. https://github.com/JoshuaWise/better-sqlite3 seems to be a great replacement fornode-sqlite3.Still work in progress right now, that's why it's draft, but wanted to get some early feedback to make sure we're going the right way.
Closes #4511