Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-create the module with TypeScript #152

Merged
merged 16 commits into from Jun 25, 2023
Merged

Re-create the module with TypeScript #152

merged 16 commits into from Jun 25, 2023

Conversation

3imed-jaberi
Copy link
Member

@3imed-jaberi 3imed-jaberi commented Mar 31, 2023

Checklist

  • I have ensured my pull request is not behind the main or master branch of the original repository.
  • I have rebased all commits where necessary so that reviewing this pull request can be done without having to merge it first.
  • I have written a commit message that passes commitlint linting.
  • I have ensured that my code changes pass linting tests.
  • I have ensured that my code changes pass unit tests.
  • I have described my pull request and the reasons for code changes along with context if necessary.

This PR target the next major version by re-creating the module with TS and improving the current code quality and features.

  • Re-create the module with TS
  • Support CJS and ESM
  • Support Node.js v16+
  • Better code
  • 100% Coverage
  • Updating all dependencies.
  • Replace Mocha, Should, and Nyc with Jest
  • Support the already parsed body
  • Add patchNode option to support patching under ctx.req
  • Add parseMethods option to parse only the passed ones
  • Replacte Travis CI with GitHub Actions
  • Update README.md file

@3imed-jaberi
Copy link
Member Author

Ready to review 🎉!

@3imed-jaberi 3imed-jaberi marked this pull request as ready for review May 12, 2023 17:29
@socket-security
Copy link

New and updated dependency changes detected. Learn more about Socket for GitHub ↗︎

Packages Version New capabilities Transitives1 Size Publisher
ts-node 🆕 10.9.1 filesystem, shell, environment +16 41.6 MB cspotcode
@types/type-is 🆕 1.6.3 None +0 3.3 kB types
@types/lodash.merge 🆕 4.6.7 None +1 867 kB types
typescript 🆕 5.1.3 filesystem +0 40.1 MB typescript-bot
@types/koa 🆕 2.13.6 None +16 173 kB types
lodash.merge 🆕 4.6.2 None +0 54.1 kB jdalton
jest 🆕 29.5.0 network +140 46.4 MB simenb
ts-jest 🆕 29.1.0 network, filesystem, environment +144 47 MB kul
tsup 🆕 6.7.0 eval, network, filesystem, environment +83 249 MB egoist
@types/co-body 🆕 6.1.0 None +1 12.4 kB types
@types/jest 🆕 29.5.2 eval +24 1.16 MB types
@types/supertest 🆕 2.0.12 None +2 27.4 kB types
xo ⬆️ 0.25.4...0.54.2 filesystem, environment +118/-318 71 MB sindresorhus
eslint-config-xo-lass ⬆️ 1.0.6...2.0.1 None +0/-0 15.6 kB titanism
husky ⬆️ 4.3.8...8.0.3 None +0/-10 6.44 kB typicode
supertest ⬆️ 4.0.2...6.3.3 None +8/-12 842 kB titanism

🚮 Removed packages: copy-to@2.0.1, mocha@10.2.0, nyc@15.1.0, should@13.2.3

Footnotes

  1. https://docs.socket.dev

@3imed-jaberi 3imed-jaberi requested review from fengmk2 and titanism and removed request for fengmk2 and titanism June 24, 2023 16:17
@koajs koajs deleted a comment from socket-security bot Jun 24, 2023
Copy link
Member

@fengmk2 fengmk2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fengmk2 fengmk2 merged commit b89581a into master Jun 25, 2023
7 of 8 checks passed
@fengmk2 fengmk2 deleted the next-body-parser-v5 branch June 25, 2023 01:22
@fengmk2
Copy link
Member

fengmk2 commented Jun 25, 2023

📦 @koa/bodyparser@5.0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants