add version labels to deployments managed by controllers #13176
Conversation
Signed-off-by: Simon Bein <simontheleg@gmail.com>
kubermatic-bot
added
release-note-none
|
I know what this is towards to, why aren't we "just" checking the container image in the |
|
So my understanding of our code is that this would be the safest way to check. It allows us to write a check in the installer that waits for "label == installerversion". Otherwise the only thing we could check for is "has the version of the tag changed", because - the way I understand it - the tag could point to any version specified in the operator. |
|
/cc @xrstf |
|
|
||
| deployment, ok := obj.(*appsv1.Deployment) | ||
| if !ok { | ||
| return obj, nil |
There was a problem hiding this comment.
This should be an error maybe. Silently not doing anything if someone used the modifier on something invalid could lead to sadness.
For other modifiers, like the volume revision thingy, I think we also support DaemonSets and StatefulSets -- if we decide to skip those here for now, it would be good if the code screamed at us if someone decided to use this in the future on a DS/STS.
There was a problem hiding this comment.
that is a really good point. Added an error
|
|
||
| deployment, ok := obj.(*appsv1.Deployment) | ||
| if !ok { | ||
| return obj, fmt.Errorf("VersionLabelModifier can only be used with deployments") |
There was a problem hiding this comment.
fmt.Errorf("VersionLabelModifier is only implemented for deployments, not %T", obj)
There was a problem hiding this comment.
(let's not make it sound like there is a technical reason version labels are not allowed/supported on other objects)
Signed-off-by: Simon Bein <simontheleg@gmail.com>
SimonTheLeg
force-pushed
the
version-label-modifier-factory
branch
from
f1269aa
to
f1162ad
Compare
|
LGTM label has been added. Git tree hash: d9c272d7fe22d59878ee673aeaf7e7e67a5004a0
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: xrstf The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubermatic-bot
added
the
approved
embik
added
the
code-freeze-approved
kubermatic-bot
removed
the
do-not-merge/code-freeze
|
/milestone KKP 2.25 |
What this PR does / why we need it:
Adds the version label to all deployments and pods that are owned by our controllers. This is required for a different task which needs this label to be in place to determine the currently deployed version of a component.
What type of PR is this?
/kind cleanup
Special notes for your reviewer:
Does this PR introduce a user-facing change? Then add your Release Note here:
Documentation: