Actually support service publishNotReadyAddresses
#63742
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note
k8s-ci-robot
requested review from
caesarxuchao,
mkumatag,
MrHohn,
nikhiljindal,
pwittrock,
saad-ali and
shyamjvs
k8s-ci-robot
added
the
cncf-cla: yes
k8s-github-robot
added
the
kind/api-change
thockin
added
the
release-note-action-required
thockin
force-pushed
the
kill-tolerate-unready-annotation
branch
2 times, most recently
from
f60f11c
to
db306e4
Compare
|
/retest |
This was added and the annotation was deprecated, but it was never implemented.
thockin
force-pushed
the
kill-tolerate-unready-annotation
branch
from
db306e4
to
c038f60
Compare
MrHohn
approved these changes
May 14, 2018
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: MrHohn, thockin The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
cc @kow3ns |
|
Automatic merge from submit-queue (batch tested with PRs 63792, 63495, 63742, 63332, 63779). If you want to cherry-pick this change to another branch, please follow the instructions here. |
The reason this hadn't been implemented yet was explained in #61056 (comment) With that said, I talked to @kow3ns after that comment and he seemed willing to consider this type of implementation, at least as an intermediate step. |
mikkeloscar
added a commit
to mikkeloscar/kubernetes
that referenced
this pull request
Sep 14, 2018
This fixes the Redis StatefulSet e2e test by adding the missing `publishNotReadyAddresses: true` field, which was accidentially left out in kubernetes#63742. Without this fix, the redis e2e test will fail because the pod is unable to lookup the service: ``` 2018/09/14 13:57:10 lookup redis on 172.31.9.247:53: no such host ``` Signed-off-by: Mikkel Oscar Lyderik Larsen <mikkel.larsen@zalando.de>
vithati
pushed a commit
to vithati/kubernetes
that referenced
this pull request
Oct 25, 2018
This fixes the Redis StatefulSet e2e test by adding the missing `publishNotReadyAddresses: true` field, which was accidentially left out in kubernetes#63742. Without this fix, the redis e2e test will fail because the pod is unable to lookup the service: ``` 2018/09/14 13:57:10 lookup redis on 172.31.9.247:53: no such host ``` Signed-off-by: Mikkel Oscar Lyderik Larsen <mikkel.larsen@zalando.de>
4 tasks
tongpu
added a commit
to tongpu/vault-helm
that referenced
this pull request
Jul 28, 2020
This annotation has been deprecated since Kuberneets 1.8 and the publishNotReadyAddresses parameter replacing it has been correctly implemented in Kubernetes 1.11 (see kubernetes/kubernetes#63742)
jasonodonnell
pushed a commit
to hashicorp/vault-helm
that referenced
this pull request
Jul 30, 2020
This annotation has been deprecated since Kuberneets 1.8 and the publishNotReadyAddresses parameter replacing it has been correctly implemented in Kubernetes 1.11 (see kubernetes/kubernetes#63742)
delgod
added a commit
to percona/percona-xtradb-cluster-operator
that referenced
this pull request
Sep 14, 2021
https://jira.percona.com/browse/K8SPXC-876 "service.alpha.kubernetes.io/tolerate-unready-endpoints" annotation has been deprecated since Kuberneets 1.8 and the spec.publishNotReadyAddresses parameter replacing it has been correctly implemented in Kubernetes 1.11 (see kubernetes/kubernetes#63742)
delgod
added a commit
to percona/percona-xtradb-cluster-operator
that referenced
this pull request
Sep 17, 2021
https://jira.percona.com/browse/K8SPXC-876 "service.alpha.kubernetes.io/tolerate-unready-endpoints" annotation has been deprecated since Kuberneets 1.8 and the spec.publishNotReadyAddresses parameter replacing it has been correctly implemented in Kubernetes 1.11 (see kubernetes/kubernetes#63742)
1 task
2 tasks
trombini77
added a commit
to trombini77/charts
that referenced
this pull request
Jan 16, 2023
The annotation `service.alpha.kubernetes.io/tolerate-unready-endpoints: "true"` is deprecated since Kubernetes 1.11, following kubernetes/kubernetes#63742 The template input both fields, the annotation and the substituted field `.spec.publishNotReadyAddresses=True` but it becomes incompatible with Kubernetes <=1.10 so a check Kubernetes version resolve it put the right fields based on Kubernetes version.
4 tasks
DandyDeveloper
added a commit
to DandyDeveloper/charts
that referenced
this pull request
Mar 2, 2023
* fix: publishNotReadyAddresses K8s version check The annotation `service.alpha.kubernetes.io/tolerate-unready-endpoints: "true"` is deprecated since Kubernetes 1.11, following kubernetes/kubernetes#63742 The template input both fields, the annotation and the substituted field `.spec.publishNotReadyAddresses=True` but it becomes incompatible with Kubernetes <=1.10 so a check Kubernetes version resolve it put the right fields based on Kubernetes version. * Bumping chart version * Update Chart.yaml --------- Co-authored-by: Aaron Layfield <Aaron.Layfield@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was added and the annotation was deprecated, but it was never
implemented.
xref #63741
Release note: