Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(bootstrap): Run lifecycle scripts in topological queue instead of batches #2224

Merged
merged 1 commit into from Oct 7, 2019

Conversation

nicolo-ribaudo
Copy link
Contributor

Description

This PR updates @lerna/bootstrap so that it used runTopologically instead of the old batchPackages

@lerna/batch-packages and @lerna/run-parallel-batches aren't used anymore by any other package of the monorepo, but I don't know which is the process needed to remove them.

Motivation and Context

While updating lerna in the Babel repo, I noticed that the old cycles warnings (which should have been disappeared after #2185) were still there.
After investigating a bit, I realized that the old partitionCycles method was still used by @lerna/batch-packages.

How Has This Been Tested?

Only using the tests in this repo

Types of changes

  • Refactoring
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@evocateur evocateur changed the title Use runTopologically in @lerna/bootstrap fix(bootstrap): Run lifecycle scripts in topological queue instead of batches Oct 7, 2019
Copy link
Member

@evocateur evocateur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. We can remove the unused packages separately.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants