Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update request to 2.83.0 #320

Closed
wants to merge 2 commits into from
Closed

Conversation

godspeedelbow
Copy link

So, that transitive dep ajv gets bumped from 4.x to 5.x

see: request/request#2652

So, that transitive dep `ajv` gets bumped from `4.x` to `5.x`

see: request/request#2652
@godspeedelbow
Copy link
Author

/Users/travis/build/mapbox/node-pre-gyp/node_modules/request/node_modules/hawk/node_modules/boom/lib/index.js:5
const Hoek = require('hoek');
^^^^^
gyp ERR! UNCAUGHT EXCEPTION 
gyp ERR! stack SyntaxError: Use of const in strict mode.

Seems like a transitive dependency of request, boom, is not sticking to ES5.

@JLHwung
Copy link

JLHwung commented Sep 27, 2017

Suggest update request to 2.83.0 due to request/request#2776.

@JLHwung
Copy link

JLHwung commented Sep 27, 2017

As long as test passes on node >= 4 and node = 0.10 was added as an attempt to fix a bug, I think it is safe to merge this PR.

@godspeedelbow godspeedelbow changed the title Update request to 2.82.0 Update request to 2.83.0 Sep 28, 2017
@godspeedelbow
Copy link
Author

it fails only on 0.10

@igorlima
Copy link

Is it possible to have an update on this 🙏

@springmeyer
Copy link
Contributor

Addressed by #347

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants