Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dependency on hawk, upgrade request #347

Merged
merged 1 commit into from Mar 10, 2018
Merged

Remove dependency on hawk, upgrade request #347

merged 1 commit into from Mar 10, 2018

Conversation

krotscheck
Copy link
Contributor

@krotscheck krotscheck commented Feb 15, 2018

This patch removes the explicit dependency on hawk, and upgrades request
to the newest version. It also removes node 0.10 from the testing grid,
as this version has been EOL'd by the node foundation, and doesn't support
es6 syntax used in the newer introduced dependencies.

https://nodesecurity.io/advisories/566
https://hackerone.com/reports/310439
https://github.com/nodejs/Release

Closes #346

@krotscheck
Copy link
Contributor Author

The only mention of hawk appears to be the package.json file:
https://github.com/mapbox/node-pre-gyp/search?utf8=%E2%9C%93&q=hawk&type=

@SebastianSchmidt
Copy link

SebastianSchmidt commented Feb 15, 2018

The package request@2.81.0 depends on hawk@3.1.3.
This pull request does not completely remove the dependency on hawk and does not solve #346:

node-pre-gyp@0.6.39 › request@2.81.0 › hawk@3.1.3 › hoek@2.16.3
node-pre-gyp@0.6.39 › request@2.81.0 › hawk@3.1.3 › boom@2.10.1 › hoek@2.16.3
node-pre-gyp@0.6.39 › request@2.81.0 › hawk@3.1.3 › sntp@1.0.9 › hoek@2.16.3
node-pre-gyp@0.6.39 › request@2.81.0 › hawk@3.1.3 › cryptiles@2.0.5 › boom@2.10.1 › hoek@2.16.3

Updating to request@2.83.0 fixes the vulnerability.
request@2.83.0 uses hawk@6.0.2 which depends on hoek@4.2.1 (hapijs/hoek#230):

node-pre-gyp@0.6.39 › request@2.83.0 › hawk@6.0.2 › hoek@4.2.1
node-pre-gyp@0.6.39 › request@2.83.0 › hawk@6.0.2 › boom@4.3.1 › hoek@4.2.1
node-pre-gyp@0.6.39 › request@2.83.0 › hawk@6.0.2 › sntp@2.1.0 › hoek@4.2.1
node-pre-gyp@0.6.39 › request@2.83.0 › hawk@6.0.2 › cryptiles@3.1.2 › boom@5.2.0 › hoek@4.2.1

@krotscheck
Copy link
Contributor Author

@SebastianSchmidt Done. Jetzt auf Travis warten ⏳

@SebastianSchmidt
Copy link

request@2.83.0 and Node 0.10: #320, #342

This patch removes the explicit dependency on hawk, and upgrades request
to the newest version. It also removes node 0.10 from the testing grid,
as this version has been EOL'd by the node foundation, and doesn't support
es6 syntax used in the newer introduced dependencies.

https://nodesecurity.io/advisories/566
https://hackerone.com/reports/310439
https://github.com/nodejs/Release

Closes #346
@krotscheck krotscheck changed the title Remove dependency on hawk Remove dependency on hawk, upgrade request Feb 15, 2018
@krotscheck
Copy link
Contributor Author

Yeah, saw that. Given that node 0.10 is EOL, I removed it from the testing grid.

@krotscheck
Copy link
Contributor Author

@springmeyer Any chance you can take a look at this?

@JulianLaval
Copy link

Would be great to have this PR merged in -- any updates? 🙂

@kontrollanten
Copy link

Any updates on this?

kontrollanten added a commit to kontrollanten/algolia-places-react that referenced this pull request Feb 24, 2018
kontrollanten added a commit to kontrollanten/algolia-places-react that referenced this pull request Feb 24, 2018
@Pablodotnet
Copy link

Any updates on this? We need the merge ASAP!

@nhodges
Copy link

nhodges commented Mar 7, 2018

Whoops, just saw this PR. I also made a PR to address this, #349. Many packages are waiting on this so it can go upstream.

@ronkorving
Copy link

Yeah, waiting too. Does node-pre-gyp only have a single maintainer?

@fenichelar
Copy link

Merging this PR and releasing a new version would be great! :)

@springmeyer
Copy link
Contributor

Thanks for this PR. Sorry for the wait in review/merging. Will merge now and release as v0.7.0.

@springmeyer springmeyer merged commit af507d1 into mapbox:master Mar 10, 2018
@springmeyer
Copy link
Contributor

node-pre-gyp@0.7.0 is now published: https://www.npmjs.com/package/node-pre-gyp

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

10 participants