update request from 2.81.0 to 2.83.0
#342
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The main purpose of this PR is for removing the (transitive) dependency on `jsonify`, which has a problematic license for us (Public Domain). `request` upgraded `har-validator` from ~4.2.1 to ~5.0.3 and it eventually removed the dependency on `jsonify`. Hope you don't mind this change.
|
Tests fail with Node 0.10. And I also notice that there was a previous attempt for this: #320. Is it really required to support Node 0.10? It doesn't seem ideal to fix the version of |
This was referenced Jan 8, 2018
|
Done in #347 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main purpose of this PR is for removing the (transitive) dependency
on
jsonify, which has a problematic license for us (Public Domain).requestupgradedhar-validatorfrom ~4.2.1 to ~5.0.3 and iteventually removed the dependency on
jsonify.Hope you don't mind this change.