WebMidi access is more than just secure context #18160
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
data:api 🐇
hamishwillee
commented
Nov 7, 2022
Comment on lines
+3759
to
3763
| "notes": [ | ||
| "Version 107 and later, API use is gated by a site permission add-on that is automatically generated by Firefox.", | ||
| "Version 105 and later, the <code>dom.webmidi.gated</code> preference may be set <code>false</code> to allow WebMIDI to be used without a site permission addon.", | ||
| "Version 100 to 104 (inclusive) WebMIDI is not available (API use is gated by a site permission add-on that is no longer available)." | ||
| ] |
There was a problem hiding this comment.
The preference version includes all the data. I am expecting this to be deleted when the feature goes live.
hamishwillee
commented
Nov 7, 2022
| @@ -3744,7 +3744,8 @@ | |||
| "edge": "mirror", | |||
| "firefox": [ | |||
| { | |||
| "version_added": "preview" | |||
| "version_added": "preview", | |||
| "notes": "API access is gated by installation of a site permission add-on (user prompt), secure context, and <a href='https://developer.mozilla.org/docs/Web/HTTP/Headers/Feature-Policy/midi'>Permission Policy: <code>midi</code></a>." | |||
There was a problem hiding this comment.
The preview version contains specific information about the site permission add on and feature policy gating.
We will need to link to docs on the site permission when Firefox has written them.
This was referenced Nov 7, 2022
|
This pull request has merge conflicts that must be resolved before it can be merged. |
hamishwillee
added a commit
to hamishwillee/browser-compat-data
that referenced
this pull request
Nov 21, 2022
Merges changes from mdn#18160
|
Closing - merging changes into #18213 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#18115 added information about the firefox site permission updates to the secure context docs, replacing an out of date note.
On reflection though secure context is mostly about requiring HTTPS - and the site permission behaviour is about user prompting.
So what I have done is moved the notes out of secure context and as a note against the API itself.
@queengooborg FYI