Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.5.1] Iterable is missing in lib.es2015.promise.d.ts #31722

Closed
Rouden opened this issue Jun 2, 2019 · 9 comments · Fixed by #45350
Closed

[3.5.1] Iterable is missing in lib.es2015.promise.d.ts #31722

Rouden opened this issue Jun 2, 2019 · 9 comments · Fixed by #45350
Assignees
Labels
Bug A bug in TypeScript Fix Available A PR has been opened for this issue
Milestone

Comments

@Rouden
Copy link

Rouden commented Jun 2, 2019

TypeScript Version:

  • 3.5.1
  • 3.6.0-dev.20190601

Search Terms: async, await, polyfill, csproj, TypeScriptLib

Code

tsconfig.json

{
  "compilerOptions": {
    "target": "es5",
    "module": "none",
    "lib": ["dom", "es5", "es2015.promise"],
    "strict": true,
  }
}

a.ts

// empty

Expected behavior:

> npx typescript@3.4.5
// ok

Actual behavior:

> npx typescript@3.5.1
../path/typescript/lib/lib.es2015.promise.d.ts:129:21 - error TS2304: Cannot find name 'Iterable'.

129     race<T>(values: Iterable<T>): Promise<T extends PromiseLike<infer U> ? U : T>;
                        ~~~~~~~~


Found 1 error.

Playground Link: None

Related Issues: Not found.

Workaround:
Add "es2015.iterable" to lib

@SpurYang
Copy link

SpurYang commented Jun 4, 2019

Me too, miss
/// <
reference lib="es2015.symbol"

@RyanCavanaugh RyanCavanaugh added the Bug A bug in TypeScript label Jun 13, 2019
@RyanCavanaugh RyanCavanaugh added this to the Backlog milestone Jun 13, 2019
@simonua
Copy link

simonua commented Jul 10, 2019

Does this relate to #31676?

@SergioMorchon
Copy link

Any news on this?

@simonua
Copy link

simonua commented Aug 1, 2019

3.5.3 exhibited the same problem for me. I have our TypeScript dependencies locked at 3.4.5 and cannot go higher at this time.

@SergioMorchon
Copy link

@pushkin- nope, with 3.5.3 shows the same error:

node_modules/typescript/lib/lib.es2015.promise.d.ts:129:21 - error TS2304: Cannot find name 'Iterable'

@SergioMorchon
Copy link

@rbuckton any news on this? What do you recommend to bypass this issue to start using newer TypeScript versions?

@CervEdin
Copy link

This workaround appears to work

Workaround is to add es2015.iterable to lib

headintheclouddev/typings-suitescript-2.0#121 (comment)

Unfortunately this ads typings for additional ES2015 iterable features

@rbuckton
Copy link
Member

Fixed by #35998.

@rbuckton
Copy link
Member

We are pushing awaited until after TS3.9 while we continue to assess the impact of the change. While this means we are essentially reverting #35998 with #37610, #37610 leaves in place the change that addressed this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment