Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#1744 Create ReportTable component #1758

Merged
merged 5 commits into from
Dec 20, 2019
Merged

#1744 Create ReportTable component #1758

Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
3ef8e11
Add ReportTable component
diegoevangelisti Dec 19, 2019
e4baf19
Merge branch 'feature/dashboard' into #1744-ReportTable-component
diegoevangelisti Dec 19, 2019
329bed1
Merge branch 'feature/dashboard' into #1744-ReportTable-component
diegoevangelisti Dec 19, 2019
cc80e7b
Create component ReportTable
diegoevangelisti Dec 20, 2019
7218d46
Add ListHeaderComponent prop
diegoevangelisti Dec 20, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
37 changes: 37 additions & 0 deletions src/widgets/ReportTable/ReportTable.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,37 @@
/* eslint-disable react/prop-types */
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is for the renderItem call? Theres some info here about that if you're interested jsx-eslint/eslint-plugin-react#2325

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I have a problem with that indeed. If I declared them then es-lint says I'm not using them 😅

/* eslint-disable react/forbid-prop-types */
/**
* mSupply Mobile
* Sustainable Solutions (NZ) Ltd. 2018
*/

import React from 'react';
import { StyleSheet, FlatList, View } from 'react-native';
import PropTypes from 'prop-types';
import { LIGHT_GREY } from '../../globalStyles';
import { ReportRow } from './ReportRow';

export const ReportTable = ({ rows, header }) => {
const renderItem = ({ item, index }) => <ReportRow rowData={item} rowIndex={index} />;

const renderHeader = () => <ReportRow rowData={header} isHeader rowIndex={0} />;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fine, but there is also this prop on FlatList just for interest! https://facebook.github.io/react-native/docs/flatlist#listheadercomponent

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made this change here: 7218d46
Hope it works, otherwise I can come back to previous stage :-) thanks for this!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that should work!


// TODO: KeyExtractor should be altered to not use the index.
return (
<View style={localStyles.container}>
{renderHeader()}
<FlatList data={rows} renderItem={renderItem} keyExtractor={(_, index) => `${index}`} />
</View>
);
};

ReportTable.propTypes = {
header: PropTypes.array.isRequired,
rows: PropTypes.array.isRequired,
};

const localStyles = StyleSheet.create({
container: {
backgroundColor: LIGHT_GREY,
},
});