Support ESLint 8.x #294

MichaelDeBoey · 2021-08-23T01:11:59Z

ESLint v8.0.0 is released 🎉

It would be awesome to have official ESLint 8 support. 👊
I'm happy to help where I can of course 🙂

Follow-up of #223

voxpelli · 2021-10-14T20:06:22Z

Is anything broken in the current release and needs fixing for ESLint 8?

This module automatically supports ESLint 8:

eslint-plugin-node/package.json

Lines 12 to 14 in f45c614

    
           "peerDependencies": { 
        
             "eslint": ">=5.16.0" 
        
           },

So unless something is broken, then this is a non-issue?

See: - https://eslint.org/blog/2021/10/eslint-v8.0.0-released - https://eslint.org/docs/user-guide/migrating-to-8.0.0 Known issues: - [x] wait for import-js/eslint-plugin-import#2191 to be released and merged here - [x] wait for gajus/eslint-plugin-flowtype#496 to be released and merged here - [x] wait for testing-library/eslint-plugin-testing-library#462 to be released and merged here - [ ] wait for mysticatea/eslint-plugin-node#294 to be released and merged here - [ ] ...

mrtnzlml · 2021-10-26T14:07:45Z

Is anything broken in the current release and needs fixing for ESLint 8?

Hi @voxpelli! I have one thing that is broken. The following file is currently not behaving correctly with Eslint version 8: https://github.com/adeira/universe/blob/8cff40fc01c2aca6ae01ec53cd8d1be07afd8c84/src/eslint-config-adeira/__tests__/__fixtures__/valid-eslint-examples/node/process-exit-as-throw.js

We created this file based on the official example because of some previous problems with this rule. Here is the error we are getting:

Thanks for having a look!

See: - https://eslint.org/blog/2021/10/eslint-v8.0.0-released - https://eslint.org/docs/user-guide/migrating-to-8.0.0 Known issues that need to be fixed first: - [x] wait for import-js/eslint-plugin-import#2191 to be released and merged here - [x] wait for gajus/eslint-plugin-flowtype#496 to be released and merged here - [x] wait for testing-library/eslint-plugin-testing-library#462 to be released and merged here - [ ] wait for mysticatea/eslint-plugin-node#294 to be released and merged here - [ ] wait for facebook/react#22248 to be released and merged here - [ ] release minor/patch version of Adeira Eslint Config before merging this breaking change - [ ] ...

voxpelli · 2021-10-26T14:41:33Z

@mrtnzlml Great example! Can you add a dedicated issue for it, like a ESLint 8.x regression: node/process-exit-as-throw no longer works

See: - https://eslint.org/blog/2021/10/eslint-v8.0.0-released - https://eslint.org/docs/user-guide/migrating-to-8.0.0 Known issues that need to be fixed first: - [x] wait for import-js/eslint-plugin-import#2191 to be released and merged here - [x] wait for gajus/eslint-plugin-flowtype#496 to be released and merged here - [x] wait for testing-library/eslint-plugin-testing-library#462 to be released and merged here - [ ] wait for mysticatea/eslint-plugin-node#294 to be released and merged here - [x] wait for facebook/react#22248 to be released and merged here - [ ] release minor/patch version of Adeira Eslint Config before merging this breaking change - [ ] ...

aladdin-add · 2021-12-17T08:00:26Z

for someone blocked by the plugin, I've just pushed a fork: eslint-plugin-n.

it just added supports for eslint v8.

voxpelli · 2021-12-17T09:27:28Z

@aladdin-add Can you summarize somewhere on how it relates to the ESLint 8 PR:s in this repo? What the changes are from upstream? + maybe links to PR:s for those changes?

Great to have a fork to use until upstream gets updated 👍

MichaelDeBoey · 2021-12-17T14:13:26Z

@aladdin-add Would be nice if we could transfer repos like eslint-plugin-node, eslint-plugin-es, eslint-utils & @mysticatea/eslint-plugin to a new @eslint-community org

CC/ @mysticatea

sosukesuzuki · 2021-12-17T14:25:39Z

Thank you. I agree with @MichaelDeBoey. It would be nice to be able to take over maintenance and release from @mysticatea

voxpelli · 2021-12-17T15:31:50Z

As we need them for StandardJS as well, I think we can maybe add them there if we want a common org as well

MichaelDeBoey · 2021-12-17T15:48:28Z

Transferring them to the @standard org is fine for me too 🤷‍♂️
I just think we should transfer it to an org that will take care of maintenance long term, that's all

Just need to get in touch with @mysticatea somehow to get it done and then I think a lot of PRs can get merged quickly

See: - https://eslint.org/blog/2021/10/eslint-v8.0.0-released - https://eslint.org/docs/user-guide/migrating-to-8.0.0 Known issues that need to be fixed first: - [x] wait for import-js/eslint-plugin-import#2191 to be released and merged here - [x] wait for gajus/eslint-plugin-flowtype#496 to be released and merged here - [x] wait for testing-library/eslint-plugin-testing-library#462 to be released and merged here - [ ] wait for mysticatea/eslint-plugin-node#294 to be released and merged here - [x] wait for facebook/react#22248 to be released and merged here - [ ] release minor/patch version of Adeira Eslint Config before merging this breaking change - [ ] ...

aladdin-add · 2021-12-18T05:34:30Z

nicholas also agreed to the eslint-community, will put together an RFC for how it will work.

MichaelDeBoey · 2021-12-18T06:28:30Z

Let me know if I can help somehow!

See: - https://eslint.org/blog/2021/10/eslint-v8.0.0-released - https://eslint.org/docs/user-guide/migrating-to-8.0.0 Known issues that need to be fixed first: - [x] wait for import-js/eslint-plugin-import#2191 to be released and merged here - [x] wait for gajus/eslint-plugin-flowtype#496 to be released and merged here - [x] wait for testing-library/eslint-plugin-testing-library#462 to be released and merged here - [ ] wait for mysticatea/eslint-plugin-node#294 to be released and merged here - [x] wait for facebook/react#22248 to be released and merged here - [ ] release minor/patch version of Adeira Eslint Config before merging this breaking change - [ ] ...

See: - https://eslint.org/blog/2021/10/eslint-v8.0.0-released - https://eslint.org/docs/user-guide/migrating-to-8.0.0 Known unresolved issues (with low impact )that we decided to accept: - mysticatea/eslint-plugin-node#301 Known issues that need to be fixed first: - [x] wait for import-js/eslint-plugin-import#2191 to be released and merged here - [x] wait for gajus/eslint-plugin-flowtype#496 to be released and merged here - [x] wait for testing-library/eslint-plugin-testing-library#462 to be released and merged here - [ ] ~wait for mysticatea/eslint-plugin-node#294 to be released and merged here~ replaced (probably temporarily) with `eslint-plugin-n` which supports Eslint 8 - [x] wait for facebook/react#22248 to be released and merged here - [x] release minor/patch version of Adeira Eslint Config before merging this breaking change - [x] switch `NEXT_VERSION_ERROR` to `ERROR` (#3625)

See: - https://eslint.org/blog/2021/10/eslint-v8.0.0-released - https://eslint.org/docs/user-guide/migrating-to-8.0.0 Known unresolved issues (with low impact )that we decided to accept: - mysticatea/eslint-plugin-node#301 Known issues that need to be fixed first: - [x] wait for import-js/eslint-plugin-import#2191 to be released and merged here - [x] wait for gajus/eslint-plugin-flowtype#496 to be released and merged here - [x] wait for testing-library/eslint-plugin-testing-library#462 to be released and merged here - [ ] ~wait for mysticatea/eslint-plugin-node#294 to be released and merged here~ replaced (probably temporarily) with `eslint-plugin-n` which supports Eslint 8 - [x] wait for facebook/react#22248 to be released and merged here - [x] release minor/patch version of Adeira Eslint Config before merging this breaking change - [x] switch `NEXT_VERSION_ERROR` to `ERROR` (adeira/universe#3625) adeira-source-id: b194be7e4f2fc10d51a10ed8753c440414e36b4d

tennox · 2022-02-19T11:22:17Z

shy bump 😓

niksy · 2022-03-20T07:43:37Z

It seems like eslint-plugin-n is maintained version of this plugin.

See: - https://eslint.org/blog/2021/10/eslint-v8.0.0-released - https://eslint.org/docs/user-guide/migrating-to-8.0.0 Known unresolved issues (with low impact )that we decided to accept: - mysticatea/eslint-plugin-node#301 Known issues that need to be fixed first: - [x] wait for import-js/eslint-plugin-import#2191 to be released and merged here - [x] wait for gajus/eslint-plugin-flowtype#496 to be released and merged here - [x] wait for testing-library/eslint-plugin-testing-library#462 to be released and merged here - [ ] ~wait for mysticatea/eslint-plugin-node#294 to be released and merged here~ replaced (probably temporarily) with `eslint-plugin-n` which supports Eslint 8 - [x] wait for facebook/react#22248 to be released and merged here - [x] release minor/patch version of Adeira Eslint Config before merging this breaking change - [x] switch `NEXT_VERSION_ERROR` to `ERROR` (adeira/universe#3625) adeira-source-id: b194be7e4f2fc10d51a10ed8753c440414e36b4d

Since eslint-plugin-node has been dormant for quite a while: mysticatea/eslint-plugin-node#294 mysticatea/eslint-plugin-node#300 eslint-plugin-n is an actively maintained fork which is used by xo: xojs/xo#660 switch to that fork. Signed-off-by: Kevin Locke <kevin@kevinlocke.name>

voxpelli · 2023-08-13T12:57:23Z

eslint-plugin-n is the maintained version of this module.

We switched to it in eg. eslint-config-standard / standard and it is maintained by me and other members of the official ESLint community organization.

MichaelDeBoey mentioned this issue Sep 4, 2021

feat: support ESLint 8.x testing-library/eslint-plugin-testing-library#465

Merged

63 tasks

MichaelDeBoey mentioned this issue Sep 20, 2021

feat: support ESLint 8.x jest-community/eslint-plugin-jest#903

Closed

50 tasks

KillWolfVlad mentioned this issue Oct 11, 2021

Support ESLint v8 Byndyusoft/eslint-config#27

Closed

23 tasks

voxpelli mentioned this issue Oct 14, 2021

Support ESLint 7.x #223

Open

theoludwig mentioned this issue Oct 14, 2021

feat: support eslint v8 standard/eslint-config-standard#193

Merged

3 tasks

calebeby mentioned this issue Oct 15, 2021

Update dependency eslint to v8 cloudfour/eslint-config#305

Closed

1 task

teppeis mentioned this issue Oct 16, 2021

Next major v15 teppeis/eslint-config-teppeis#642

Closed

16 tasks

Belco90 mentioned this issue Oct 17, 2021

chore(dev-dependencies): upgrade ESLint and plugins to v8 testing-library/eslint-plugin-testing-library#499

Closed

66 tasks

niksy mentioned this issue Oct 18, 2021

Support ESLint 8 niksy/eslint-config-nitpick#58

Closed

11 tasks

mrtnzlml mentioned this issue Oct 26, 2021

Eslint: upgrade to version 8.0.0 adeira/universe#3274

Merged

7 tasks

mrtnzlml mentioned this issue Oct 26, 2021

ESLint 8.x regression: node/process-exit-as-throw no longer works #301

Open

IlCallo mentioned this issue Oct 27, 2021

ESLint 8 support quasarframework/quasar-starter-kit#167

Open

MichaelDeBoey mentioned this issue Oct 18, 2022

feat: support ESLint 8.x eslint-community/eslint-plugin-mysticatea#37

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Support ESLint 8.x #294

Support ESLint 8.x #294

MichaelDeBoey commented Aug 23, 2021 •

edited

voxpelli commented Oct 14, 2021 •

edited

mrtnzlml commented Oct 26, 2021

voxpelli commented Oct 26, 2021

aladdin-add commented Dec 17, 2021 •

edited

voxpelli commented Dec 17, 2021

MichaelDeBoey commented Dec 17, 2021 •

edited

sosukesuzuki commented Dec 17, 2021

voxpelli commented Dec 17, 2021

MichaelDeBoey commented Dec 17, 2021 •

edited

aladdin-add commented Dec 18, 2021

MichaelDeBoey commented Dec 18, 2021

tennox commented Feb 19, 2022

niksy commented Mar 20, 2022

voxpelli commented Aug 13, 2023

Support ESLint 8.x #294

Support ESLint 8.x #294

Comments

MichaelDeBoey commented Aug 23, 2021 • edited

voxpelli commented Oct 14, 2021 • edited

mrtnzlml commented Oct 26, 2021

voxpelli commented Oct 26, 2021

aladdin-add commented Dec 17, 2021 • edited

voxpelli commented Dec 17, 2021

MichaelDeBoey commented Dec 17, 2021 • edited

sosukesuzuki commented Dec 17, 2021

voxpelli commented Dec 17, 2021

MichaelDeBoey commented Dec 17, 2021 • edited

aladdin-add commented Dec 18, 2021

MichaelDeBoey commented Dec 18, 2021

tennox commented Feb 19, 2022

niksy commented Mar 20, 2022

voxpelli commented Aug 13, 2023

MichaelDeBoey commented Aug 23, 2021 •

edited

voxpelli commented Oct 14, 2021 •

edited

aladdin-add commented Dec 17, 2021 •

edited

MichaelDeBoey commented Dec 17, 2021 •

edited

MichaelDeBoey commented Dec 17, 2021 •

edited