Add initial support for Darwin arm64 #34238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
build
richardlau
added
arm
evanlucas
commented
Jul 7, 2020
evanlucas
force-pushed
the
arm64
branch
2 times, most recently
from
4169c57
to
3e476e2
Compare
addaleax
approved these changes
Jul 7, 2020
|
We found a way to get os.cpus() working properly on both ARM and intel Macs. Once libuv/libuv#2914 lands, I'll get it pulled in. With some V8 patches, I was able to get wasi working properly. The inspector still has some issues that I am digging in to. Perhaps I should back out the libuv patch and we go ahead and land this and do it more incrementally? Thoughts? |
|
The bump to V8 8.5 (#34337) should fix the inspector and wasi issues. |
evanlucas
force-pushed
the
arm64
branch
2 times, most recently
from
a5e0038
to
ad29cb6
Compare
cjihrig
approved these changes
Aug 25, 2020
|
Also started a build on our DTKs as they are not part of the main runs yet - https://ci.nodejs.org/job/node-test-commit-osx-arm/4/ |
AshCripps
approved these changes
Aug 25, 2020
|
@AshCripps thanks! The inspector and wasi tests are still going to fail until V8 8.5 is landed. I have a patch somewhere that works for those without the V8 upgrade. I'll try to find that and submit another PR after this one lands |
This adds the required files for supporting openssl on arm64. This uses the same configuration that can be found in openssl/openssl#12369 to generate the required files. PR-URL: nodejs#34238 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ash Cripps <ashley.cripps@ibm.com>
Ref: nodejs/TSC#886 Ref: nodejs#34043 PR-URL: nodejs#34238 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ash Cripps <ashley.cripps@ibm.com>
|
Landed in 4b6036a...e3b79e3 |
richardlau
pushed a commit
that referenced
this pull request
Sep 1, 2020
This adds the required files for supporting openssl on arm64. This uses the same configuration that can be found in openssl/openssl#12369 to generate the required files. PR-URL: #34238 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ash Cripps <ashley.cripps@ibm.com>
richardlau
pushed a commit
that referenced
this pull request
Sep 1, 2020
Ref: nodejs/TSC#886 Ref: #34043 PR-URL: #34238 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ash Cripps <ashley.cripps@ibm.com>
5 tasks
addaleax
pushed a commit
that referenced
this pull request
Sep 22, 2020
This adds the required files for supporting openssl on arm64. This uses the same configuration that can be found in openssl/openssl#12369 to generate the required files. PR-URL: #34238 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ash Cripps <ashley.cripps@ibm.com>
addaleax
pushed a commit
that referenced
this pull request
Sep 22, 2020
Ref: nodejs/TSC#886 Ref: #34043 PR-URL: #34238 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ash Cripps <ashley.cripps@ibm.com>
addaleax
pushed a commit
that referenced
this pull request
Sep 22, 2020
This adds the required files for supporting openssl on arm64. This uses the same configuration that can be found in openssl/openssl#12369 to generate the required files. PR-URL: #34238 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ash Cripps <ashley.cripps@ibm.com>
addaleax
pushed a commit
that referenced
this pull request
Sep 22, 2020
Ref: nodejs/TSC#886 Ref: #34043 PR-URL: #34238 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ash Cripps <ashley.cripps@ibm.com>
Merged
5 tasks
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
build: add support for build on arm64
deps: add openssl support for arm64
This adds the required files for supporting openssl
on arm64.
This uses the same configuration that can be found in
openssl/openssl#12369 to generate the required
files.
TODO
ld: warning: -no_pie ignored for arm64message during buildChecklist
make -j4 test(UNIX), orvcbuild test(Windows) passes