New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(config): support nuxtrc
in dist directory
#9280
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* allows buildModules to inject runtime modules
pi0
reviewed
May 11, 2021
2 tasks
danielroe
commented
May 11, 2021
Codecov Report
@@ Coverage Diff @@
## dev #9280 +/- ##
==========================================
+ Coverage 65.10% 65.13% +0.02%
==========================================
Files 94 94
Lines 4098 4101 +3
Branches 1121 1124 +3
==========================================
+ Hits 2668 2671 +3
Misses 1152 1152
Partials 278 278
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
pi0
reviewed
May 11, 2021
pi0
previously approved these changes
May 11, 2021
pi0
reviewed
May 12, 2021
danielroe
changed the title
feat(config): support
feat(config): support May 12, 2021
.nuxtrc
in dist directorynuxtrc
in dist directory
clarkdo
approved these changes
May 15, 2021
2 tasks
Closed
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types of changes
Description
One major weakness of
buildModules
is that they can't manipulate runtime Nuxt configuration (for example, by injecting a runtime module into the Nuxt config), leaving the invidious choice of having to be installed as a module, asking a user to manually add runtime configuration or other non-optimal choice.This PR allows manipulation of
nuxt.config
by placing anuxtrc
file within the.nuxt/dist
directory.Checklist: