Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(instr-aws-sdk): use exported strings for attributes #2142

Conversation

JamieDanielson
Copy link
Member

Which problem is this PR solving?

Short description of the changes

  • Update @opentelemetry/semantic-conventions to ^1.22 for aws-sdk instrumentation
  • Replace SemanticAttributes.* with exported strings SEMATTRS_*
  • Replace SemanticResourceAttributes.* with exported strings SEMRESATTRS_*
  • Replace DbSystemValues.* with exported strings DBSYSTEMVALUES_*
  • Replace MessagingDestinationKindValues.* with exported strings MESSAGINGDESTINATIONKINDVALUES_*
  • Replace MessagingOperationValues.* with exported strings MESSAGINGOPERATIONVALUES_*
  • Update README with new semantic convention package version and key
  • Replace deprecated SpanAttributes with Attributes

Copy link

codecov bot commented Apr 23, 2024

Codecov Report

Attention: Patch coverage is 97.61905% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 90.34%. Comparing base (dfb2dff) to head (3cc9718).
Report is 68 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2142      +/-   ##
==========================================
- Coverage   90.97%   90.34%   -0.63%     
==========================================
  Files         146      147       +1     
  Lines        7492     7678     +186     
  Branches     1502     1575      +73     
==========================================
+ Hits         6816     6937     +121     
- Misses        676      741      +65     
Files Coverage Δ
...-instrumentation-aws-lambda/src/instrumentation.ts 93.67% <ø> (ø)
...entelemetry-instrumentation-aws-sdk/src/aws-sdk.ts 95.12% <100.00%> (ø)
...y-instrumentation-aws-sdk/src/services/dynamodb.ts 100.00% <100.00%> (ø)
...emetry-instrumentation-aws-sdk/src/services/sns.ts 94.11% <100.00%> (ø)
...emetry-instrumentation-aws-sdk/src/services/sqs.ts 100.00% <100.00%> (ø)
...opentelemetry-instrumentation-aws-sdk/src/utils.ts 97.29% <100.00%> (ø)
...try-instrumentation-aws-sdk/src/services/lambda.ts 97.77% <75.00%> (ø)

... and 11 files with indirect coverage changes

Copy link
Member

@blumamir blumamir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a lot of work, thank you for this

@JamieDanielson JamieDanielson merged commit 931318c into open-telemetry:main Apr 24, 2024
17 checks passed
@JamieDanielson JamieDanielson deleted the jamie.aws-sdk-semconv-strings branch April 24, 2024 23:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants