Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(client,sdk,integration-tests): remove --forceExit #7990

Merged
merged 10 commits into from Jul 7, 2021

Conversation

millsp
Copy link
Member

@millsp millsp commented Jul 2, 2021

@millsp
Copy link
Member Author

millsp commented Jul 2, 2021

So the open handle problem has been fixed for BuildKite and locally. Tuned CPU to 15% and I also get open handles locally like on GH.

@millsp
Copy link
Member Author

millsp commented Jul 2, 2021

Ok, so @prisma/client is done, see commits for the two little changes.

@Jolg42
Copy link
Member

Jolg42 commented Jul 2, 2021

Nice!! Would be good to merge this in chunks, and create other PR maybe if fixing all of them takes long.

@Jolg42 Jolg42 added this to the 2.27.0 milestone Jul 2, 2021
@Jolg42
Copy link
Member

Jolg42 commented Jul 7, 2021

@millsp I think we could merge this soon and create new PRs for the others?

@millsp
Copy link
Member Author

millsp commented Jul 7, 2021

Ok let me look if I can remove the remaining --forceExit without too much work. If not, then I'll create a separate PR.

@millsp millsp marked this pull request as ready for review July 7, 2021 15:14
@millsp
Copy link
Member Author

millsp commented Jul 7, 2021

migrate still has a few suites not exiting properly. And we still need to disable --forceExit E2E.

@millsp millsp self-assigned this Jul 7, 2021
@millsp millsp requested a review from janpio July 7, 2021 15:23
Copy link
Member

@Jolg42 Jolg42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Well done 👍🏼

@Jolg42 Jolg42 changed the title test(client): remove --forceExit test(client,sdk,integration-tests): remove --forceExit Jul 7, 2021
@Jolg42 Jolg42 merged commit 50c6d1c into master Jul 7, 2021
@Jolg42 Jolg42 deleted the pr/tests-remove-force-exit branch July 7, 2021 16:14
Jolg42 added a commit that referenced this pull request Jul 8, 2021
* fix(db push): make sure to stop migrate engine when it errors

Related
#7795
#7990

* Restore package.json
Andrew-Colman pushed a commit to Andrew-Colman/prisma that referenced this pull request Aug 7, 2021
Co-authored-by: Joël Galeran <Jolg42@users.noreply.github.com>
Andrew-Colman pushed a commit to Andrew-Colman/prisma that referenced this pull request Aug 7, 2021
…#8149)

* fix(db push): make sure to stop migrate engine when it errors

Related
prisma#7795
prisma#7990

* Restore package.json
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants