Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use engine implementation of findFirstOrThrow / findUniqueOrThrow #16162

Merged
merged 12 commits into from Nov 10, 2022

Conversation

miguelff
Copy link
Contributor

@miguelff miguelff commented Nov 7, 2022

Fixes #10642
Closes #15887

Client changes to use the engine implementation of findFirstOrThrow / findUniqueOrThrow rather than the emulated client actions added in #13920.

Once this is merged, I will tackle the following:

Copy link
Member

@millsp millsp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the PR is in a good state, good work on this non-trivial implementation! 🎉 I have left some comments/questions to see if we can improve things a bit. Will approve once resolved :)

@miguelff miguelff requested a review from millsp November 9, 2022 09:26
@Jolg42 Jolg42 added this to the 4.7.0 milestone Nov 9, 2022
Copy link
Contributor

@SevInf SevInf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One (optional) comment in addition to what Pierre said.
Great job! This certainly wasn't a trivial removal.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When rejectOnNotFound is used, chaining deeper into a related table still throws if it doesn't find anything
4 participants