New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: use engine implementation of findFirstOrThrow / findUniqueOrThrow #16162
Conversation
72ec597
to
bb8cdea
Compare
ff2dcdc
to
1b94869
Compare
cc05823
to
d81fe1b
Compare
...es/client/src/__tests__/integration/happy/exhaustive-schema-mongo/__snapshots__/test.ts.snap
Show resolved
Hide resolved
...es/client/src/__tests__/integration/happy/exhaustive-schema-mongo/__snapshots__/test.ts.snap
Show resolved
Hide resolved
packages/client/src/runtime/core/model/applyOrThrowErrorAdapter.ts
Outdated
Show resolved
Hide resolved
packages/client/src/runtime/core/model/applyOrThrowErrorAdapter.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the PR is in a good state, good work on this non-trivial implementation! 🎉 I have left some comments/questions to see if we can improve things a bit. Will approve once resolved :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One (optional) comment in addition to what Pierre said.
Great job! This certainly wasn't a trivial removal.
...es/client/src/__tests__/integration/happy/exhaustive-schema-mongo/__snapshots__/test.ts.snap
Outdated
Show resolved
Hide resolved
6a23f82
to
64b0f70
Compare
64b0f70
to
4304d2d
Compare
4304d2d
to
1d273cb
Compare
Fixes #10642
Closes #15887
Client changes to use the engine implementation of
findFirstOrThrow
/findUniqueOrThrow
rather than the emulated client actions added in #13920.Once this is merged, I will tackle the following:
error
event #14933