Fix CocoaPods case warnings #6190
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 29, 2019
thomasvl
reviewed
May 30, 2019
There was a problem hiding this comment.
So I don't think this will actually "stick" if built on a case sensitive file system. The google/protobuf sub directory here comes from these files living in google/protobuf within src (i.e. - the path is getting reflected into the output path). So the net run would remake lowercase protobuf.
|
@thomasvl so, what would be a solution to this case sensitive warning that would stick? |
|
@BugsBunnyBR see the issue this is trying try address. I think it might be renaming the cocoapod, but I believe that effectively makes a new pod. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #3218
Verified that warnings go away in Protobuf and FirebaseMessaging client build when installed with
use-frameworks!,use-modular-headers, and static libraries.I realize this might not be a great solution for non-CocoaPods users, but I'm not sure there is a solution that wouldn't be a breaking change for one or the other user set.