Replace macos-latest with macos-11 #11155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GitHub are rolling out macos 12 for the -latest image (actions/runner-images#6384), but we need to continue to support and build for macos 11. Fixes #11152
ringods
approved these changes
Oct 26, 2022
Changelog[uncommitted] (2022-10-26)Bug Fixes
|
|
bors merge |
bors bot
added a commit
that referenced
this pull request
Oct 26, 2022
11155: Replace macos-latest with macos-11 r=Frassle a=Frassle <!--- Thanks so much for your contribution! If this is your first time contributing, please ensure that you have read the [CONTRIBUTING](https://github.com/pulumi/pulumi/blob/master/CONTRIBUTING.md) documentation. --> # Description <!--- Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. --> GitHub are rolling out macos 12 for the -latest image (actions/runner-images#6384), but we need to continue to support and build for macos 11. Fixes #11152 ## Checklist <!--- Please provide details if the checkbox below is to be left unchecked. --> - [ ] I have added tests that prove my fix is effective or that my feature works <!--- User-facing changes require a CHANGELOG entry. --> - [x] I have run `make changelog` and committed the `changelog/pending/<file>` documenting my change <!-- If the change(s) in this PR is a modification of an existing call to the Pulumi Service, then the service should honor older versions of the CLI where this change would not exist. You must then bump the API version in /pkg/backend/httpstate/client/api.go, as well as add it to the service. --> - [ ] Yes, there are changes in this PR that warrants bumping the Pulumi Service API version <!-- `@Pulumi` employees: If yes, you must submit corresponding changes in the service repo. --> Co-authored-by: Fraser Waters <fraser@pulumi.com>
|
Build failed: |
|
bors retry |
bors bot
added a commit
that referenced
this pull request
Oct 26, 2022
11155: Replace macos-latest with macos-11 r=Frassle a=Frassle <!--- Thanks so much for your contribution! If this is your first time contributing, please ensure that you have read the [CONTRIBUTING](https://github.com/pulumi/pulumi/blob/master/CONTRIBUTING.md) documentation. --> # Description <!--- Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. --> GitHub are rolling out macos 12 for the -latest image (actions/runner-images#6384), but we need to continue to support and build for macos 11. Fixes #11152 ## Checklist <!--- Please provide details if the checkbox below is to be left unchecked. --> - [ ] I have added tests that prove my fix is effective or that my feature works <!--- User-facing changes require a CHANGELOG entry. --> - [x] I have run `make changelog` and committed the `changelog/pending/<file>` documenting my change <!-- If the change(s) in this PR is a modification of an existing call to the Pulumi Service, then the service should honor older versions of the CLI where this change would not exist. You must then bump the API version in /pkg/backend/httpstate/client/api.go, as well as add it to the service. --> - [ ] Yes, there are changes in this PR that warrants bumping the Pulumi Service API version <!-- `@Pulumi` employees: If yes, you must submit corresponding changes in the service repo. --> Co-authored-by: Fraser Waters <fraser@pulumi.com>
|
Build failed: |
|
bors retry |
|
Build succeeded: |
Merged
abhinav
added a commit
that referenced
this pull request
Feb 3, 2023
In #11155, we pinned CI to macos-11 because we want to continue to support macOS 11. This, however hsa created a new issue: grpcio does not publish wheels for macos-11 anymore and building it from source takes long enough to kill our CI (see #12054 #12050). To fix the issue while continuing to support older macOS, run CI on macos-latest, but leave build jobs and friends on macos-11. Resolves #12054, #12050
abhinav
added a commit
that referenced
this pull request
Feb 3, 2023
In #11155, we pinned CI to macos-11 because we want to continue to support macOS 11. This, however hsa created a new issue: grpcio does not publish wheels for macos-11 anymore and building it from source takes long enough to kill our CI (see #12054 #12050). To fix the issue while continuing to support older macOS, run CI on macos-latest, but leave build jobs and friends on macos-11. Resolves #12054, #12050
abhinav
added a commit
that referenced
this pull request
Feb 3, 2023
In #11155, we pinned CI to macos-11 because we want to continue to support macOS 11. This, however hsa created a new issue: grpcio does not publish wheels for macos-11 anymore and building it from source takes long enough to kill our CI (see #12054 #12050). To fix the issue while continuing to support older macOS, run CI on macos-latest, but leave build jobs and friends on macos-11. Resolves #12054, #12050
bors bot
added a commit
that referenced
this pull request
Feb 3, 2023
12066: ci: Use macos-latest r=abhinav a=abhinav In #11155, we pinned CI to macos-11 because we want to continue to support macOS 11. This, however hsa created a new issue: grpcio does not publish wheels for macos-11 anymore and building it from source takes long enough to kill our CI (see #12054 #12050). To fix the issue while continuing to support older macOS, run CI on macos-latest, but leave build jobs and friends on macos-11. Resolves #12054, #12050 Co-authored-by: Abhinav Gupta <abhinav@pulumi.com>
phillipedwards
pushed a commit
that referenced
this pull request
Feb 8, 2023
In #11155, we pinned CI to macos-11 because we want to continue to support macOS 11. This, however hsa created a new issue: grpcio does not publish wheels for macos-11 anymore and building it from source takes long enough to kill our CI (see #12054 #12050). To fix the issue while continuing to support older macOS, run CI on macos-latest, but leave build jobs and friends on macos-11. Resolves #12054, #12050
|
I know this is an old ticket, and you've probably figured out several ways to handle this, but I wanted to leave a note for future people. macOS does allow builds to target older platforms. In this case, if you export the environmental variable |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
GitHub are rolling out macos 12 for the -latest image (actions/runner-images#6384), but we need to continue to support and build for macos 11.
Fixes #11152
Checklist
make changelogand committed thechangelog/pending/<file>documenting my change