New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: Use macos-latest #12066
Merged
Merged
ci: Use macos-latest #12066
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current dependencies on/for this PR:
This comment was auto-generated by Graphite. |
abhinav
added
the
impact/no-changelog-required
This issue doesn't require a CHANGELOG update
label
Feb 3, 2023
Changelog[uncommitted] (2023-02-03) |
bors try |
tryBuild failed: |
abhinav
force-pushed
the
abhinav/macos-latest
branch
from
February 3, 2023 20:05
8adb856
to
df8ace1
Compare
bors try |
tryBuild failed: |
justinvp
approved these changes
Feb 3, 2023
In #11155, we pinned CI to macos-11 because we want to continue to support macOS 11. This, however hsa created a new issue: grpcio does not publish wheels for macos-11 anymore and building it from source takes long enough to kill our CI (see #12054 #12050). To fix the issue while continuing to support older macOS, run CI on macos-latest, but leave build jobs and friends on macos-11. Resolves #12054, #12050
abhinav
force-pushed
the
abhinav/macos-latest
branch
from
February 3, 2023 20:46
df8ace1
to
4955f3d
Compare
RobbieMcKinstry
approved these changes
Feb 3, 2023
bors r+ |
🕐 Waiting for PR status (GitHub check) to be set, probably by CI. Bors will automatically try to run when all required PR statuses are set. |
bors p=1 |
bors r+ p=1 |
This was referenced Feb 3, 2023
Build succeeded: |
This was referenced Feb 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #11155, we pinned CI to macos-11
because we want to continue to support macOS 11.
This, however hsa created a new issue:
grpcio does not publish wheels for macos-11 anymore
and building it from source takes long enough to kill our CI
(see #12054 #12050).
To fix the issue while continuing to support older macOS,
run CI on macos-latest, but leave build jobs and friends on macos-11.
Resolves #12054, #12050