fix(typescript): allow defaultViewport to be 'null' #6942
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
christian-bromann
force-pushed
the
cb-defaultViewport-null
branch
from
1761fe1
to
00b7b09
Compare
Niek
approved these changes
Mar 1, 2021
|
Is this going to be ready for the next release? |
|
ping @jackfranklin |
sadym-chromium
approved these changes
Mar 22, 2021
|
@christian-bromann, are you going to merge this? |
|
@zoltan-boros I don't have any permissions to merge |
|
@jackfranklin, your review and approval is missing to merge this change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #6885
This aligns with how
defaultViewportcan be applied to aPageorTarget.