Typing annotations: rule.py
#6516
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rdimaio
commented
Feb 27, 2024
rdimaio
force-pushed
the
patch-6454-type-rule
branch
3 times, most recently
from
8cd2358
to
511512c
Compare
rdimaio
commented
Feb 29, 2024
rdimaio
force-pushed
the
patch-6454-type-rule
branch
from
511512c
to
9ee5870
Compare
rdimaio
force-pushed
the
patch-6454-type-rule
branch
from
9ee5870
to
b41d555
Compare
bari12
approved these changes
Mar 7, 2024
|
I am squashing the commits together. |
I would keep them separate - I split them on purpose in that way to avoid having non-behavioural and behavioural changes in the same commit, following the guidelines of what I was asked to do for other PRs e.g. #6497 |
dchristidis
reviewed
Mar 7, 2024
dchristidis
reviewed
Mar 13, 2024
dchristidis
reviewed
Mar 13, 2024
dchristidis
reviewed
Mar 13, 2024
rdimaio
added a commit
to rdimaio/rucio
that referenced
this pull request
Mar 18, 2024
Fixing the "NOT FOR 34.0.0rc2" comments from rucio#6516.
|
Follow-up for the "NOT FOR 34.0.0rc2" comments: #6575 |
bari12
pushed a commit
that referenced
this pull request
Mar 19, 2024
Fixing the "NOT FOR 34.0.0rc2" comments from #6516.
bari12
pushed a commit
that referenced
this pull request
Mar 19, 2024
Fixing the "NOT FOR 34.0.0rc2" comments from #6516.
voetberg
pushed a commit
to voetberg/rucio
that referenced
this pull request
Mar 21, 2024
* Rules: remove unnecessary arguments in __find_surplus_locks_and_remove_them * Rules: add type hints; rucio#6454 * Rules: update query to SQLAlchemy 2.0 syntax; rucio#6057 * Rules: Add RuleDict typed dict; rucio#6454
voetberg
pushed a commit
to voetberg/rucio
that referenced
this pull request
Apr 15, 2024
* Rules: remove unnecessary arguments in __find_surplus_locks_and_remove_them * Rules: add type hints; rucio#6454 * Rules: update query to SQLAlchemy 2.0 syntax; rucio#6057 * Rules: Add RuleDict typed dict; rucio#6454
voetberg
pushed a commit
to voetberg/rucio
that referenced
this pull request
Apr 15, 2024
Fixing the "NOT FOR 34.0.0rc2" comments from rucio#6516.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding type annotations to
rule.pyand some correlated type annotations torule_grouping.py. Part of #6454.Tests pass locally.