Implement FromSql & ToSql for std::num::NonZero types #1313

itsxaos · 2023-04-05T03:34:32Z

Pros:

pretty straightforward implementation
support for more standard library types
won't (shouldn't) break anything because of orphan rules

Cons:

clutters up docs (and code) a little
probably not very extensively used

I also added a little note about STRICT tables to the docs.

itsxaos · 2023-04-05T03:39:20Z

src/types/to_sql.rs

@@ -186,12 +218,27 @@ macro_rules! to_sql_self_fallible(
                )))
            }
        }
+    );
+    (non_zero $t:ty) => (
+        impl ToSql for $t {


I wanted to implement this by delegating to the zero-able type, but it doesn't seem possible because the NonZero::get returns by-value and ToSql::to_sql is allowed to borrow from the temporary.

codecov · 2023-04-05T06:08:57Z

Codecov Report

Patch coverage: 98.18% and project coverage change: +0.25 🎉

Comparison is base (8ac4780) 80.48% compared to head (3ea9333) 80.74%.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #1313      +/-   ##
==========================================
+ Coverage   80.48%   80.74%   +0.25%     
==========================================
  Files          49       49              
  Lines        9943    10053     +110     
==========================================
+ Hits         8003     8117     +114     
+ Misses       1940     1936       -4

Impacted Files	Coverage Δ
src/types/mod.rs	`95.71% <ø> (ø)`
src/types/to_sql.rs	`96.29% <96.82%> (+0.16%)`	⬆️
src/types/from_sql.rs	`74.58% <100.00%> (+9.66%)`	⬆️

... and 2 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

gwenn · 2023-05-31T08:53:56Z

Thanks

chore(deps): update rust crate rusqlite to 0.30.0 [![Mend Renovate logo banner](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [rusqlite](https://togithub.com/rusqlite/rusqlite) | workspace.dependencies | minor | `0.29.0` -> `0.30.0` | --- ### Release Notes <details> <summary>rusqlite/rusqlite (rusqlite)</summary> ### [`v0.30.0`](https://togithub.com/rusqlite/rusqlite/releases/tag/v0.30.0): 0.30.0 [Compare Source](https://togithub.com/rusqlite/rusqlite/compare/v0.29.0...v0.30.0) #### What's Changed - Fix sqlite3\_auto_extension xEntryPoint signature [#1310](https://togithub.com/rusqlite/rusqlite/issues/1310) - Use track_caller for panicking methods [#1314](https://togithub.com/rusqlite/rusqlite/issues/1314) - Force linking against system sqlite libs [#1317](https://togithub.com/rusqlite/rusqlite/issues/1317) - fix compilation for target wasm32-wasi [#1321](https://togithub.com/rusqlite/rusqlite/issues/1321) - Add SQLITE_MAX_COLUMN compile-time option [#1324](https://togithub.com/rusqlite/rusqlite/issues/1324) - Upgrade http links to https in Cargo.toml [#1330](https://togithub.com/rusqlite/rusqlite/issues/1330) - Update fallible-iterator requirement from 0.2 to 0.3 [#1334](https://togithub.com/rusqlite/rusqlite/issues/1334) - Implement FromSql & ToSql for std::num::NonZero types [#1313](https://togithub.com/rusqlite/rusqlite/issues/1313) - Add new constants introduced by SQLite 3.42.0 [#1336](https://togithub.com/rusqlite/rusqlite/issues/1336) - Use SQLITE_PREPARE_PERSISTENT for CachedStatement [#1339](https://togithub.com/rusqlite/rusqlite/issues/1339) - Fix type of SQLITE_DESERIALIZE\_*, SQLITE_PREPARE\_*, SQLITE_SERIALIZE_\* [#1340](https://togithub.com/rusqlite/rusqlite/issues/1340) - Introduce to_sqlite_error [#1345](https://togithub.com/rusqlite/rusqlite/issues/1345) - remove depth from Savepoint [#1327](https://togithub.com/rusqlite/rusqlite/issues/1327) - Savepoint Drop bug [#1347](https://togithub.com/rusqlite/rusqlite/issues/1347) - \[breaking change] Update edition from 2018 to 2021 [#1267](https://togithub.com/rusqlite/rusqlite/issues/1267) - Remove msrv for clippy by [#1351](https://togithub.com/rusqlite/rusqlite/issues/1351) - Tweak bindgen [#1352](https://togithub.com/rusqlite/rusqlite/issues/1352), [#1353](https://togithub.com/rusqlite/rusqlite/issues/1353) - Inline constraint_error_code [#1359](https://togithub.com/rusqlite/rusqlite/issues/1359) - Simplify bindgen generation [#1360](https://togithub.com/rusqlite/rusqlite/issues/1360) - Fixes generate_series to handle NULL arguments [#1357](https://togithub.com/rusqlite/rusqlite/issues/1357) - Factorize code in build.rs [#1361](https://togithub.com/rusqlite/rusqlite/issues/1361) - Serialize and deserialize database [#1341](https://togithub.com/rusqlite/rusqlite/issues/1341) - Spelling and a few more nits [#1373](https://togithub.com/rusqlite/rusqlite/issues/1373) - Implement support for more `time` types [#1374](https://togithub.com/rusqlite/rusqlite/issues/1374) - Fix visibility of TransactionState [#1384](https://togithub.com/rusqlite/rusqlite/issues/1384) - Column is used only with column_decltype feature [#1385](https://togithub.com/rusqlite/rusqlite/issues/1385) - Use proper var names in trait definition [#1398](https://togithub.com/rusqlite/rusqlite/issues/1398) - Fix clippy warning: arc_with_non_send_sync - interrupt_lock [#1400](https://togithub.com/rusqlite/rusqlite/issues/1400) - Captured identifiers in SQL strings [#1346](https://togithub.com/rusqlite/rusqlite/issues/1346) - Add new constants introduced by SQLite 3.43.0 [#1405](https://togithub.com/rusqlite/rusqlite/issues/1405) - Make WindowAggregate::value pass mutable value ref [#1395](https://togithub.com/rusqlite/rusqlite/issues/1395) - Bump bundled SQLite version to 3.44.0 [#1409](https://togithub.com/rusqlite/rusqlite/issues/1409) - Bump bindgen version to 0.69 [#1410](https://togithub.com/rusqlite/rusqlite/issues/1410) - Loadable extension [#1362](https://togithub.com/rusqlite/rusqlite/issues/1362) #### New Contributors - [`@icp1994](https://togithub.com/icp1994)` made their first contribution in [rusqlite/rusqlite#1317 - [`@wasm-forge](https://togithub.com/wasm-forge)` made their first contribution in [rusqlite/rusqlite#1321 - [`@nopjia](https://togithub.com/nopjia)` made their first contribution in [rusqlite/rusqlite#1324 - [`@Benjins-automation](https://togithub.com/Benjins-automation)` made their first contribution in [rusqlite/rusqlite#1330 - [`@itsxaos](https://togithub.com/itsxaos)` made their first contribution in [rusqlite/rusqlite#1313 - [`@Taywee](https://togithub.com/Taywee)` made their first contribution in [rusqlite/rusqlite#1327 - [`@davidselassie](https://togithub.com/davidselassie)` made their first contribution in [rusqlite/rusqlite#1357 - [`@nyurik](https://togithub.com/nyurik)` made their first contribution in [rusqlite/rusqlite#1373 - [`@nydrani](https://togithub.com/nydrani)` made their first contribution in [rusqlite/rusqlite#1374 **Full Changelog**: rusqlite/rusqlite@v0.29.0...v0.30.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "before 5am on the first day of the month" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/rust-lang/cargo).

xaos added 5 commits April 4, 2023 23:02

Fix minor doc inaccuracy

f6cd0a5

Fix missing ToSql asserts for isize, usize & u64

88e5882

Implement ToSql for std::num::NonZero types

00b88e3

Implement FromSql for std::num::NonZero types

ce7cdfb

Test FromSql & ToSql for std::num::NonZero types

2e5db7b

itsxaos commented Apr 5, 2023

View reviewed changes

Add missing tests for std::num::NonZero{I64, Isize, U64, Usize}

3ea9333

gwenn approved these changes Apr 16, 2023

View reviewed changes

gwenn merged commit 5e079e5 into rusqlite:master May 31, 2023
15 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Implement FromSql & ToSql for std::num::NonZero types #1313

Implement FromSql & ToSql for std::num::NonZero types #1313

itsxaos commented Apr 5, 2023

itsxaos Apr 5, 2023

codecov bot commented Apr 5, 2023 •

edited

gwenn commented May 31, 2023

Implement FromSql & ToSql for std::num::NonZero types #1313

Implement FromSql & ToSql for std::num::NonZero types #1313

Conversation

itsxaos commented Apr 5, 2023

itsxaos Apr 5, 2023

Choose a reason for hiding this comment

codecov bot commented Apr 5, 2023 • edited

Codecov Report

gwenn commented May 31, 2023

codecov bot commented Apr 5, 2023 •

edited