Implement support for more `time` types #1374

nydrani · 2023-07-28T12:48:00Z

Opening this PR to revive support for more time types. I've cherry picked the changes from #1282.

Closes #1282
Closes #1281

This PR implements support for the following types:

time::Time
time::Date
time::PrimitiveDateTime

It also adds support for keeping the original OffsetDateTime when serializing via ToSql.

This PR implements support for the following types: * `time::Time` * `time::Date` * `time::PrimitiveDateTime`

gwenn · 2023-07-28T16:34:51Z

Implement support for more time types #1282 is still open
Do the comments in Implement support for more time types #1282 are fixed in Implement support for more time types #1374 ?

gwenn · 2023-07-28T16:40:05Z

src/types/time.rs

+    format_description!(version = 2, "[hour]:[minute]:[second].[subsecond]");
+const DATE_ENCODING: &[FormatItem<'_>] = format_description!(version = 2, "[year]-[month]-[day]");
+
+const DATE_FORMAT: &[FormatItem<'_>] = format_description!(version = 2, "[year]-[month]-[day]");


Duplicates: DATE_ENCODING == DATE_FORMAT

Removed duplication

Simplify deserializing `time::OffsetDateTime` Add `YYYY-MM-DD HH:MM` support for `time::OffsetDateTime` and `time::PrimitiveDateTime`

nydrani · 2023-07-29T01:13:10Z

Implement support for more time types #1282 is still open

Do the comments in Implement support for more time types #1282 are fixed in Implement support for more time types #1374 ?

I opened this PR because Implement support for more time types #1282 has no activity for a while.
Yes all comments from Implement support for more time types #1282 have been addressed here.

codecov · 2023-07-29T05:29:43Z

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.33% 🎉

Comparison is base (a0f5b4c) 80.96% compared to head (55fd19e) 81.30%.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #1374      +/-   ##
==========================================
+ Coverage   80.96%   81.30%   +0.33%     
==========================================
  Files          49       49              
  Lines       10050    10227     +177     
==========================================
+ Hits         8137     8315     +178     
+ Misses       1913     1912       -1

Files Changed	Coverage Δ
src/types/time.rs	`100.00% <100.00%> (+0.90%)`	⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

gwenn · 2023-07-29T05:44:29Z

Thanks

chore(deps): update rust crate rusqlite to 0.30.0 [![Mend Renovate logo banner](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [rusqlite](https://togithub.com/rusqlite/rusqlite) | workspace.dependencies | minor | `0.29.0` -> `0.30.0` | --- ### Release Notes <details> <summary>rusqlite/rusqlite (rusqlite)</summary> ### [`v0.30.0`](https://togithub.com/rusqlite/rusqlite/releases/tag/v0.30.0): 0.30.0 [Compare Source](https://togithub.com/rusqlite/rusqlite/compare/v0.29.0...v0.30.0) #### What's Changed - Fix sqlite3\_auto_extension xEntryPoint signature [#1310](https://togithub.com/rusqlite/rusqlite/issues/1310) - Use track_caller for panicking methods [#1314](https://togithub.com/rusqlite/rusqlite/issues/1314) - Force linking against system sqlite libs [#1317](https://togithub.com/rusqlite/rusqlite/issues/1317) - fix compilation for target wasm32-wasi [#1321](https://togithub.com/rusqlite/rusqlite/issues/1321) - Add SQLITE_MAX_COLUMN compile-time option [#1324](https://togithub.com/rusqlite/rusqlite/issues/1324) - Upgrade http links to https in Cargo.toml [#1330](https://togithub.com/rusqlite/rusqlite/issues/1330) - Update fallible-iterator requirement from 0.2 to 0.3 [#1334](https://togithub.com/rusqlite/rusqlite/issues/1334) - Implement FromSql & ToSql for std::num::NonZero types [#1313](https://togithub.com/rusqlite/rusqlite/issues/1313) - Add new constants introduced by SQLite 3.42.0 [#1336](https://togithub.com/rusqlite/rusqlite/issues/1336) - Use SQLITE_PREPARE_PERSISTENT for CachedStatement [#1339](https://togithub.com/rusqlite/rusqlite/issues/1339) - Fix type of SQLITE_DESERIALIZE\_*, SQLITE_PREPARE\_*, SQLITE_SERIALIZE_\* [#1340](https://togithub.com/rusqlite/rusqlite/issues/1340) - Introduce to_sqlite_error [#1345](https://togithub.com/rusqlite/rusqlite/issues/1345) - remove depth from Savepoint [#1327](https://togithub.com/rusqlite/rusqlite/issues/1327) - Savepoint Drop bug [#1347](https://togithub.com/rusqlite/rusqlite/issues/1347) - \[breaking change] Update edition from 2018 to 2021 [#1267](https://togithub.com/rusqlite/rusqlite/issues/1267) - Remove msrv for clippy by [#1351](https://togithub.com/rusqlite/rusqlite/issues/1351) - Tweak bindgen [#1352](https://togithub.com/rusqlite/rusqlite/issues/1352), [#1353](https://togithub.com/rusqlite/rusqlite/issues/1353) - Inline constraint_error_code [#1359](https://togithub.com/rusqlite/rusqlite/issues/1359) - Simplify bindgen generation [#1360](https://togithub.com/rusqlite/rusqlite/issues/1360) - Fixes generate_series to handle NULL arguments [#1357](https://togithub.com/rusqlite/rusqlite/issues/1357) - Factorize code in build.rs [#1361](https://togithub.com/rusqlite/rusqlite/issues/1361) - Serialize and deserialize database [#1341](https://togithub.com/rusqlite/rusqlite/issues/1341) - Spelling and a few more nits [#1373](https://togithub.com/rusqlite/rusqlite/issues/1373) - Implement support for more `time` types [#1374](https://togithub.com/rusqlite/rusqlite/issues/1374) - Fix visibility of TransactionState [#1384](https://togithub.com/rusqlite/rusqlite/issues/1384) - Column is used only with column_decltype feature [#1385](https://togithub.com/rusqlite/rusqlite/issues/1385) - Use proper var names in trait definition [#1398](https://togithub.com/rusqlite/rusqlite/issues/1398) - Fix clippy warning: arc_with_non_send_sync - interrupt_lock [#1400](https://togithub.com/rusqlite/rusqlite/issues/1400) - Captured identifiers in SQL strings [#1346](https://togithub.com/rusqlite/rusqlite/issues/1346) - Add new constants introduced by SQLite 3.43.0 [#1405](https://togithub.com/rusqlite/rusqlite/issues/1405) - Make WindowAggregate::value pass mutable value ref [#1395](https://togithub.com/rusqlite/rusqlite/issues/1395) - Bump bundled SQLite version to 3.44.0 [#1409](https://togithub.com/rusqlite/rusqlite/issues/1409) - Bump bindgen version to 0.69 [#1410](https://togithub.com/rusqlite/rusqlite/issues/1410) - Loadable extension [#1362](https://togithub.com/rusqlite/rusqlite/issues/1362) #### New Contributors - [`@icp1994](https://togithub.com/icp1994)` made their first contribution in [rusqlite/rusqlite#1317 - [`@wasm-forge](https://togithub.com/wasm-forge)` made their first contribution in [rusqlite/rusqlite#1321 - [`@nopjia](https://togithub.com/nopjia)` made their first contribution in [rusqlite/rusqlite#1324 - [`@Benjins-automation](https://togithub.com/Benjins-automation)` made their first contribution in [rusqlite/rusqlite#1330 - [`@itsxaos](https://togithub.com/itsxaos)` made their first contribution in [rusqlite/rusqlite#1313 - [`@Taywee](https://togithub.com/Taywee)` made their first contribution in [rusqlite/rusqlite#1327 - [`@davidselassie](https://togithub.com/davidselassie)` made their first contribution in [rusqlite/rusqlite#1357 - [`@nyurik](https://togithub.com/nyurik)` made their first contribution in [rusqlite/rusqlite#1373 - [`@nydrani](https://togithub.com/nydrani)` made their first contribution in [rusqlite/rusqlite#1374 **Full Changelog**: rusqlite/rusqlite@v0.29.0...v0.30.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "before 5am on the first day of the month" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/rust-lang/cargo).

Implement support for more time types

d05c976

This PR implements support for the following types: * `time::Time` * `time::Date` * `time::PrimitiveDateTime`

gwenn reviewed Jul 28, 2023

View reviewed changes

nydrani and others added 2 commits July 29, 2023 11:09

Add support for serializing timezone offsets for time::OffsetDateTime

6268c71

Simplify deserializing `time::OffsetDateTime` Add `YYYY-MM-DD HH:MM` support for `time::OffsetDateTime` and `time::PrimitiveDateTime`

Added documentation surrounding type conversion

55fd19e

gwenn mentioned this pull request Jul 29, 2023

Implement support for more time types #1282

Closed

gwenn merged commit e093d7d into rusqlite:master Jul 29, 2023
16 checks passed

nydrani deleted the time-support branch July 29, 2023 06:47

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Implement support for more `time` types #1374

Implement support for more `time` types #1374

nydrani commented Jul 28, 2023 •

edited

gwenn commented Jul 28, 2023 •

edited

gwenn Jul 28, 2023

nydrani Jul 29, 2023

nydrani commented Jul 29, 2023

codecov bot commented Jul 29, 2023

gwenn commented Jul 29, 2023

Implement support for more time types #1374

Implement support for more time types #1374

Conversation

nydrani commented Jul 28, 2023 • edited

gwenn commented Jul 28, 2023 • edited

gwenn Jul 28, 2023

Choose a reason for hiding this comment

nydrani Jul 29, 2023

Choose a reason for hiding this comment

nydrani commented Jul 29, 2023

codecov bot commented Jul 29, 2023

Codecov Report

gwenn commented Jul 29, 2023

Implement support for more `time` types #1374

Implement support for more `time` types #1374

nydrani commented Jul 28, 2023 •

edited

gwenn commented Jul 28, 2023 •

edited