android: Add kernel/uapi/linux/neighbour.h constants

[dragan-cecavac-nordsec]

Introduce Android constants defined in https://android.googlesource.com/platform/bionic/+/refs/heads/master/libc/kernel/uapi/linux/neighbour.h

[rustbot]

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @JohnTitor (or someone else) soon.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

• @rustbot author: the review is finished, PR author should check the comments and take action accordingly
• @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

[JohnTitor]

Thanks!

[JohnTitor]

@bors r+

[bors]

📌 Commit 983bdca has been approved by JohnTitor

It is now in the queue for this repository.

[bors]

⌛ Testing commit 983bdca with merge ab80feb...

[bors]

💔 Test failed - checks-cirrus-freebsd-14

[dragan-cecavac-nordsec]

Hi,
It seems that the failure is the same as with #3279 (comment) so I'll also just wait and hope for the best 🤞

[JohnTitor]

Yeah, let's see if it's now fixed, @bors retry

[bors]

⌛ Testing commit 983bdca with merge 4b4e8f1...

[bors]

💔 Test failed - checks-actions

[JohnTitor]

s390x CI needs a tweak, let me fix.

[JohnTitor]

@bors retry

[bors]

⌛ Testing commit 983bdca with merge dab6ff6...

[bors]

💔 Test failed - checks-actions

[dragan-cecavac-nordsec]

It looks to me like some of the definitions are too new for the test setup 😅
Referring to master vs Android 11:

• https://android.googlesource.com/platform/bionic/+/refs/heads/master/libc/kernel/uapi/linux/neighbour.h
• https://android.googlesource.com/platform/bionic/+/refs/tags/android-11.0.0_r1/libc/kernel/uapi/linux/neighbour.h

For starters I could reduce the scope of the changes to cover the testable ones and further on we could see what could be done to widen the test scope, if you agree?

[JohnTitor]

You can ignore tests for newer items, see

libc/libc-test/build.rs

Line 1743 in 1e8943d

cfg.skip_const(move |name| {

A fixme comment describing available version(s) would be helpful when upgrading CI toolchains :)

[dragan-cecavac-nordsec]

Thank you, hopefully this should do.

When it comes to NDK versions listed under FIXME I simply checked the most recent sub-version. E.g. r22b in case of r22 and r25c in case of r25.
After the update, this PR will conflict with #3277. Whichever gets merged first, I can adjust the other.

[JohnTitor]

Thanks! @bors r+

[bors]

📌 Commit ebcb516 has been approved by JohnTitor

It is now in the queue for this repository.

[bors]

⌛ Testing commit ebcb516 with merge 30a7a9f...

[bors]

☀️ Test successful - checks-actions, checks-cirrus-freebsd-12, checks-cirrus-freebsd-13, checks-cirrus-freebsd-14
Approved by: JohnTitor
Pushing 30a7a9f to main...