Remove chosen deprecations #10063
Merged
Remove chosen deprecations #10063
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #10063 +/- ##
==========================================
+ Coverage 85.53% 85.55% +0.02%
==========================================
Files 333 333
Lines 13473 13460 -13
==========================================
- Hits 11524 11516 -8
+ Misses 1949 1944 -5
Continue to review full report at Codecov.
|
|
It might be worth updating the "Deprecations" documentation as well to avoid confusion? |
It'll be re-added in context of v3
It'll be re-added in context of v3
It'll be re-added in context of v3, with more hacky approach to `deploy -f` support
medikoo
force-pushed
the
1007-remove-deprecations
branch
from
357b55d
to
b5f9076
Compare
Good point totally forgot about that. Added now |
medikoo
force-pushed
the
1007-remove-deprecations
branch
from
b5f9076
to
c146168
Compare
pgrzesik
approved these changes
Oct 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove deprecations we agreed internally to not apply for v3
configValidationModesettingsls deploy -fas an alias forsls deploy function -fpackage.includeandpackage.excludeAdditionally replaced a resource extension-related deprecation with an error, as it was a logical error to place deprecation there. Deprecation signaled a situation where there was an attempt to extend not existing resource, and that resulted in adding resource without
Typeproperty, Such setup fails immediately with AWS validation. Replaced that with more meaningful error on our side.