New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix typo and use of componentry #27852
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -180,7 +180,7 @@ | |
* instead of a custom <em>{@code Trigger}</em> implementation; this is because the | ||
* {@code task:} namespace {@code scheduled} cannot easily expose such support. This is | ||
* but one demonstration how the code-based approach allows for maximum configurability | ||
* through direct access to actual componentry. | ||
* through direct access to actual component. | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This is not a typo: "componentry" is semantically correct here. Although the wording could be improved, the suggested change is grammatically incorrect. |
||
* | ||
* <p><b>Note: {@code @EnableScheduling} applies to its local application context only, | ||
* allowing for selective scheduling of beans at different levels.</b> Please redeclare | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -129,7 +129,7 @@ public class SpringServletContainerInitializer implements ServletContainerInitia | |
* method will be invoked on each instance, delegating the {@code ServletContext} such | ||
* that each instance may register and configure servlets such as Spring's | ||
* {@code DispatcherServlet}, listeners such as Spring's {@code ContextLoaderListener}, | ||
* or any other Servlet API componentry such as filters. | ||
* or any other Servlet API component such as filters. | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This is not a typo: "componentry" is semantically correct here. Although the wording could be improved, the suggested change is grammatically incorrect. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Thank you review but can I ask a question in this word "component" change to the "componentry" means, because componentry is not in the dictionary There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
I am also not the English native speaker,I can not understand at the word add ry means what,so how to change the word can grammatically correct. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. what dictionary are you using? |
||
* @param webAppInitializerClasses all implementations of | ||
* {@link WebApplicationInitializer} found on the application classpath | ||
* @param servletContext the servlet context to be initialized | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not a typo: "componentry" is semantically correct here.
Although the wording could be improved, the suggested change is grammatically incorrect.