Fix overrides.files in config to allow basename glob patterns
#6547
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change fixes the `overrides.files` property in config to allow
basename glob patterns like `*.css` or `*.html`.
For example, let's consider `stylelint-config-standard-vue`:
```js
{
overrides: [
{
files: ["*.vue", "**/*.vue"],
extends: [/* ... */],
},
]
}
```
People should expect the `*.vue` pattern matches any `.vue` files in any directories.
See <https://github.com/ota-meshi/stylelint-config-standard-vue/blob/v1.0.0/lib/index.js#L6>
See also the `basename` option `micromatch`:
<https://github.com/micromatch/micromatch/tree/4.0.5#optionsbasename>
🦋 Changeset detectedLatest commit: 6e29fab The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
ybiquitous
commented
Dec 28, 2022
|
|
||
| // Glob patterns for micromatch should be in POSIX-style | ||
| return normalizePath(result); | ||
| } |
There was a problem hiding this comment.
[note] Created the absolutizeGlob() function to reduce duplications.
|
Thanks for the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6525
This change fixes the
overrides.filesproperty in config to allow basename glob patterns like*.cssor*.html.For example, let's consider
stylelint-config-standard-vue:People should expect the
*.vuepattern matches any.vuefiles in any directories.See https://github.com/ota-meshi/stylelint-config-standard-vue/blob/v1.0.0/lib/index.js#L6
See also the
basenameoptionmicromatch:https://github.com/micromatch/micromatch/tree/4.0.5#optionsbasename