Temporarily remove optional chaining in nesting plugin #7077
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This breaks on Node versions lower than version 13. Normally we transpile everything, but we currently don't do this for the nesting plugin since it is not really part of the `src` folder. Will get this fixed in a better way, but for now this is a quick fix to get everything working again!
RobinMalfait
changed the title
RobinMalfait
changed the title
RobinMalfait
force-pushed
the
fix-nesting-plugin
branch
from
fefacc0
to
56aaf1e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a quick fix:
The optional chaining breaks on Node versions lower than version 13. Normally
we transpile everything, but we currently don't do this for the nesting plugin
since it is not really part of the
srcfolder.Will get this fixed in a better way, but for now this is a quick fix to
get everything working again!