Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: downgrade engine requirement to support node 6 #3

Merged
merged 2 commits into from Jan 28, 2020
Merged

fix: downgrade engine requirement to support node 6 #3

merged 2 commits into from Jan 28, 2020

Conversation

SimenB
Copy link
Contributor

@SimenB SimenB commented Jan 27, 2020

Otherwise using this module in Babel is a breaking change. See babel/babel#10924 (comment)

@SimenB SimenB mentioned this pull request Jan 27, 2020
Merged
@SimenB SimenB requested a review from tanhauhau January 27, 2020 16:24
@SimenB
Copy link
Contributor Author

SimenB commented Jan 27, 2020

Passes CI, so hopefully this is accepted and released as a patch version 🤞

@SimenB SimenB mentioned this pull request Jan 27, 2020
Merged
@tanhauhau
Copy link
Owner

thanks 👍

@tanhauhau tanhauhau merged commit 23490c6 into tanhauhau:master Jan 28, 2020
@tanhauhau
Copy link
Owner

fixed in v1.1.1

@tanhauhau tanhauhau mentioned this pull request Jan 28, 2020
Merged
@SimenB SimenB deleted the patch-1 branch January 28, 2020 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tanhauhau tanhauhau Awaiting requested review from tanhauhau

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@SimenB @tanhauhau