Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: update prettier peer dependency semVer to include 3.x #239

Merged
merged 4 commits into from Jul 21, 2023

Conversation

basselworkforce
Copy link
Contributor

As per Issue 171 prettier 3 should be compatible now.

Update peer dependency to allow prettier 3.x and avoid dependency conflicts.

@djshubs
Copy link

djshubs commented Jul 11, 2023

This would be awesome to have so we can upgrade to Prettier 3.0.0

@krzysztof-cislo
Copy link

When can we expect this PR to be merged? 🙂

@chentsulin
Copy link

@ayusharma Is this ready to merge and publish?

@iursevla
Copy link

@ayusharma Is this ready to merge and publish?

@DAcodedBEAT @marklai1998 @ayusharma Pretty please 🙏

@ayusharma
Copy link
Collaborator

I will release it in a day or two. Sorry on vacation 🌴, Thanks for your patience.

@danriedl
Copy link

No pressure @ayusharma
image

@ayusharma ayusharma merged commit 62fc909 into trivago:main Jul 21, 2023
3 checks passed
@basselworkforce
Copy link
Contributor Author

Thanks @ayusharma, please note everyone that during my testing I found that I now had to add the plugin to the config with npm (when I never had to before) as per:

module.exports = {
    ...
    "plugins": ["@trivago/prettier-plugin-sort-imports"]
}

https://github.com/trivago/prettier-plugin-sort-imports#usage

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants