Update swc_core to v0.75.23
#4470
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
7 Ignored Deployments
|
|
|
✅ This changes can build |
padmaia
approved these changes
Apr 7, 2023
This was referenced Apr 7, 2023
Benchmark for 724875aClick to view benchmark
|
sokra
reviewed
Apr 18, 2023
| @@ -215,9 +222,15 @@ impl EcmascriptInputTransform { | |||
| ..Default::default() | |||
| }; | |||
| let p = std::mem::replace(program, Program::Module(Module::dummy())); | |||
| let hash = { | |||
| let mut hasher = DefaultHasher::new(); | |||
| p.hash(&mut hasher); | |||
There was a problem hiding this comment.
That sounds pretty expensive. Do we need to hash the whole AST?
There was a problem hiding this comment.
What I actually need is the hash of the source code. Would it be better?
There was a problem hiding this comment.
We can pass that via TransformContext
There was a problem hiding this comment.
But how is the transform using that? Would a comment change have effects on the transform?
There was a problem hiding this comment.
It's used to generate a hash for the file.
Related: swc-project/plugins#163
sokra
approved these changes
Apr 18, 2023
kdy1
added
the
pr: automerge
sokra
approved these changes
Apr 18, 2023
Benchmark for 7ee7bb3Click to view benchmark
|
sokra
pushed a commit
to vercel/next.js
that referenced
this pull request
Apr 18, 2023
Depends on vercel/turbo#4470 --- - Closes #46989 - Fixes WEB-879 - Fixes WEB-813 --------- Co-authored-by: OJ Kwon <1210596+kwonoj@users.noreply.github.com> Co-authored-by: Donny/강동윤 <kdy1997.dev@gmail.com> Co-authored-by: Shu Ding <g@shud.in>
NicholasLYang
pushed a commit
to NicholasLYang/turbo
that referenced
this pull request
Apr 21, 2023
### Description This update includes an improvement of `@swc/helpers`, so we need to update `@swc/helpers` too when updating next-swc. ### Testing Instructions Fix WEB-744 Fix WEB-859 --- - Fixes vercel#2825. - Fixes vercel#4092.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This update includes an improvement of
@swc/helpers, so we need to update@swc/helperstoo when updating next-swc.Testing Instructions
Fix WEB-744
Fix WEB-859