chore(deps): bump vue to 3.2 #889
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xanf
force-pushed
the
xanf-upgrade-to-vue-3-2
branch
2 times, most recently
from
125011c
to
e58991b
Compare
This was referenced Aug 26, 2021
|
Ouch, it seems that |
|
LMK if I can help out - something seems broken somewhere in Vue core, this should not be breaking us 🤔 |
xanf
force-pushed
the
xanf-upgrade-to-vue-3-2
branch
from
e58991b
to
29d7dbe
Compare
|
vuejs/core#4460 opened with fix and root cause analysis. Meanwhile, I've downgraded version only of vue-compat here to I believe this Vue bump fixes issues with #890 too :) |
xanf
force-pushed
the
xanf-upgrade-to-vue-3-2
branch
3 times, most recently
from
75a2efa
to
86fb3ef
Compare
xanf
commented
Aug 27, 2021
| @@ -322,7 +323,7 @@ describe('emitted', () => { | |||
| expect(wrapper.emitted('foo')).toHaveLength(1) | |||
| }) | |||
|
|
|||
| it.each([EmitsEventSFC, EmitsEventScriptSetup])( | |||
| it.each([EmitsEventSFC, EmitsEventScriptSetup] as DefineComponent[])( | |||
There was a problem hiding this comment.
For some reason Volar (vue-tsc) fails to pick up correct overload for mount, so we've hinting it a bit :)
xanf
force-pushed
the
xanf-upgrade-to-vue-3-2
branch
from
86fb3ef
to
695bf27
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pretty self-describing. Basically there were two reasons for blowing up:
createStub/createTransitionStub-defineComponentdoes not returnComponentOptionswhich creates a super-confusing union search for typescriptComponentOptionswhen defining component, which (without specifying too concrete generics) also created too broad search on generics for typescriptTS2354 This syntax requires an imported helper but module 'tslib' cannot be found.ezolenko/rollup-plugin-typescript2#12 - this is the reason addingtslibas explicit dependency