Change base-select icon from background-image to svg elements #46152
Conversation
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-5522663
branch
4 times, most recently
from
f453f75
to
5b7951d
Compare
Putting the svg in a data url for background-image was not as customizable in CSS for developers, but using an actual svg element is: openui/open-ui#881 Bug: 40146374 Fixed: 337904202 Change-Id: If1528b3df97e31de5b86b27a6aa935223ff0f0a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5522663 Reviewed-by: David Baron <dbaron@chromium.org> Commit-Queue: Joey Arhar <jarhar@chromium.org> Cr-Commit-Position: refs/heads/main@{#1300224}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-5522663
branch
from
5b7951d
to
aaea226
Compare
|
./wpt lint --all --github-checks-text-file=/home/test/artifacts/checkrun.md |
|
Pinged author on the CL. @KyleJu, can you help admin merge? |
testdriver is not supported in reftests: #13183 #46152 I worked around using testdriver in some of these tests, but others really need to use testdriver so I put a comment in them saying that the test probably won't work until testdriver in reftests is supported. These tests are still worth keeping not only for future support but because they work properly when run with run_web_tests.py. Bug: 40146374 Change-Id: I73d02e5ead3c2dd4c84300e78f6502357dd7524b
|
@WeizhongX @KyleJu since this PR added html/semantics/forms/the-select-element/stylable-select/select-appearance-dark-mode.tentative.html, the lint failure wasn't preexisting and admin merging in this case ended up blocking unrelated PRs. I'm quickfixing in #46251. |
|
Ah, sorry... Joey has made https://chromium-review.googlesource.com/c/chromium/src/+/5536157. After that we can remove those lines added to lint.ignore. |
|
@WeizhongX I agree doing that would be great. I don't know quite what would be involved however. Is it blocking Chromium's migration to wptrunner? cc @past |
|
Not blocking, but some tests will fail. |
Putting the svg in a data url for background-image was not as
customizable in CSS for developers, but using an actual svg element is:
openui/open-ui#881
Bug: 40146374
Fixed: 337904202
Change-Id: If1528b3df97e31de5b86b27a6aa935223ff0f0a4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5522663
Reviewed-by: David Baron <dbaron@chromium.org>
Commit-Queue: Joey Arhar <jarhar@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1300224}