Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(types): external module type error (CompoundedComponent) #38666

Merged
merged 2 commits into from Nov 19, 2022

Conversation

wangcch
Copy link
Contributor

@wangcch wangcch commented Nov 18, 2022

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

#33929
#33091

💡 Background and solution

Wrong type for CompoundedComponent from external module
type vs interface alias

📝 Changelog

Language Changelog
🇺🇸 English Fix 'CompoundedComponent' type error from external module
🇨🇳 Chinese 修复外部暴露类 CompoundedComponent 的组建的类型报错

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@github-actions
Copy link
Contributor

github-actions bot commented Nov 18, 2022

@codecov
Copy link

codecov bot commented Nov 18, 2022

Codecov Report

Base: 100.00% // Head: 100.00% // No change to project coverage 👍

Coverage data is based on head (7c02bdf) compared to base (77ea403).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff            @@
##            master    #38666   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          544       544           
  Lines         9353      9353           
  Branches      2649      2649           
=========================================
  Hits          9353      9353           
Impacted Files Coverage Δ
components/badge/index.tsx 100.00% <ø> (ø)
components/button/button.tsx 100.00% <ø> (ø)
components/checkbox/index.tsx 100.00% <ø> (ø)
components/input/index.tsx 100.00% <ø> (ø)
components/mentions/index.tsx 100.00% <ø> (ø)
components/menu/index.tsx 100.00% <ø> (ø)
components/radio/index.tsx 100.00% <ø> (ø)
components/skeleton/Skeleton.tsx 100.00% <ø> (ø)
components/space/index.tsx 100.00% <ø> (ø)
components/switch/index.tsx 100.00% <ø> (ø)
... and 9 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

components/badge/index.tsx Outdated Show resolved Hide resolved
@afc163
Copy link
Member

afc163 commented Nov 18, 2022

Conflicting

@wangcch
Copy link
Contributor Author

wangcch commented Nov 18, 2022

Conflicting

So I don't need to rebase the commit ...👇
1177552

@li-jia-nan
Copy link
Member

rebase

@wangcch
Copy link
Contributor Author

wangcch commented Nov 18, 2022

rebase

ok. and thanks~🙆‍♂️

@hengkx
Copy link
Member

hengkx commented Nov 19, 2022

rebase

@wangcch wangcch force-pushed the fix-compounded-component-type branch from fd65507 to 7c02bdf Compare November 19, 2022 06:13
@wangcch
Copy link
Contributor Author

wangcch commented Nov 19, 2022

rebase

ok 👌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants