Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: end support for Node.js 12.x #4123

Merged
merged 2 commits into from Oct 31, 2022
Merged

Conversation

trivikr
Copy link
Member

@trivikr trivikr commented Oct 31, 2022

Issue

We announced the end of support for Node.js 12.x in the AWS SDK for JavaScript (v3) starting November 1, 2022 back in May.

Description

Bump engines to node >=14.0.0 in package.json

Testing

Verified that error would be thrown in Node.js 12.x if engine-strict=true is set.

$ client-acm> yarn build:include:deps
...

$ client-acm> npm pack
...
npm notice === Tarball Details === 
npm notice name:          @aws-sdk/client-acm                     
npm notice version:       3.200.0                                 
npm notice filename:      @aws-sdk/client-acm-3.200.0.tgz         
npm notice package size:  57.7 kB                                 
npm notice unpacked size: 503.2 kB                                
npm notice shasum:        02b2a9269ce5a0b6b1791063c3f231577d9de4da
npm notice integrity:     sha512-sukMz6DPM2Usi[...]pBEo7wb7X/mHQ==
npm notice total files:   108                                     
npm notice 
aws-sdk-client-acm-3.200.0.tgz
$ test> node -v
v12.22.12

$ test> npm config set engine-strict false

$ test> npm install ../aws-sdk-js-v3/clients/client-acm/aws-sdk-client-acm-3.200.0.tgz
...
+ @aws-sdk/client-acm@3.200.0

$ test> npm config set engine-strict true

$ test> npm install ../aws-sdk-js-v3/clients/client-acm/aws-sdk-client-acm-3.200.0.tgz
...
npm ERR! code ENOTSUP
npm ERR! notsup Unsupported engine for @aws-sdk/client-acm@3.200.0: wanted: {"node":">=14.0.0"} (current: {"node":"12.22.12","npm":"6.14.16"})
npm ERR! notsup Not compatible with your version of node/npm: @aws-sdk/client-acm@3.200.0
npm ERR! notsup Not compatible with your version of node/npm: @aws-sdk/client-acm@3.200.0
npm ERR! notsup Required: {"node":">=14.0.0"}
npm ERR! notsup Actual:   {"npm":"6.14.16","node":"12.22.12"}
...

Error is not thrown on Node.js 14.x

$ test> fnm use 14
Using Node v14.20.1

$ test> npm config set engine-strict true

$ test> npm install ../aws-sdk-js-v3/clients/client-acm/aws-sdk-client-acm-3.200.0.tgz
...
+ @aws-sdk/client-acm@3.200.0

Additional context

Code change to update engines field for new clients smithy-lang/smithy-typescript#623


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@trivikr trivikr changed the title chore(packages): bump supported Node.js version to >=14.0.0 feat: end support for Node.js 12.x Oct 31, 2022
@trivikr trivikr marked this pull request as ready for review October 31, 2022 20:01
@trivikr trivikr requested a review from a team as a code owner October 31, 2022 20:01
@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants