Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New “inspector” folder in Electron 5 package that doesn't do anything? #19075

Closed
3 tasks done
aabuhijleh opened this issue Jul 2, 2019 · 1 comment
Closed
3 tasks done

Comments

@aabuhijleh
Copy link

  • I have read the Contributing Guidelines for this project.

  • I agree to follow the Code of Conduct that this project adheres to.

  • I have searched the issue tracker for an issue that matches the one I want to file, without success.

  • Electron Package Version:
    5.0.6 for 32-bit Windows

  • Operating System:
    Windows 10

  • Last Known Electron Package Version Without This Folder:
    4.2.5

After updating Electron from v4 to v5 I found a new ~9MB folder inspector containing 188 files in the Electron package install path at node_modules/electron/dist/resources/inspector or ${packagedApp}/resources/inspector after packaging with electron-builder. What is this for?

There seems to be no consequences for deleting this folder. I can still use Electron and chrome devtools perfectly fine after removing it.

Can it be safely deleted/excluded from my packaged app?

Any help is appreciated!

@sofianguy
Copy link
Contributor

fixed #19193

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
5.0.x
Fixed in 5.0.7
Development

No branches or pull requests

3 participants