Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: don't package resources/inspector in dist.zip #19193

Merged
merged 1 commit into from Jul 11, 2019
Merged

fix: don't package resources/inspector in dist.zip #19193

merged 1 commit into from Jul 11, 2019

Conversation

miniak
Copy link
Contributor

@miniak miniak commented Jul 10, 2019 •
edited

Description of Change

Fixes #19075

Checklist

Release Notes

Notes: Removed inadvertently included resources/inspector from electron.zip on Windows and Linux.

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Jul 10, 2019
@miniak miniak mentioned this pull request Jul 10, 2019
Merged
3 tasks
@miniak miniak added fast-track 🚅 Indicates that this PR is intended to bypass the 24 hour rule. Needs approval from Releases and removed fast-track 🚅 Indicates that this PR is intended to bypass the 24 hour rule. Needs approval from Releases labels Jul 10, 2019
@miniak miniak self-assigned this Jul 10, 2019
jkleinsc
jkleinsc requested changes Jul 10, 2019
View reviewed changes
Copy link
Contributor

@jkleinsc jkleinsc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@miniak why isn't this change targeting master?

nornagon
nornagon approved these changes Jul 10, 2019
View reviewed changes
Copy link
Member

@nornagon nornagon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jkleinsc this folder isn't present in the zip in master.

@jkleinsc
Copy link
Contributor

@jkleinsc this folder isn't present in the zip in master.

@nornagon thanks!

@miniak
Copy link
Contributor Author

miniak commented Jul 11, 2019

@jkleinsc there is one test failing constantly, which seems to be flake. The original PR #19173, which is a superset of this one is all green.

@zcbenz zcbenz merged commit 3e6cd06 into 5-0-x Jul 11, 2019
@release-clerk
Copy link

release-clerk bot commented Jul 11, 2019

Release Notes Persisted

Removed inadvertently included resources/inspector from electron.zip on Windows and Linux.

@zcbenz zcbenz deleted the miniak/resources-inspector-5-0-x branch July 11, 2019 08:19
@Praveer1981
Copy link

Praveer1981 commented Jul 15, 2019 •
edited

Thanks to fix it. Curious to know - Is it the official release branch ? or will it be merged to another branch in the future.
it is merged to 5-0-X. here X is a variable or its fixed. Are you going to release a new version 5.0.7 very soon with this change ?

@aabuhijleh aabuhijleh mentioned this pull request Jul 16, 2019
Closed
@sofianguy sofianguy mentioned this pull request Jul 16, 2019
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nornagon nornagon nornagon approved these changes

@alexeykuzmin alexeykuzmin alexeykuzmin approved these changes

@jkleinsc jkleinsc jkleinsc approved these changes

@zcbenz zcbenz zcbenz approved these changes

Assignees

@miniak miniak

Labels
new-pr 🌱 PR opened in the last 24 hours
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@miniak @jkleinsc @Praveer1981 @nornagon @alexeykuzmin @zcbenz