feat(eslint-plugin-react-hooks): support ESLint 8.x #22248

MichaelDeBoey · 2021-09-04T19:22:54Z

ESLint has released the first beta versions of v8 🎉
https://eslint.org/blog/2021/08/eslint-v8.0.0-beta.0-released
https://eslint.org/blog/2021/08/eslint-v8.0.0-beta.1-released
https://eslint.org/blog/2021/09/eslint-v8.0.0-beta.2-released

Closes #22051
Closes #22246

CC/ @gaearon

sizebot · 2021-09-04T19:27:26Z

Comparing: 1314299...4f87327

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name	+/-	Base	Current	+/- gzip	Base gzip	Current gzip
oss-stable/react-dom/cjs/react-dom.production.min.js	=	127.60 kB	127.60 kB	=	40.73 kB	40.73 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js	=	130.42 kB	130.42 kB	=	41.66 kB	41.66 kB
facebook-www/ReactDOM-prod.classic.js	=	405.18 kB	405.18 kB	=	75.05 kB	75.05 kB
facebook-www/ReactDOM-prod.modern.js	=	393.75 kB	393.75 kB	=	73.33 kB	73.33 kB
facebook-www/ReactDOMForked-prod.classic.js	=	405.18 kB	405.18 kB	=	75.05 kB	75.05 kB

Significant size changes

Includes any change greater than 0.2%:

(No significant changes)

Generated by 🚫 dangerJS against 4f87327

gaearon · 2021-09-06T19:19:42Z

thank u!

Summary: This sync includes the following changes: - **[95d762e40](facebook/react@95d762e40 )**: Remove duplicate test //<Andrew Clark>// - **[d4d1dc085](facebook/react@d4d1dc085 )**: Reorder VARIANT feature flags ([#22266](facebook/react#22266)) //<Dan Abramov>// - **[2f156eafb](facebook/react@2f156eafb )**: Adjust consoleManagedByDevToolsDuringStrictMode feature flag ([#22253](facebook/react#22253)) //<Dan Abramov>// - **[cfd819332](facebook/react@cfd819332 )**: Add useSyncExternalStore to react-debug-tools ([#22240](facebook/react#22240)) //<Andrew Clark>// - **[8e80592a3](facebook/react@8e80592a3 )**: Remove state queue from useSyncExternalStore ([#22265](facebook/react#22265)) //<Andrew Clark>// - **[06f98c168](facebook/react@06f98c168 )**: Implement useSyncExternalStore in Fiber ([#22239](facebook/react#22239)) //<Andrew Clark>// - **[77912d9a0](facebook/react@77912d9a0 )**: Wire up the native API for useSyncExternalStore ([#22237](facebook/react#22237)) //<Andrew Clark>// - **[031abd24b](facebook/react@031abd24b )**: Add warning and test for useSyncExternalStore when getSnapshot isn't cached ([#22262](facebook/react#22262)) //<salazarm>// - **[b8884de24](facebook/react@b8884de24 )**: break up import keyword to avoid being accidentally parsed as dynamic import statement in external code ([#21918](facebook/react#21918)) //<Jianhua Zheng>// - **[6d6bba5bf](facebook/react@6d6bba5bf )**: Fix typo in ReactUpdatePriority-test.js ([#21958](facebook/react#21958)) //<Ikko Ashimine>// - **[0c0d1ddae](facebook/react@0c0d1ddae )**: feat(eslint-plugin-react-hooks): support ESLint 8.x ([#22248](facebook/react#22248)) //<Michaël De Boey>// - **[1314299c7](facebook/react@1314299c7 )**: Initial shim of useSyncExternalStore ([#22211](facebook/react#22211)) //<Andrew Clark>// - **[fc40f02ad](facebook/react@fc40f02ad )**: Add consoleManagedByDevToolsDuringStrictMode feature flag in React Reconciler ([#22196](facebook/react#22196)) //<Luna Ruan>// - **[46a0f050a](facebook/react@46a0f050a )**: Set up use-sync-external-store package ([#22202](facebook/react#22202)) //<Andrew Clark>// - **[8723e772b](facebook/react@8723e772b )**: Fix a string interpolation typo in ReactHooks test ([#22174](facebook/react#22174)) //<Matt Hargett>// - **[60a30cf32](facebook/react@60a30cf32 )**: Console Logging for StrictMode Double Rendering ([#22030](facebook/react#22030)) //<Luna Ruan>// - **[76bbad3e3](facebook/react@76bbad3e3 )**: Add maxYieldMs feature flag in Scheduler ([#22165](facebook/react#22165)) //<Ricky>// - **[b0b53ae2c](facebook/react@b0b53ae2c )**: Add feature flags for scheduler experiments ([#22105](facebook/react#22105)) //<Ricky>// Changelog: [General][Changed] - React Native sync for revisions bd5bf55...95d762e jest_e2e[run_all_tests] Reviewed By: mdvacca Differential Revision: D30809906 fbshipit-source-id: 131cfdf91e15f67fa59a5d925467e538ee89fe10

vpontis · 2021-10-11T21:13:19Z

Thanks for this @MichaelDeBoey and @gaearon! ESlint 8.x was released today. I think all we need for this package to support ESlint 8.x is to release this commit 👍.

fregante · 2021-10-12T07:15:35Z

Can this be published to the latest tag?

Live badge -> <- it should be higher than 4.2.0

gajus · 2021-10-26T13:27:36Z

Would be good to know what we are waiting for this to get published – I am available to help.

See: - https://eslint.org/blog/2021/10/eslint-v8.0.0-released - https://eslint.org/docs/user-guide/migrating-to-8.0.0 Known issues that need to be fixed first: - [x] wait for import-js/eslint-plugin-import#2191 to be released and merged here - [x] wait for gajus/eslint-plugin-flowtype#496 to be released and merged here - [x] wait for testing-library/eslint-plugin-testing-library#462 to be released and merged here - [ ] wait for mysticatea/eslint-plugin-node#294 to be released and merged here - [ ] wait for facebook/react#22248 to be released and merged here - [ ] release minor/patch version of Adeira Eslint Config before merging this breaking change - [ ] ...

sanemat · 2021-10-29T01:03:16Z

@gaearon sorry to bother you, but could you release eslint-plugin-react-hooks?

nvh95 · 2021-10-30T16:30:10Z

if you are installing eslint-plugin-react-hooks and couldn't install due to the unmet dependency, just use this command to install next version while waiting for the new latest version to be released

npm install --save-dev eslint-plugin-react-hooks@next

or with yarn

yarn add -D eslint-plugin-react-hooks@next

kiranbayram · 2021-11-09T09:41:01Z

Is this already released? if not, could you please release it? Thanks a lot

gaearon · 2021-11-09T13:57:14Z

Sorry, just so you know — pinging me on GH usually doesn't have the desired effect because my notifications are always overflowing. Please feel free to ping on twitter DM in the future. I'll cut a release now.

gaearon · 2021-11-09T13:59:40Z

eslint-plugin-react-hooks@4.3.0 is out

See: - https://eslint.org/blog/2021/10/eslint-v8.0.0-released - https://eslint.org/docs/user-guide/migrating-to-8.0.0 Known issues that need to be fixed first: - [x] wait for import-js/eslint-plugin-import#2191 to be released and merged here - [x] wait for gajus/eslint-plugin-flowtype#496 to be released and merged here - [x] wait for testing-library/eslint-plugin-testing-library#462 to be released and merged here - [ ] wait for mysticatea/eslint-plugin-node#294 to be released and merged here - [x] wait for facebook/react#22248 to be released and merged here - [ ] release minor/patch version of Adeira Eslint Config before merging this breaking change - [ ] ...

See: - https://eslint.org/blog/2021/10/eslint-v8.0.0-released - https://eslint.org/docs/user-guide/migrating-to-8.0.0 Known unresolved issues (with low impact )that we decided to accept: - mysticatea/eslint-plugin-node#301 Known issues that need to be fixed first: - [x] wait for import-js/eslint-plugin-import#2191 to be released and merged here - [x] wait for gajus/eslint-plugin-flowtype#496 to be released and merged here - [x] wait for testing-library/eslint-plugin-testing-library#462 to be released and merged here - [ ] ~wait for mysticatea/eslint-plugin-node#294 to be released and merged here~ replaced (probably temporarily) with `eslint-plugin-n` which supports Eslint 8 - [x] wait for facebook/react#22248 to be released and merged here - [x] release minor/patch version of Adeira Eslint Config before merging this breaking change - [x] switch `NEXT_VERSION_ERROR` to `ERROR` (#3625)

See: - https://eslint.org/blog/2021/10/eslint-v8.0.0-released - https://eslint.org/docs/user-guide/migrating-to-8.0.0 Known unresolved issues (with low impact )that we decided to accept: - mysticatea/eslint-plugin-node#301 Known issues that need to be fixed first: - [x] wait for import-js/eslint-plugin-import#2191 to be released and merged here - [x] wait for gajus/eslint-plugin-flowtype#496 to be released and merged here - [x] wait for testing-library/eslint-plugin-testing-library#462 to be released and merged here - [ ] ~wait for mysticatea/eslint-plugin-node#294 to be released and merged here~ replaced (probably temporarily) with `eslint-plugin-n` which supports Eslint 8 - [x] wait for facebook/react#22248 to be released and merged here - [x] release minor/patch version of Adeira Eslint Config before merging this breaking change - [x] switch `NEXT_VERSION_ERROR` to `ERROR` (adeira/universe#3625) adeira-source-id: b194be7e4f2fc10d51a10ed8753c440414e36b4d

facebook-github-bot added the CLA Signed label Sep 4, 2021

This was referenced Sep 4, 2021

feat(eslint-plugin-react-internal): support ESLint 8.x #22249

Merged

feat: support ESLint 8.x kentcdodds/eslint-config-kentcdodds#119

Merged

feat(eslint-plugin-react-hooks): support ESLint 8.x

4f87327

MichaelDeBoey changed the title ~~feat(eslint-plugin): support ESLint 8.x~~ feat(eslint-plugin-react-hooks): support ESLint 8.x Sep 4, 2021

MichaelDeBoey force-pushed the eslint-plugin/eslint-8 branch from 6a8ffd2 to 4f87327 Compare September 4, 2021 19:56

MichaelDeBoey mentioned this pull request Sep 4, 2021

feat(eslint-config-react-app): support ESLint 8.x facebook/create-react-app#11375

Merged

60 tasks

gaearon approved these changes Sep 6, 2021

View reviewed changes

gaearon merged commit 0c0d1dd into facebook:main Sep 6, 2021

MichaelDeBoey deleted the eslint-plugin/eslint-8 branch September 6, 2021 23:15

MichaelDeBoey mentioned this pull request Oct 10, 2021

eslint-plugin-react-hooks: eslint v8 support #22533

Closed

ljharb mentioned this pull request Oct 10, 2021

eslint v8 support airbnb/javascript#2478

Closed

22 tasks

MichaelDeBoey mentioned this pull request Oct 10, 2021

feat: support ESLint 8.x gajus/eslint-config-canonical#33

Closed

81 tasks

kimromi mentioned this pull request Oct 12, 2021

Let's support eslint v8 moneyforward/eslint-config-moneyforward#14

Closed

scinos mentioned this pull request Oct 13, 2021

fix(deps): update eslint packages (major) Automattic/wp-calypso#56894

Merged

1 task

fujikky mentioned this pull request Oct 13, 2021

chore(deps): update dependency eslint to v8 jubilee-works/eslint-config-timetree#37

Merged

1 task

eps1lon mentioned this pull request Oct 13, 2021

Bug: Rules with suggestions must set the meta.hasSuggestions property to true #22545

Closed

ykzts mentioned this pull request Oct 13, 2021

Support ESLint v8 vercel/next.js#29865

Merged

8 tasks

mlegenhausen mentioned this pull request Oct 13, 2021

Upgrade to eslint 8 werk85/eslint-config-werk85#25

Closed

4 tasks

koba04 mentioned this pull request Oct 15, 2021

feat: support ESLInt v8 cybozu/eslint-config#501

Merged

1 task

ScottAgirs mentioned this pull request Oct 16, 2021

ESLint v8 Support @ijsto/eslint-config ijsto/eslint-config#10

Closed

jzempel mentioned this pull request Oct 16, 2021

chore!: switch from babel-eslint to @babel/eslint-parser zendeskgarden/eslint-config#176

Merged

1 task

72636c mentioned this pull request Oct 18, 2021

Support ESLint 8.x seek-oss/eslint-config-seek#62

Closed

13 tasks

jenssimon mentioned this pull request Oct 21, 2021

Support ESLint 8 jenssimon/eslint-config-base#6

Closed

6 tasks

chambo-e mentioned this pull request Oct 25, 2021

chore(devdeps): update dependency eslint to v8 scaleway/ultraviolet#819

Merged

1 task

mrtnzlml mentioned this pull request Oct 26, 2021

Eslint: upgrade to version 8.0.0 adeira/universe#3274

Merged

7 tasks

ph-fritsche mentioned this pull request Oct 27, 2021

support eslint@8 ph-fritsche/eslint-config#1

Closed

koba04 mentioned this pull request Oct 28, 2021

chore: update eslint and prettier (major) kufu/eslint-config-smarthr#360

Closed

1 task

manovotny mentioned this pull request Nov 1, 2021

Updates to ESlint 8. manovotny/eslint-config-get-off-my-lawn#175

Merged

4 tasks

Methuselah96 mentioned this pull request Nov 9, 2021

chore(deps): update dependency eslint to v8 reduxjs/redux-devtools#902

Merged

1 task

zhengjitf pushed a commit to zhengjitf/react that referenced this pull request Apr 15, 2022

feat(eslint-plugin-react-hooks): support ESLint 8.x (facebook#22248)

0c9d2d8

luketanner mentioned this pull request Sep 23, 2022

Merge main branch from upstream facebook/react (particularly for compatibility with ESLint 8.x) grncdr/react#1

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(eslint-plugin-react-hooks): support ESLint 8.x #22248

feat(eslint-plugin-react-hooks): support ESLint 8.x #22248

MichaelDeBoey commented Sep 4, 2021 •

edited

sizebot commented Sep 4, 2021 •

edited

gaearon commented Sep 6, 2021

vpontis commented Oct 11, 2021

fregante commented Oct 12, 2021 •

edited

gajus commented Oct 26, 2021

sanemat commented Oct 29, 2021

nvh95 commented Oct 30, 2021 •

edited

kiranbayram commented Nov 9, 2021

gaearon commented Nov 9, 2021

gaearon commented Nov 9, 2021

feat(eslint-plugin-react-hooks): support ESLint 8.x #22248

feat(eslint-plugin-react-hooks): support ESLint 8.x #22248

Conversation

MichaelDeBoey commented Sep 4, 2021 • edited

sizebot commented Sep 4, 2021 • edited

Critical size changes

Significant size changes

gaearon commented Sep 6, 2021

vpontis commented Oct 11, 2021

fregante commented Oct 12, 2021 • edited

gajus commented Oct 26, 2021

sanemat commented Oct 29, 2021

nvh95 commented Oct 30, 2021 • edited

kiranbayram commented Nov 9, 2021

gaearon commented Nov 9, 2021

gaearon commented Nov 9, 2021

MichaelDeBoey commented Sep 4, 2021 •

edited

sizebot commented Sep 4, 2021 •

edited

fregante commented Oct 12, 2021 •

edited

nvh95 commented Oct 30, 2021 •

edited