Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(deps): update eslint packages (major) #56894

Merged
merged 3 commits into from Dec 14, 2021
Merged

fix(deps): update eslint packages (major) #56894

merged 3 commits into from Dec 14, 2021

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Oct 8, 2021 •
edited

WhiteSource Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
eslint (source) ^7.32.0 -> ^8.3.0 age adoption passing confidence
eslint-plugin-jest ^24.7.0 -> ^25.3.0 age adoption passing confidence
eslint-plugin-jsdoc ^36.1.1 -> ^37.0.3 age adoption passing confidence
eslint-plugin-prettier ^3.4.1 -> ^4.0.0 age adoption passing confidence

Release Notes

eslint/eslint

v8.3.0

Compare Source

Features

  • 60b0a29 feat: add allowProperties option to require-atomic-updates (#​15238) (Milos Djermanovic)
  • 79278a1 feat: update no-use-before-define for class static blocks (#​15312) (Milos Djermanovic)
  • ddd01dc feat: update no-redeclare for class static blocks (#​15313) (Milos Djermanovic)
  • de69cec feat: update no-inner-declarations for class static blocks (#​15290) (Milos Djermanovic)
  • e2fe7ef feat: support for private-in syntax (fixes #​14811) (#​15060) (Yosuke Ota)
  • 34bc8d7 feat: Update espree and eslint-scope (#​15338) (Brandon Mills)
  • b171cd7 feat: update max-depth for class static blocks (#​15316) (Milos Djermanovic)
  • 6487df3 feat: update padded-blocks for class static blocks (#​15333) (Milos Djermanovic)
  • 194f36d feat: update the complexity rule for class static blocks (#​15328) (Milos Djermanovic)
  • 3530337 feat: update the indent rule for class static blocks (#​15324) (Milos Djermanovic)
  • f03cd14 feat: update lines-around-comment for class static blocks (#​15323) (Milos Djermanovic)
  • 5c64747 feat: update brace-style for class static blocks (#​15322) (Milos Djermanovic)
  • df2f1cc feat: update max-statements for class static blocks (#​15315) (Milos Djermanovic)
  • fd5a0b8 feat: update prefer-const for class static blocks (#​15325) (Milos Djermanovic)
  • b3669fd feat: code path analysis for class static blocks (#​15282) (Milos Djermanovic)
  • 15c1397 feat: update eslint-scope for class static blocks (#​15321) (Milos Djermanovic)
  • 1a1bb4b feat: update one-var for class static blocks (#​15317) (Milos Djermanovic)
  • 9b666e0 feat: update padding-line-between-statements for class static blocks (#​15318) (Milos Djermanovic)
  • d3a267f feat: update class-methods-use-this for class static blocks (#​15298) (Milos Djermanovic)
  • cdaa541 feat: update no-lone-blocks for class static blocks (#​15295) (Milos Djermanovic)
  • 8611538 feat: update block-spacing for class static blocks (#​15297) (Milos Djermanovic)
  • 7b56844 feat: update keyword-spacing for class static blocks (#​15289) (Milos Djermanovic)
  • ea18711 feat: update no-extra-semi for class static blocks (#​15287) (Milos Djermanovic)
  • 0f0971f feat: update semi rule for class static blocks (#​15286) (Milos Djermanovic)
  • abe740c feat: add examples for block-scoped-var with class static blocks (#​15302) (Milos Djermanovic)
  • 0338fd2 feat: Normalize ecmaVersion to eslint-scope when using custom parser (#​15268) (Yosuke Ota)

Bug Fixes

  • 8aa7645 fix: update vars-on-top for class static blocks (#​15306) (Milos Djermanovic)
  • 479a4cb fix: update semi-style for class static blocks (#​15309) (Milos Djermanovic)
  • 6d1c666 fix: update no-invalid-this and no-eval for class static blocks (#​15300) (Milos Djermanovic)

Documentation

  • 6b85426 docs: Expand --debug option description in the CLI documentation (#​15308) (darkred)
  • 3ae5258 docs: the strict rule does not apply to class static blocks (#​15314) (Milos Djermanovic)
  • 9309841 docs: Remove inconsistent colon in pull request docs (#​15303) (Jordan Eldredge)
  • da238cc docs: remove deprecation note from lines-around-comment (#​15293) (Milos Djermanovic)
  • 1055f16 docs: no-unused-expressions - class static blocks don't have directives (#​15283) (Milos Djermanovic)
  • 4c55216 docs: Add variables option to no-use-before-define (#​15276) (Mathias Rasmussen)

Chores

  • edd8d24 chore: upgrade eslint-visitor-keys for class static blocks (#​15277) (Milos Djermanovic)

v8.2.0

Compare Source

Features
  • c9fefd2 feat: report class evaluation TDZ errors in no-use-before-define (#​15134) (Milos Djermanovic)
Documentation
  • c415c04 docs: Use string rule severity in CLI examples (#​15253) (Kevin Partington)
  • 12b627d docs: fix typo in working-with-rules.md (#​15233) (Nitin Kumar)
  • a86ffc0 docs: fix broken anchor in configuration files (#​15223) (Pierre Berger)
  • ee8af5f docs: Link to unit tests from rule documentation (#​15207) (Brandon Mills)
  • 1c0ca3c docs: add ci and perf tags for commit (#​15215) (Nitin Kumar)
Build Related
  • 796587a build: upgrade eslint-release to v3.2.0 to support conventional commits (#​15246) (Milos Djermanovic)
Chores

v8.1.0

Compare Source

v8.0.1

Compare Source

v8.0.0

Compare Source

jest-community/eslint-plugin-jest

v25.3.0

Compare Source

Features

25.2.4 (2021-11-08)

Bug Fixes
  • prefer-to-be: preserve resolves and rejects modifiers (#​980) (a1296bd)

25.2.3 (2021-11-04)

Bug Fixes
  • no-deprecated-functions: mark jest as an optional peer dependency (#​970) (f468752)

25.2.2 (2021-10-17)

Bug Fixes
  • require-hook: check variables are either const or declarations (#​959) (ce8cd61)

25.2.1 (2021-10-15)

Bug Fixes
  • expect-expect: don't error on it.todo & test.todo calls (#​954) (d3cc0db)

v25.2.4

Compare Source

Bug Fixes
  • prefer-to-be: preserve resolves and rejects modifiers (#​980) (a1296bd)

v25.2.3

Compare Source

Bug Fixes
  • no-deprecated-functions: mark jest as an optional peer dependency (#​970) (f468752)

v25.2.2

Compare Source

Bug Fixes
  • require-hook: check variables are either const or declarations (#​959) (ce8cd61)

v25.2.1

Compare Source

Bug Fixes
  • expect-expect: don't error on it.todo & test.todo calls (#​954) (d3cc0db)

v25.2.0

Compare Source

Features
  • expect-expect: support additionalTestBlockFunctions option (#​850) (3b94c62)

v25.1.0

Compare Source

Features

25.0.6 (2021-10-14)

Bug Fixes

25.0.5 (2021-10-11)

Bug Fixes

25.0.4 (2021-10-11)

Bug Fixes
  • update @typescript-eslint/experimental-utils to v5 (#​941) (afad49a)

25.0.3 (2021-10-11)

Bug Fixes
  • valid-expect-in-promise: support awaited promises in arguments (#​936) (bd2c33c)

25.0.2 (2021-10-11)

Bug Fixes
  • valid-expect-in-promise: support out of order awaits (#​939) (07d2137)

25.0.1 (2021-10-10)

Bug Fixes
  • specify peer dependency ranges correctly (cb87458)

v25.0.6

Compare Source

Bug Fixes

v25.0.5

Compare Source

Bug Fixes

v25.0.4

Compare Source

Bug Fixes
  • update @typescript-eslint/experimental-utils to v5 (#​941) (afad49a)

v25.0.3

Compare Source

Bug Fixes
  • valid-expect-in-promise: support awai

Configuration

📅 Schedule: At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.

  • If you want to rebase/retry this PR, click this checkbox.

This PR has been generated by WhiteSource Renovate. View repository job log here.

@github-actions
Copy link

github-actions bot commented Oct 8, 2021 •
edited by matticbot

Link to Calypso live: https://calypso.live?image=registry.a8c.com/calypso/app:build-22340
Link to Jetpack Cloud live: https://calypso.live?image=registry.a8c.com/calypso/app:build-22340&env=jetpack

@matticbot
Copy link
Contributor

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

@renovate renovate bot force-pushed the renovate/major-eslint-packages branch from 421f608 to d6f9fe0 Compare October 9, 2021 22:37
@renovate renovate bot changed the title fix(deps): update dependency eslint-plugin-prettier to v4 chore(deps): update eslint packages (major) Oct 9, 2021
@renovate renovate bot force-pushed the renovate/major-eslint-packages branch 6 times, most recently from 13bf27c to 6043916 Compare October 13, 2021 03:52
@scinos
Copy link
Contributor

scinos commented Oct 13, 2021 •
edited

Blocked by

Requires:

@scinos scinos self-assigned this Oct 13, 2021
@renovate renovate bot force-pushed the renovate/major-eslint-packages branch 6 times, most recently from b182940 to 6e12674 Compare October 17, 2021 11:33
@renovate renovate bot force-pushed the renovate/major-eslint-packages branch 6 times, most recently from 4ed7904 to 9a36117 Compare October 27, 2021 01:34
@renovate renovate bot force-pushed the renovate/major-eslint-packages branch 3 times, most recently from 856029a to 9a7cc53 Compare November 8, 2021 05:25
@scinos scinos mentioned this pull request Nov 19, 2021
Merged
1 task
@renovate renovate bot force-pushed the renovate/major-eslint-packages branch 2 times, most recently from f41b35e to 3b849fc Compare November 23, 2021 08:41
@renovate renovate bot force-pushed the renovate/major-eslint-packages branch 4 times, most recently from d375af6 to 9faff21 Compare December 4, 2021 05:36
@noahtallen
Copy link
Member

@scinos can we move forward with this one now?

@scinos
Copy link
Contributor

scinos commented Dec 7, 2021

Is the new version of @wordpress/eslint-plugin released? I didn't find it.

@renovate renovate bot force-pushed the renovate/major-eslint-packages branch from 9faff21 to 250fb37 Compare December 7, 2021 04:16
@noahtallen
Copy link
Member

I don't see it either, though some wordpress packages did get updated recently. (just not that one)

@renovate renovate bot force-pushed the renovate/major-eslint-packages branch 4 times, most recently from 4fe3a7e to aff7a9e Compare December 13, 2021 21:26
@noahtallen
Copy link
Member

Still not available with the latest round of updates either. 🤔

@renovate renovate bot force-pushed the renovate/major-eslint-packages branch from aff7a9e to 482f6fb Compare December 14, 2021 12:13
@scinos
Squashed commit of the following:
2948023 
commit 1a7d792
Author: Sergio Cinos <sergio.cinos@gmail.com>
Date:   Tue Dec 14 12:57:42 2021 +0100

    Dedupe packges

commit 718907c
Author: Sergio Cinos <sergio.cinos@gmail.com>
Date:   Tue Dec 14 12:42:02 2021 +0100

    Set explicit parser for .md.js files

commit 724936a
Author: Sergio Cinos <sergio.cinos@gmail.com>
Date:   Tue Dec 14 12:34:33 2021 +0100

    More eslint updates

commit 7cd106d
Author: Sergio Cinos <sergio.cinos@gmail.com>
Date:   Tue Dec 14 12:31:50 2021 +0100

    Update eslint-plugin-inclusive-language and eslint-plugin-react

commit ab6942b
Author: Sergio Cinos <sergio.cinos@gmail.com>
Date:   Tue Dec 14 12:11:17 2021 +0100

    Ignore yarn warnings

commit 1b3e83a
Author: Sergio Cinos <sergio.cinos@gmail.com>
Date:   Tue Dec 14 12:05:55 2021 +0100

    Update `@typescript-eslint/eslint-plugin` and `@typescript-eslint/parser`

commit 94daa23
Author: Renovate Bot <bot@renovateapp.com>
Date:   Mon Dec 13 21:26:54 2021 +0000

    fix(deps): update eslint packages
@renovate renovate bot requested review from scinos, WunderBart and a team as code owners December 14, 2021 14:19
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Dec 14, 2021
@scinos
Copy link
Contributor

scinos commented Dec 14, 2021 •
edited

I've forced Eslint 8 in a branch(https://teamcity.a8c.com/buildConfiguration/calypso_CheckCodeStyleBranch/7125831?buildTab=Inspection) by just ignoring Yarn errors... and it just works.

The only thing I had to change is to specify a Prettier parser for JavaScript blocks in markdown files.

@noahtallen
Copy link
Member

More context from @gziolo about why it's not available on npm yet: WordPress/gutenberg#35576 (comment)

noahtallen
noahtallen approved these changes Dec 14, 2021
View reviewed changes
Copy link
Member

@noahtallen noahtallen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 Also tested eslint locally, and VS Code is still correctly reporting lint issues.

@noahtallen noahtallen merged commit d2ec641 into trunk Dec 14, 2021
@noahtallen noahtallen deleted the renovate/major-eslint-packages branch December 14, 2021 21:27
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Dec 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noahtallen noahtallen noahtallen approved these changes

@scinos scinos Awaiting requested review from scinos

@WunderBart WunderBart Awaiting requested review from WunderBart

Assignees

@scinos scinos

Labels
Framework [Status] Blocked / Hold [Type] Task
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@matticbot @scinos @noahtallen @renovate-bot