Fixes #2877: removed mockito-inline as subproject and actual subproject #2945
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krzyk
force-pushed
the
2877-inline-subproject-removal
branch
from
6bc8607
to
1f8b387
Compare
|
Sorry I was a bit surprised that ANDROID_HOME needs to be set to run part of android tests. |
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #2945 +/- ##
=========================================
Coverage 85.65% 85.65%
Complexity 2860 2860
=========================================
Files 325 325
Lines 8682 8682
Branches 1071 1071
=========================================
Hits 7437 7437
Misses 967 967
Partials 278 278 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
|
Seems like this would reduce our test coverage by quite a lot. Can we keep the inline test suite and rather it depending on |
krzyk
force-pushed
the
2877-inline-subproject-removal
branch
from
1f8b387
to
daecb70
Compare
|
@TimvdLippe Sure, I replaced the dependency in groovyInline tests |
|
It seems like that didn't make an impact on the code coverage and the PR appears to delete tests still. Can you add back these tests? |
krzyk
force-pushed
the
2877-inline-subproject-removal
branch
from
daecb70
to
108c0be
Compare
|
@TimvdLippe Yes, I misunderstood your previous comment. Now all the tests are back. |
TimvdLippe
reviewed
Mar 17, 2023
krzyk
force-pushed
the
2877-inline-subproject-removal
branch
from
108c0be
to
19965ff
Compare
TimvdLippe
reviewed
Mar 17, 2023
krzyk
force-pushed
the
2877-inline-subproject-removal
branch
from
19965ff
to
c2e7800
Compare
TimvdLippe
approved these changes
Mar 18, 2023
12 tasks
MarkEWaite
added a commit
to MarkEWaite/git-plugin
that referenced
this pull request
Apr 17, 2023
https://github.com/jenkinsci/plugin-pom/releases/tag/plugin-4.60 mockito-inline was removed in mockito/mockito#2945, replaced with mockito-core. C
MarkEWaite
added a commit
to MarkEWaite/gitlab-plugin
that referenced
this pull request
Apr 17, 2023
jenkinsci/embeddable-build-status-plugin#191 notes that mockito-inline was removed in mockito/mockito#2945, replaced with mockito-core. Consumers of mockito-inline should replace their dependency on mockito-inline with a dependency on mockito-core. This change prepares for the bump of the parent pom from 4.59 to 4.60.
MarkEWaite
added a commit
to MarkEWaite/git-plugin
that referenced
this pull request
Apr 17, 2023
mockito-inline was removed in mockito/mockito#2945, replaced with mockito-core. Consumers of mockito-inline should replace their dependency on mockito-inline with a dependency on mockito-core.
MarkEWaite
added a commit
to jenkinsci/gitlab-plugin
that referenced
this pull request
Apr 17, 2023
jenkinsci/embeddable-build-status-plugin#191 notes that mockito-inline was removed in mockito/mockito#2945, replaced with mockito-core. Consumers of mockito-inline should replace their dependency on mockito-inline with a dependency on mockito-core. This change prepares for the bump of the parent pom from 4.59 to 4.60.
MarkEWaite
added a commit
to jenkinsci/apache-httpcomponents-client-4-api-plugin
that referenced
this pull request
Apr 17, 2023
mockito-inline was removed in mockito/mockito#2945, replaced with mockito-core. Consumers of mockito-inline should replace their dependency on mockito-inline with a dependency on mockito-core.
MarkEWaite
added a commit
to jenkinsci/git-plugin
that referenced
this pull request
Apr 17, 2023
https://github.com/jenkinsci/plugin-pom/releases/tag/plugin-4.60 mockito-inline was removed in mockito/mockito#2945, replaced with mockito-core.
MarkEWaite
added a commit
to jenkinsci/authorize-project-plugin
that referenced
this pull request
Apr 18, 2023
mockito-inline was removed in mockito/mockito#2945, replaced with mockito-core. Consumers of mockito-inline should replace their dependency on mockito-inline with a dependency on mockito-core.
MarkEWaite
added a commit
to jenkinsci/cloud-stats-plugin
that referenced
this pull request
Apr 18, 2023
mockito-inline was removed in mockito/mockito#2945, replaced with mockito-core. Consumers of mockito-inline should replace their dependency on mockito-inline with a dependency on mockito-core.
MarkEWaite
added a commit
to jenkinsci/git-client-plugin
that referenced
this pull request
Apr 18, 2023
mockito-inline was removed in mockito/mockito#2945, replaced with mockito-core. Consumers of mockito-inline should replace their dependency on mockito-inline with a dependency on mockito-core.
MarkEWaite
added a commit
to jenkinsci/implied-labels-plugin
that referenced
this pull request
Apr 18, 2023
mockito-inline was removed in mockito/mockito#2945, replaced with mockito-core. Consumers of mockito-inline should replace their dependency on mockito-inline with a dependency on mockito-core.
MarkEWaite
added a commit
to jenkinsci/markdown-formatter-plugin
that referenced
this pull request
Apr 18, 2023
mockito-inline was removed in mockito/mockito#2945, replaced with mockito-core. Consumers of mockito-inline should replace their dependency on mockito-inline with a dependency on mockito-core.
MarkEWaite
added a commit
to jenkinsci/nodelabelparameter-plugin
that referenced
this pull request
Apr 18, 2023
mockito-inline was removed in mockito/mockito#2945, replaced with mockito-core. Consumers of mockito-inline should replace their dependency on mockito-inline with a dependency on mockito-core.
MarkEWaite
added a commit
to jenkinsci/platformlabeler-plugin
that referenced
this pull request
Apr 18, 2023
mockito-inline was removed in mockito/mockito#2945, replaced with mockito-core. Consumers of mockito-inline should replace their dependency on mockito-inline with a dependency on mockito-core.
MarkEWaite
added a commit
to jenkinsci/pre-scm-buildstep-plugin
that referenced
this pull request
Apr 18, 2023
mockito-inline was removed in mockito/mockito#2945, replaced with mockito-core. Consumers of mockito-inline should replace their dependency on mockito-inline with a dependency on mockito-core.
MarkEWaite
added a commit
to jenkinsci/priority-sorter-plugin
that referenced
this pull request
Apr 18, 2023
mockito-inline was removed in mockito/mockito#2945, replaced with mockito-core. Consumers of mockito-inline should replace their dependency on mockito-inline with a dependency on mockito-core.
MarkEWaite
added a commit
to jenkinsci/schedule-build-plugin
that referenced
this pull request
Apr 18, 2023
mockito-inline was removed in mockito/mockito#2945, replaced with mockito-core. Consumers of mockito-inline should replace their dependency on mockito-inline with a dependency on mockito-core.
MarkEWaite
added a commit
to jenkinsci/testng-plugin-plugin
that referenced
this pull request
Apr 18, 2023
mockito-inline was removed in mockito/mockito#2945, replaced with mockito-core. Consumers of mockito-inline should replace their dependency on mockito-inline with a dependency on mockito-core.
MarkEWaite
added a commit
to jenkinsci/versioncolumn-plugin
that referenced
this pull request
Apr 18, 2023
mockito-inline was removed in mockito/mockito#2945, replaced with mockito-core. Consumers of mockito-inline should replace their dependency on mockito-inline with a dependency on mockito-core.
MarkEWaite
added a commit
to jenkinsci/xshell-plugin
that referenced
this pull request
Apr 18, 2023
mockito-inline was removed in mockito/mockito#2945, replaced with mockito-core. Consumers of mockito-inline should replace their dependency on mockito-inline with a dependency on mockito-core.
This was referenced Apr 19, 2023
16 tasks
ddellspe
added a commit
to ddellspe/music-bot
that referenced
this pull request
Apr 26, 2023
bessonm
added a commit
to chutney-testing/chutney-legacy
that referenced
this pull request
Jul 28, 2023
Project has been removed and integrated into core cf. mockito/mockito#2945
bessonm
added a commit
to chutney-testing/chutney-legacy
that referenced
this pull request
Aug 4, 2023
Project has been removed and integrated into core cf. mockito/mockito#2945
nbrouand
pushed a commit
to chutney-testing/chutney-legacy
that referenced
this pull request
Aug 16, 2023
Project has been removed and integrated into core cf. mockito/mockito#2945
boddissattva
pushed a commit
to chutney-testing/chutney-legacy
that referenced
this pull request
Sep 8, 2023
Project has been removed and integrated into core cf. mockito/mockito#2945
1 task
shakuzen
added a commit
to micrometer-metrics/micrometer
that referenced
this pull request
Oct 4, 2023
Changes specific to 1.10.x as part of TOML conversion: * Mockito-inline removed; this is included in mockito-core and no longer released[1] * Jackson upgraded from RC release to latest patch in minor (2.14.2). * Mongo 4.8.0-beta0 to 4.8.2 * Hazelcast 5.2-BETA-1 to 5.2.4 * [otlp] uk.org.webcompere:system-stubs-jupiter 2.0.2 to 2.1.3 to get rid of old mockito-inline dependency * Jakarta servlet-api consistently is 5.0.0 now instead of a mix of 4.0.4 and 5.0.0 * Remove unused test dependencies from micrometer-commons I compared the lockfiles that would be generated with this to the previous lockfiles. Only the above mentioned changes (and spotless plugin related scope differences) were found as different between the two. [1] mockito/mockito#2945
jonatan-ivanov
added a commit
to micrometer-metrics/micrometer
that referenced
this pull request
Oct 5, 2023
* Add com.netflix.nebula:gradle-info-plugin (we force its version on main) * Add jakarta.jms:jakarta.jms-api * Add com.squareup.retrofit2:retrofit * Add org.apache.activemq:artemis-junit-5 * Add org.apache.activemq:artemis-jakarta-client:latest.release * Add io.grpc:grpc-inprocess (was part of grpc-core) * Remove mockito-inline; included in mockito-core and no longer released[1] * Downgrade org.apache.httpcomponents.client5:httpclient5 from 5.3-alpha1 to 5.2.1 * Consistently use jakarta.servlet-api:5.0.0 instead of a mix of 4.0.4 and 5.0.0 * Upgrade versions coming from 1.11.x [1] mockito/mockito#2945 See: gh-4095
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2877 as suggested in #2877 removed inline from settings.gradle.kts and also the inline subproject itself.
Also removed groovyInlineTest which was testing this subproject.
Checklist
including project members to get a better picture of the change
commit is meaningful and help the people that will explore a change in 2 years
Fixes #<issue number>in the description if relevantFixes #<issue number>if relevant