Do not allocate memory when there's no constraints #1296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bwplotka
reviewed
Jun 19, 2023
bwplotka
reviewed
Jun 19, 2023
There was a problem hiding this comment.
Nice, thanks for this!
I think it makes sense, but we need to clean up those benchmarks. They are mostly duplicate and will get obsolete very soon. So either we use b.Run or remove them for now.
BTW Were those useful? Did you gather some info? Or just helped you to finalized the implementation? (:
They essentially helped me to see the progress and if there were some remaining optimisations that could be done. |
|
Great 💪🏽 I feel we can either drop those benchmark for now if you don't have time to clean them or create one or two with table tests so others can run it on their PRs to verify if there is any regression 🤗 |
Signed-off-by: Quentin Devos <4972091+Okhoshi@users.noreply.github.com>
|
Sorry for the delay, I got busy at work and couldn't find the time before :) I rewrote the benchmarks as a table test, it should be easier to maintain like this 👍 |
bwplotka
approved these changes
Jun 27, 2023
|
Any chance we cut get a release that includes this fix? We have some tests that our metrics collection doesn't allocate in go-libp2p, and we currently can't upgrade this dependency past v1.14.0 without causing these tests to fail. |
renovate bot
added a commit
to open-feature/flagd
that referenced
this pull request
Sep 27, 2023
….0 (#939) [](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [github.com/prometheus/client_golang](https://togithub.com/prometheus/client_golang) | require | minor | `v1.16.0` -> `v1.17.0` | --- ### Release Notes <details> <summary>prometheus/client_golang (github.com/prometheus/client_golang)</summary> ### [`v1.17.0`](https://togithub.com/prometheus/client_golang/releases/tag/v1.17.0) [Compare Source](https://togithub.com/prometheus/client_golang/compare/v1.16.0...v1.17.0) #### What's Changed - \[CHANGE] Minimum required go version is now 1.19 (we also test client_golang against new 1.21 version). [#​1325](https://togithub.com/prometheus/client_golang/issues/1325) - \[FEATURE] Add support for Created Timestamps in Counters, Summaries and Historams. [#​1313](https://togithub.com/prometheus/client_golang/issues/1313) - \[ENHANCEMENT] Enable detection of a native histogram without observations. [#​1314](https://togithub.com/prometheus/client_golang/issues/1314) <details><summary>Commits</summary> - Merge v1.16.0 to main by [@​bwplotka](https://togithub.com/bwplotka) in [prometheus/client_golang#1293 - Synchronize common files from prometheus/prometheus by [@​prombot](https://togithub.com/prombot) in [prometheus/client_golang#1297 - ci: define minimal permissions to GitHub workflows by [@​diogoteles08](https://togithub.com/diogoteles08) in [prometheus/client_golang#1295 - Do not allocate memory when there's no constraints by [@​Okhoshi](https://togithub.com/Okhoshi) in [prometheus/client_golang#1296 - Bump golang.org/x/sys from 0.8.0 to 0.9.0 by [@​dependabot](https://togithub.com/dependabot) in [prometheus/client_golang#1306 - Bump google.golang.org/grpc from 1.45.0 to 1.53.0 in /tutorial/whatsup by [@​dependabot](https://togithub.com/dependabot) in [prometheus/client_golang#1307 - histogram: Enable detection of a native histogram without observations by [@​beorn7](https://togithub.com/beorn7) in [prometheus/client_golang#1314 - Bump github.com/prometheus/procfs from 0.10.1 to 0.11.0 by [@​dependabot](https://togithub.com/dependabot) in [prometheus/client_golang#1305 - Synchronize common files from prometheus/prometheus by [@​prombot](https://togithub.com/prombot) in [prometheus/client_golang#1302 - Fix data-race in metric without `code` and `method` but with `WithLabelFromCtx` by [@​tigrato](https://togithub.com/tigrato) in [prometheus/client_golang#1318 - Add missing tick "\`" in README by [@​ZiViZiViZ](https://togithub.com/ZiViZiViZ) in [prometheus/client_golang#1321 - Bump golang.org/x/sys from 0.9.0 to 0.10.0 by [@​dependabot](https://togithub.com/dependabot) in [prometheus/client_golang#1320 - Bump github.com/prometheus/procfs from 0.11.0 to 0.11.1 by [@​dependabot](https://togithub.com/dependabot) in [prometheus/client_golang#1319 - docs: trivial grammar fixes to improve readability in promauto Godoc by [@​sengi](https://togithub.com/sengi) in [prometheus/client_golang#1322 - Add Go 1.21 support by [@​kakkoyun](https://togithub.com/kakkoyun) in [prometheus/client_golang#1325 - Bump client_model by [@​ArthurSens](https://togithub.com/ArthurSens) in [prometheus/client_golang#1323 - histogram docs: Fixed minor nit. by [@​bwplotka](https://togithub.com/bwplotka) in [prometheus/client_golang#1324 - Update building by [@​SuperQ](https://togithub.com/SuperQ) in [prometheus/client_golang#1326 - Bump golang.org/x/sys from 0.10.0 to 0.11.0 by [@​dependabot](https://togithub.com/dependabot) in [prometheus/client_golang#1331 - Bump github.com/prometheus/client_golang from 1.15.1-0.20230416215738-0963f595c689 to 1.16.0 in /tutorial/whatsup by [@​dependabot](https://togithub.com/dependabot) in [prometheus/client_golang#1329 - Bump github.com/prometheus/client_golang from 1.13.1 to 1.16.0 in /examples/middleware by [@​dependabot](https://togithub.com/dependabot) in [prometheus/client_golang#1328 - Bump github.com/prometheus/common from 0.42.0 to 0.44.0 by [@​dependabot](https://togithub.com/dependabot) in [prometheus/client_golang#1284 - Bump github.com/prometheus/common from 0.42.0 to 0.44.0 in /tutorial/whatsup by [@​dependabot](https://togithub.com/dependabot) in [prometheus/client_golang#1330 - Bump google.golang.org/protobuf from 1.30.0 to 1.31.0 by [@​dependabot](https://togithub.com/dependabot) in [prometheus/client_golang#1304 - Synchronize common files from prometheus/prometheus by [@​prombot](https://togithub.com/prombot) in [prometheus/client_golang#1332 - Synchronize common files from prometheus/prometheus by [@​prombot](https://togithub.com/prombot) in [prometheus/client_golang#1338 - Cleanup golangci-lint errcheck by [@​SuperQ](https://togithub.com/SuperQ) in [prometheus/client_golang#1339 - Add go_godebug_non_default_behavior_tlsmaxrsasize_events_total by [@​alexandear](https://togithub.com/alexandear) in [prometheus/client_golang#1348 - Extend Counters, Summaries and Histograms with creation timestamp by [@​ArthurSens](https://togithub.com/ArthurSens) in [prometheus/client_golang#1313 - Fix typos in comments, tests, and errors by [@​alexandear](https://togithub.com/alexandear) in [prometheus/client_golang#1346 - Deprecated comment should begin with "Deprecated:" by [@​alexandear](https://togithub.com/alexandear) in [prometheus/client_golang#1347 - Add changelog entry for 1.17 by [@​ArthurSens](https://togithub.com/ArthurSens) in [prometheus/client_golang#1352 </details> #### New Contributors * @​diogoteles08 made their first contributi[prometheus/client_golang#1295 * @​tigrato made their first contributi[prometheus/client_golang#1318 * @​ZiViZiViZ made their first contributi[prometheus/client_golang#1321 * @​sengi made their first contributi[prometheus/client_golang#1322 * @​ArthurSens made their first contributi[prometheus/client_golang#1323 * @​alexandear made their first contributi[prometheus/client_golang#1348 **Full Changelog**: prometheus/client_golang@v1.16.0...v1.17.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/open-feature/flagd). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi4xMDcuMiIsInVwZGF0ZWRJblZlciI6IjM2LjEwNy4yIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
apricote
pushed a commit
to hetznercloud/hcloud-cloud-controller-manager
that referenced
this pull request
Sep 28, 2023
) [](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [github.com/prometheus/client_golang](https://togithub.com/prometheus/client_golang) | require | minor | `v1.16.0` -> `v1.17.0` | --- ### Release Notes <details> <summary>prometheus/client_golang (github.com/prometheus/client_golang)</summary> ### [`v1.17.0`](https://togithub.com/prometheus/client_golang/releases/tag/v1.17.0) [Compare Source](https://togithub.com/prometheus/client_golang/compare/v1.16.0...v1.17.0) #### What's Changed - \[CHANGE] Minimum required go version is now 1.19 (we also test client_golang against new 1.21 version). [#​1325](https://togithub.com/prometheus/client_golang/issues/1325) - \[FEATURE] Add support for Created Timestamps in Counters, Summaries and Historams. [#​1313](https://togithub.com/prometheus/client_golang/issues/1313) - \[ENHANCEMENT] Enable detection of a native histogram without observations. [#​1314](https://togithub.com/prometheus/client_golang/issues/1314) <details><summary>Commits</summary> - Merge v1.16.0 to main by [@​bwplotka](https://togithub.com/bwplotka) in [prometheus/client_golang#1293 - Synchronize common files from prometheus/prometheus by [@​prombot](https://togithub.com/prombot) in [prometheus/client_golang#1297 - ci: define minimal permissions to GitHub workflows by [@​diogoteles08](https://togithub.com/diogoteles08) in [prometheus/client_golang#1295 - Do not allocate memory when there's no constraints by [@​Okhoshi](https://togithub.com/Okhoshi) in [prometheus/client_golang#1296 - Bump golang.org/x/sys from 0.8.0 to 0.9.0 by [@​dependabot](https://togithub.com/dependabot) in [prometheus/client_golang#1306 - Bump google.golang.org/grpc from 1.45.0 to 1.53.0 in /tutorial/whatsup by [@​dependabot](https://togithub.com/dependabot) in [prometheus/client_golang#1307 - histogram: Enable detection of a native histogram without observations by [@​beorn7](https://togithub.com/beorn7) in [prometheus/client_golang#1314 - Bump github.com/prometheus/procfs from 0.10.1 to 0.11.0 by [@​dependabot](https://togithub.com/dependabot) in [prometheus/client_golang#1305 - Synchronize common files from prometheus/prometheus by [@​prombot](https://togithub.com/prombot) in [prometheus/client_golang#1302 - Fix data-race in metric without `code` and `method` but with `WithLabelFromCtx` by [@​tigrato](https://togithub.com/tigrato) in [prometheus/client_golang#1318 - Add missing tick "\`" in README by [@​ZiViZiViZ](https://togithub.com/ZiViZiViZ) in [prometheus/client_golang#1321 - Bump golang.org/x/sys from 0.9.0 to 0.10.0 by [@​dependabot](https://togithub.com/dependabot) in [prometheus/client_golang#1320 - Bump github.com/prometheus/procfs from 0.11.0 to 0.11.1 by [@​dependabot](https://togithub.com/dependabot) in [prometheus/client_golang#1319 - docs: trivial grammar fixes to improve readability in promauto Godoc by [@​sengi](https://togithub.com/sengi) in [prometheus/client_golang#1322 - Add Go 1.21 support by [@​kakkoyun](https://togithub.com/kakkoyun) in [prometheus/client_golang#1325 - Bump client_model by [@​ArthurSens](https://togithub.com/ArthurSens) in [prometheus/client_golang#1323 - histogram docs: Fixed minor nit. by [@​bwplotka](https://togithub.com/bwplotka) in [prometheus/client_golang#1324 - Update building by [@​SuperQ](https://togithub.com/SuperQ) in [prometheus/client_golang#1326 - Bump golang.org/x/sys from 0.10.0 to 0.11.0 by [@​dependabot](https://togithub.com/dependabot) in [prometheus/client_golang#1331 - Bump github.com/prometheus/client_golang from 1.15.1-0.20230416215738-0963f595c689 to 1.16.0 in /tutorial/whatsup by [@​dependabot](https://togithub.com/dependabot) in [prometheus/client_golang#1329 - Bump github.com/prometheus/client_golang from 1.13.1 to 1.16.0 in /examples/middleware by [@​dependabot](https://togithub.com/dependabot) in [prometheus/client_golang#1328 - Bump github.com/prometheus/common from 0.42.0 to 0.44.0 by [@​dependabot](https://togithub.com/dependabot) in [prometheus/client_golang#1284 - Bump github.com/prometheus/common from 0.42.0 to 0.44.0 in /tutorial/whatsup by [@​dependabot](https://togithub.com/dependabot) in [prometheus/client_golang#1330 - Bump google.golang.org/protobuf from 1.30.0 to 1.31.0 by [@​dependabot](https://togithub.com/dependabot) in [prometheus/client_golang#1304 - Synchronize common files from prometheus/prometheus by [@​prombot](https://togithub.com/prombot) in [prometheus/client_golang#1332 - Synchronize common files from prometheus/prometheus by [@​prombot](https://togithub.com/prombot) in [prometheus/client_golang#1338 - Cleanup golangci-lint errcheck by [@​SuperQ](https://togithub.com/SuperQ) in [prometheus/client_golang#1339 - Add go_godebug_non_default_behavior_tlsmaxrsasize_events_total by [@​alexandear](https://togithub.com/alexandear) in [prometheus/client_golang#1348 - Extend Counters, Summaries and Histograms with creation timestamp by [@​ArthurSens](https://togithub.com/ArthurSens) in [prometheus/client_golang#1313 - Fix typos in comments, tests, and errors by [@​alexandear](https://togithub.com/alexandear) in [prometheus/client_golang#1346 - Deprecated comment should begin with "Deprecated:" by [@​alexandear](https://togithub.com/alexandear) in [prometheus/client_golang#1347 - Add changelog entry for 1.17 by [@​ArthurSens](https://togithub.com/ArthurSens) in [prometheus/client_golang#1352 </details> #### New Contributors * @​diogoteles08 made their first contributi[prometheus/client_golang#1295 * @​tigrato made their first contributi[prometheus/client_golang#1318 * @​ZiViZiViZ made their first contributi[prometheus/client_golang#1321 * @​sengi made their first contributi[prometheus/client_golang#1322 * @​ArthurSens made their first contributi[prometheus/client_golang#1323 * @​alexandear made their first contributi[prometheus/client_golang#1348 **Full Changelog**: prometheus/client_golang@v1.16.0...v1.17.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/hetznercloud/hcloud-cloud-controller-manager). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi4xMDcuMiIsInVwZGF0ZWRJblZlciI6IjM2LjEwNy4yIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
nono
added a commit
to cozy/cozy-stack
that referenced
this pull request
Oct 2, 2023
….0 (#4144) [](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [github.com/prometheus/client_golang](https://togithub.com/prometheus/client_golang) | require | minor | `v1.16.0` -> `v1.17.0` | --- ### Release Notes <details> <summary>prometheus/client_golang (github.com/prometheus/client_golang)</summary> ### [`v1.17.0`](https://togithub.com/prometheus/client_golang/releases/tag/v1.17.0) [Compare Source](https://togithub.com/prometheus/client_golang/compare/v1.16.0...v1.17.0) #### What's Changed - \[CHANGE] Minimum required go version is now 1.19 (we also test client_golang against new 1.21 version). [#​1325](https://togithub.com/prometheus/client_golang/issues/1325) - \[FEATURE] Add support for Created Timestamps in Counters, Summaries and Historams. [#​1313](https://togithub.com/prometheus/client_golang/issues/1313) - \[ENHANCEMENT] Enable detection of a native histogram without observations. [#​1314](https://togithub.com/prometheus/client_golang/issues/1314) <details><summary>Commits</summary> - Merge v1.16.0 to main by [@​bwplotka](https://togithub.com/bwplotka) in [prometheus/client_golang#1293 - Synchronize common files from prometheus/prometheus by [@​prombot](https://togithub.com/prombot) in [prometheus/client_golang#1297 - ci: define minimal permissions to GitHub workflows by [@​diogoteles08](https://togithub.com/diogoteles08) in [prometheus/client_golang#1295 - Do not allocate memory when there's no constraints by [@​Okhoshi](https://togithub.com/Okhoshi) in [prometheus/client_golang#1296 - Bump golang.org/x/sys from 0.8.0 to 0.9.0 by [@​dependabot](https://togithub.com/dependabot) in [prometheus/client_golang#1306 - Bump google.golang.org/grpc from 1.45.0 to 1.53.0 in /tutorial/whatsup by [@​dependabot](https://togithub.com/dependabot) in [prometheus/client_golang#1307 - histogram: Enable detection of a native histogram without observations by [@​beorn7](https://togithub.com/beorn7) in [prometheus/client_golang#1314 - Bump github.com/prometheus/procfs from 0.10.1 to 0.11.0 by [@​dependabot](https://togithub.com/dependabot) in [prometheus/client_golang#1305 - Synchronize common files from prometheus/prometheus by [@​prombot](https://togithub.com/prombot) in [prometheus/client_golang#1302 - Fix data-race in metric without `code` and `method` but with `WithLabelFromCtx` by [@​tigrato](https://togithub.com/tigrato) in [prometheus/client_golang#1318 - Add missing tick "\`" in README by [@​ZiViZiViZ](https://togithub.com/ZiViZiViZ) in [prometheus/client_golang#1321 - Bump golang.org/x/sys from 0.9.0 to 0.10.0 by [@​dependabot](https://togithub.com/dependabot) in [prometheus/client_golang#1320 - Bump github.com/prometheus/procfs from 0.11.0 to 0.11.1 by [@​dependabot](https://togithub.com/dependabot) in [prometheus/client_golang#1319 - docs: trivial grammar fixes to improve readability in promauto Godoc by [@​sengi](https://togithub.com/sengi) in [prometheus/client_golang#1322 - Add Go 1.21 support by [@​kakkoyun](https://togithub.com/kakkoyun) in [prometheus/client_golang#1325 - Bump client_model by [@​ArthurSens](https://togithub.com/ArthurSens) in [prometheus/client_golang#1323 - histogram docs: Fixed minor nit. by [@​bwplotka](https://togithub.com/bwplotka) in [prometheus/client_golang#1324 - Update building by [@​SuperQ](https://togithub.com/SuperQ) in [prometheus/client_golang#1326 - Bump golang.org/x/sys from 0.10.0 to 0.11.0 by [@​dependabot](https://togithub.com/dependabot) in [prometheus/client_golang#1331 - Bump github.com/prometheus/client_golang from 1.15.1-0.20230416215738-0963f595c689 to 1.16.0 in /tutorial/whatsup by [@​dependabot](https://togithub.com/dependabot) in [prometheus/client_golang#1329 - Bump github.com/prometheus/client_golang from 1.13.1 to 1.16.0 in /examples/middleware by [@​dependabot](https://togithub.com/dependabot) in [prometheus/client_golang#1328 - Bump github.com/prometheus/common from 0.42.0 to 0.44.0 by [@​dependabot](https://togithub.com/dependabot) in [prometheus/client_golang#1284 - Bump github.com/prometheus/common from 0.42.0 to 0.44.0 in /tutorial/whatsup by [@​dependabot](https://togithub.com/dependabot) in [prometheus/client_golang#1330 - Bump google.golang.org/protobuf from 1.30.0 to 1.31.0 by [@​dependabot](https://togithub.com/dependabot) in [prometheus/client_golang#1304 - Synchronize common files from prometheus/prometheus by [@​prombot](https://togithub.com/prombot) in [prometheus/client_golang#1332 - Synchronize common files from prometheus/prometheus by [@​prombot](https://togithub.com/prombot) in [prometheus/client_golang#1338 - Cleanup golangci-lint errcheck by [@​SuperQ](https://togithub.com/SuperQ) in [prometheus/client_golang#1339 - Add go_godebug_non_default_behavior_tlsmaxrsasize_events_total by [@​alexandear](https://togithub.com/alexandear) in [prometheus/client_golang#1348 - Extend Counters, Summaries and Histograms with creation timestamp by [@​ArthurSens](https://togithub.com/ArthurSens) in [prometheus/client_golang#1313 - Fix typos in comments, tests, and errors by [@​alexandear](https://togithub.com/alexandear) in [prometheus/client_golang#1346 - Deprecated comment should begin with "Deprecated:" by [@​alexandear](https://togithub.com/alexandear) in [prometheus/client_golang#1347 - Add changelog entry for 1.17 by [@​ArthurSens](https://togithub.com/ArthurSens) in [prometheus/client_golang#1352 </details> #### New Contributors * @​diogoteles08 made their first contributi[prometheus/client_golang#1295 * @​tigrato made their first contributi[prometheus/client_golang#1318 * @​ZiViZiViZ made their first contributi[prometheus/client_golang#1321 * @​sengi made their first contributi[prometheus/client_golang#1322 * @​ArthurSens made their first contributi[prometheus/client_golang#1323 * @​alexandear made their first contributi[prometheus/client_golang#1348 **Full Changelog**: prometheus/client_golang@v1.16.0...v1.17.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "before 6am on Monday" in timezone Europe/Paris, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/cozy/cozy-stack). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4wLjMiLCJ1cGRhdGVkSW5WZXIiOiIzNy4wLjMiLCJ0YXJnZXRCcmFuY2giOiJtYXN0ZXIifQ==-->
bboreham
added a commit
to grafana/mimir
that referenced
this pull request
Oct 2, 2023
Particularly to bring in a performance fix prometheus/client_golang#1296. Most changes are fixing spelling or punctuation in spelling, but there is also the addition of creation timestamps from prometheus/client_golang#1313.
bboreham
added a commit
to grafana/mimir
that referenced
this pull request
Oct 3, 2023
Particularly to bring in a performance fix prometheus/client_golang#1296. Most changes are fixing spelling or punctuation in spelling, but there is also the addition of creation timestamps from prometheus/client_golang#1313.
bboreham
added a commit
to grafana/mimir
that referenced
this pull request
Oct 3, 2023
Particularly to bring in a performance fix prometheus/client_golang#1296. Most changes are fixing spelling or punctuation in spelling, but there is also the addition of creation timestamps from prometheus/client_golang#1313.
djaglowski
pushed a commit
to open-telemetry/opentelemetry-collector-contrib
that referenced
this pull request
Oct 5, 2023
Had to update a Prometheus exporter test `TestCollectMetrics` to adapt to the metric description String() output change made the recent Prom library version prometheus/client_golang#1296. Fixes #27398
jorgeancal
pushed a commit
to jorgeancal/opentelemetry-collector-contrib
that referenced
this pull request
Oct 9, 2023
Had to update a Prometheus exporter test `TestCollectMetrics` to adapt to the metric description String() output change made the recent Prom library version prometheus/client_golang#1296. Fixes open-telemetry#27398
jmsnll
pushed a commit
to jmsnll/opentelemetry-collector-contrib
that referenced
this pull request
Nov 12, 2023
](https://renovatebot.com){kind=link}
Had to update a Prometheus exporter test `TestCollectMetrics` to adapt to the metric description String() output change made the recent Prom library version prometheus/client_golang#1296. Fixes open-telemetry#27398
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementing a fast path when there's no constrained label should limit a lot the number of allocations.
Closes #1276