Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Breaking Change in v2.68.0 w/ Browserify #2040

Closed
jrnail23 opened this issue Jan 27, 2016 · 2 comments · Fixed by #2041
Closed

Breaking Change in v2.68.0 w/ Browserify #2040

jrnail23 opened this issue Jan 27, 2016 · 2 comments · Fixed by #2041

Comments

@jrnail23
Copy link

Looks like v2.68.0 introduced a breaking change by requiring a separate aws4 dependency. Apparently with browserify, that dependency isn't optional, causing build failures.
@rmg rmg mentioned this issue Jan 27, 2016
Merged
rmg added a commit to rmg/request that referenced this issue Jan 27, 2016
@rmg
add aws4 as regular dependency
08f9b98 
It was moved in request#2036 as a devDependency, but is still used in
request.js

This should fix request#2040.
@rmg rmg mentioned this issue Jan 27, 2016
Merged
@rmg
Copy link
Contributor

rmg commented Jan 27, 2016

Submitted #2041 to fix this.

@jrnail23
Copy link
Author

@rmg, thanks for the quick action!

This was referenced Jul 12, 2016
Merged
Closed
@Powersource Powersource mentioned this issue Oct 19, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

restore aws4 as regular dependency rmg/request
2 participants
@rmg @jrnail23