Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gitserver: grpc: switch clientImplementor to use new dedicated gRPC method for FirstEverCommit #62173

Conversation

ggilmore
Copy link
Contributor

@ggilmore ggilmore commented Apr 24, 2024

Closes #61689

This PR switches the gitserver client implementation to use the new gRPC FirstCommitEver() method introduced in #62169 instead of shoving it through the exec() endpoint.

Test plan

Unit tests

Copy link
Contributor Author

ggilmore commented Apr 24, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @ggilmore and the rest of your teammates on Graphite Graphite

@ggilmore ggilmore requested a review from a team April 24, 2024 22:20
@ggilmore ggilmore changed the title gitserver: grpc: switch clientImplementor to use gRPC for FirstEverCommit Pull Request Summary Apr 24, 2024
@ggilmore ggilmore marked this pull request as ready for review April 24, 2024 22:21
@ggilmore ggilmore changed the title Pull Request Summary gitserver: grpc: switch clientImplementor to use new dedicated gRPC method for FirstEverCommit Apr 24, 2024
@ggilmore ggilmore force-pushed the 04-24-gitserver_grpc_create_firstevercommit_rpc_method_and_server_implementation branch from 1340dfb to f6b6171 Compare April 25, 2024 19:08
@ggilmore ggilmore force-pushed the 04-24-gitserver_grpc_switch_clientimplementor_to_use_grpc_for_firstevercommit branch from 9ef85ef to 8ff0aa1 Compare April 25, 2024 19:09
@ggilmore ggilmore force-pushed the 04-24-gitserver_grpc_create_firstevercommit_rpc_method_and_server_implementation branch from f6b6171 to f858a22 Compare April 25, 2024 19:12
@ggilmore ggilmore force-pushed the 04-24-gitserver_grpc_switch_clientimplementor_to_use_grpc_for_firstevercommit branch from 8ff0aa1 to 7f16541 Compare April 25, 2024 19:12
@ggilmore ggilmore force-pushed the 04-24-gitserver_grpc_create_firstevercommit_rpc_method_and_server_implementation branch from f858a22 to 02ec89e Compare April 25, 2024 19:28
@ggilmore ggilmore force-pushed the 04-24-gitserver_grpc_switch_clientimplementor_to_use_grpc_for_firstevercommit branch from 7f16541 to 982582a Compare April 25, 2024 19:28
@ggilmore ggilmore force-pushed the 04-24-gitserver_grpc_create_firstevercommit_rpc_method_and_server_implementation branch from 02ec89e to 5c223e4 Compare April 25, 2024 19:35
@ggilmore ggilmore force-pushed the 04-24-gitserver_grpc_switch_clientimplementor_to_use_grpc_for_firstevercommit branch from 982582a to 75c9be3 Compare April 25, 2024 19:35
@ggilmore ggilmore force-pushed the 04-24-gitserver_grpc_create_firstevercommit_rpc_method_and_server_implementation branch from 5c223e4 to 1f012eb Compare April 25, 2024 23:14
@ggilmore ggilmore force-pushed the 04-24-gitserver_grpc_switch_clientimplementor_to_use_grpc_for_firstevercommit branch from 75c9be3 to 9bb6fe5 Compare April 25, 2024 23:14
@ggilmore ggilmore force-pushed the 04-24-gitserver_grpc_create_firstevercommit_rpc_method_and_server_implementation branch from 1f012eb to 9f0a175 Compare April 25, 2024 23:16
@ggilmore ggilmore force-pushed the 04-24-gitserver_grpc_switch_clientimplementor_to_use_grpc_for_firstevercommit branch from 9bb6fe5 to 9b5b1b7 Compare April 25, 2024 23:16
@ggilmore ggilmore force-pushed the 04-24-gitserver_grpc_create_firstevercommit_rpc_method_and_server_implementation branch from 9f0a175 to 582385f Compare April 26, 2024 17:20
@ggilmore ggilmore force-pushed the 04-24-gitserver_grpc_switch_clientimplementor_to_use_grpc_for_firstevercommit branch from 9b5b1b7 to 89f6149 Compare April 26, 2024 17:20
@ggilmore ggilmore force-pushed the 04-24-gitserver_grpc_create_firstevercommit_rpc_method_and_server_implementation branch from 582385f to 6c0168e Compare April 26, 2024 18:59
@ggilmore ggilmore force-pushed the 04-24-gitserver_grpc_switch_clientimplementor_to_use_grpc_for_firstevercommit branch from 89f6149 to 4c62a2d Compare April 26, 2024 18:59
@ggilmore ggilmore force-pushed the 04-24-gitserver_grpc_switch_clientimplementor_to_use_grpc_for_firstevercommit branch from 9e83fa2 to 5848e61 Compare April 30, 2024 05:19
internal/insights/gitserver/first_commit.go Outdated Show resolved Hide resolved
@ggilmore ggilmore force-pushed the 04-24-gitserver_grpc_create_firstevercommit_rpc_method_and_server_implementation branch from 6543606 to f258a65 Compare April 30, 2024 17:03
@ggilmore ggilmore force-pushed the 04-24-gitserver_grpc_switch_clientimplementor_to_use_grpc_for_firstevercommit branch 2 times, most recently from e3f21ba to 1cbf637 Compare April 30, 2024 17:14
@ggilmore ggilmore force-pushed the 04-24-gitserver_grpc_create_firstevercommit_rpc_method_and_server_implementation branch from f258a65 to f5c873d Compare April 30, 2024 19:21
@ggilmore ggilmore force-pushed the 04-24-gitserver_grpc_switch_clientimplementor_to_use_grpc_for_firstevercommit branch from 1cbf637 to b52e1ec Compare April 30, 2024 19:21
@ggilmore ggilmore force-pushed the 04-24-gitserver_grpc_create_firstevercommit_rpc_method_and_server_implementation branch from f5c873d to 07f51e6 Compare April 30, 2024 19:22
@ggilmore ggilmore force-pushed the 04-24-gitserver_grpc_switch_clientimplementor_to_use_grpc_for_firstevercommit branch from b52e1ec to 99c6668 Compare April 30, 2024 19:22
@ggilmore ggilmore force-pushed the 04-24-gitserver_grpc_create_firstevercommit_rpc_method_and_server_implementation branch from 07f51e6 to 9c9c844 Compare April 30, 2024 20:06
@ggilmore ggilmore force-pushed the 04-24-gitserver_grpc_switch_clientimplementor_to_use_grpc_for_firstevercommit branch from 6de4b91 to d3bef7f Compare April 30, 2024 20:07
@ggilmore ggilmore force-pushed the 04-24-gitserver_grpc_create_firstevercommit_rpc_method_and_server_implementation branch from 9c9c844 to 302550c Compare April 30, 2024 20:34
@ggilmore ggilmore force-pushed the 04-24-gitserver_grpc_switch_clientimplementor_to_use_grpc_for_firstevercommit branch from d3bef7f to 0d07353 Compare April 30, 2024 20:35
@ggilmore ggilmore force-pushed the 04-24-gitserver_grpc_create_firstevercommit_rpc_method_and_server_implementation branch from 302550c to 241022e Compare April 30, 2024 22:29
@ggilmore ggilmore force-pushed the 04-24-gitserver_grpc_switch_clientimplementor_to_use_grpc_for_firstevercommit branch from 0d07353 to bfbeb0f Compare April 30, 2024 22:30
@ggilmore ggilmore force-pushed the 04-24-gitserver_grpc_create_firstevercommit_rpc_method_and_server_implementation branch from 241022e to c4f47bf Compare May 1, 2024 04:16
Base automatically changed from 04-24-gitserver_grpc_create_firstevercommit_rpc_method_and_server_implementation to main May 1, 2024 04:32
@ggilmore ggilmore force-pushed the 04-24-gitserver_grpc_switch_clientimplementor_to_use_grpc_for_firstevercommit branch from bfbeb0f to df8113e Compare May 1, 2024 04:34
Copy link
Contributor Author

ggilmore commented May 1, 2024

Merge activity

  • May 1, 12:35 AM EDT: Graphite rebased this pull request as part of a merge.
  • May 1, 12:46 AM EDT: @ggilmore merged this pull request with Graphite.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed team/product-platform team/source Tickets under the purview of Source - the one Source to graph it all
Projects
None yet
Development

Successfully merging this pull request may close these issues.

gitserver: Move FirstEverCommit to new gRPC pattern
3 participants