New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gitserver: grpc: add new ChangedFiles method to gitserver client #62354
Merged
ggilmore
merged 1 commit into
main
from
05-01-gitserver_grpc_add_new_changedfiles_method_to_gitserver_client
May 7, 2024
Merged
gitserver: grpc: add new ChangedFiles method to gitserver client #62354
ggilmore
merged 1 commit into
main
from
05-01-gitserver_grpc_add_new_changedfiles_method_to_gitserver_client
May 7, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
team/product-platform
team/source
Tickets under the purview of Source - the one Source to graph it all
labels
May 1, 2024
This was referenced May 1, 2024
This was referenced May 1, 2024
Merged
ggilmore
force-pushed
the
04-29-wip_gitserver_grpc_create_chagned_files_impl_for_grpc_server
branch
from
May 1, 2024 21:12
d5d0cc7
to
fc07518
Compare
ggilmore
force-pushed
the
05-01-gitserver_grpc_add_new_changedfiles_method_to_gitserver_client
branch
from
May 1, 2024 21:13
27bd9cc
to
eaac69f
Compare
ggilmore
force-pushed
the
04-29-wip_gitserver_grpc_create_chagned_files_impl_for_grpc_server
branch
from
May 1, 2024 21:18
fc07518
to
afd8bee
Compare
ggilmore
force-pushed
the
05-01-gitserver_grpc_add_new_changedfiles_method_to_gitserver_client
branch
from
May 1, 2024 21:18
eaac69f
to
337f48e
Compare
ggilmore
force-pushed
the
04-29-wip_gitserver_grpc_create_chagned_files_impl_for_grpc_server
branch
from
May 1, 2024 21:21
afd8bee
to
977b125
Compare
ggilmore
force-pushed
the
05-01-gitserver_grpc_add_new_changedfiles_method_to_gitserver_client
branch
from
May 1, 2024 21:21
337f48e
to
4da9e89
Compare
ggilmore
force-pushed
the
04-29-wip_gitserver_grpc_create_chagned_files_impl_for_grpc_server
branch
from
May 1, 2024 21:25
977b125
to
eac84a7
Compare
ggilmore
force-pushed
the
05-01-gitserver_grpc_add_new_changedfiles_method_to_gitserver_client
branch
from
May 1, 2024 21:25
4da9e89
to
a5d3f66
Compare
ggilmore
force-pushed
the
04-29-wip_gitserver_grpc_create_chagned_files_impl_for_grpc_server
branch
from
May 1, 2024 21:30
eac84a7
to
f6dd6ff
Compare
ggilmore
force-pushed
the
05-01-gitserver_grpc_add_new_changedfiles_method_to_gitserver_client
branch
from
May 1, 2024 21:30
a5d3f66
to
a6d5687
Compare
ggilmore
force-pushed
the
04-29-wip_gitserver_grpc_create_chagned_files_impl_for_grpc_server
branch
from
May 6, 2024 18:16
8b3d845
to
e490d50
Compare
ggilmore
force-pushed
the
05-01-gitserver_grpc_add_new_changedfiles_method_to_gitserver_client
branch
3 times, most recently
from
May 6, 2024 19:24
153c146
to
17573de
Compare
ggilmore
force-pushed
the
04-29-wip_gitserver_grpc_create_chagned_files_impl_for_grpc_server
branch
from
May 6, 2024 19:37
e490d50
to
804cbdd
Compare
ggilmore
force-pushed
the
05-01-gitserver_grpc_add_new_changedfiles_method_to_gitserver_client
branch
from
May 6, 2024 19:38
17573de
to
0af92c9
Compare
@sourcegraph/source Can you please take another look at this PR (and all the upstack PRs that use it)? I refactored the approach here to use iterators. |
eseliger
approved these changes
May 6, 2024
ggilmore
force-pushed
the
04-29-wip_gitserver_grpc_create_chagned_files_impl_for_grpc_server
branch
from
May 6, 2024 21:55
804cbdd
to
7a61aa2
Compare
ggilmore
force-pushed
the
05-01-gitserver_grpc_add_new_changedfiles_method_to_gitserver_client
branch
from
May 6, 2024 21:55
0af92c9
to
6eb1d2f
Compare
ggilmore
force-pushed
the
04-29-wip_gitserver_grpc_create_chagned_files_impl_for_grpc_server
branch
from
May 6, 2024 23:28
7a61aa2
to
6248ab5
Compare
ggilmore
force-pushed
the
05-01-gitserver_grpc_add_new_changedfiles_method_to_gitserver_client
branch
2 times, most recently
from
May 6, 2024 23:35
cb06748
to
9c74216
Compare
ggilmore
force-pushed
the
04-29-wip_gitserver_grpc_create_chagned_files_impl_for_grpc_server
branch
from
May 6, 2024 23:50
6248ab5
to
b8070d0
Compare
ggilmore
force-pushed
the
05-01-gitserver_grpc_add_new_changedfiles_method_to_gitserver_client
branch
from
May 6, 2024 23:50
9c74216
to
aa9ed29
Compare
ggilmore
force-pushed
the
04-29-wip_gitserver_grpc_create_chagned_files_impl_for_grpc_server
branch
from
May 7, 2024 03:47
b8070d0
to
85a0105
Compare
ggilmore
force-pushed
the
05-01-gitserver_grpc_add_new_changedfiles_method_to_gitserver_client
branch
2 times, most recently
from
May 7, 2024 16:16
41f212e
to
5f646f0
Compare
ggilmore
force-pushed
the
04-29-wip_gitserver_grpc_create_chagned_files_impl_for_grpc_server
branch
from
May 7, 2024 16:17
85a0105
to
fbb2877
Compare
ggilmore
force-pushed
the
05-01-gitserver_grpc_add_new_changedfiles_method_to_gitserver_client
branch
from
May 7, 2024 16:17
5f646f0
to
1bb89ac
Compare
ggilmore
force-pushed
the
04-29-wip_gitserver_grpc_create_chagned_files_impl_for_grpc_server
branch
from
May 7, 2024 17:33
fbb2877
to
53c8d36
Compare
Base automatically changed from
04-29-wip_gitserver_grpc_create_chagned_files_impl_for_grpc_server
to
main
May 7, 2024 17:43
ggilmore
force-pushed
the
05-01-gitserver_grpc_add_new_changedfiles_method_to_gitserver_client
branch
from
May 7, 2024 17:44
1bb89ac
to
a54db0c
Compare
ggilmore
deleted the
05-01-gitserver_grpc_add_new_changedfiles_method_to_gitserver_client
branch
May 7, 2024 17:58
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
cla-signed
team/product-platform
team/source
Tickets under the purview of Source - the one Source to graph it all
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #60654
This PR builds on #62216, and creates a new ChangedFiles method in the gitserver client that calls the new gRPC method that was introduced in #62216.
Note: This PR doesn't change / remove any existing callers of DiffSymbols. I made those changes in future stacked PRs to ensure that they're easy to review.
Test plan
New Unit tests