Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gitserver: grpc: add new ChangedFiles method to gitserver client #62354

Conversation

ggilmore
Copy link
Contributor

@ggilmore ggilmore commented May 1, 2024

Part of #60654

This PR builds on #62216, and creates a new ChangedFiles method in the gitserver client that calls the new gRPC method that was introduced in #62216.

Note: This PR doesn't change / remove any existing callers of DiffSymbols. I made those changes in future stacked PRs to ensure that they're easy to review.

Test plan

New Unit tests

Copy link
Contributor Author

ggilmore commented May 1, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @ggilmore and the rest of your teammates on Graphite Graphite

@ggilmore ggilmore force-pushed the 04-29-wip_gitserver_grpc_create_chagned_files_impl_for_grpc_server branch from d5d0cc7 to fc07518 Compare May 1, 2024 21:12
@ggilmore ggilmore force-pushed the 05-01-gitserver_grpc_add_new_changedfiles_method_to_gitserver_client branch from 27bd9cc to eaac69f Compare May 1, 2024 21:13
@ggilmore ggilmore force-pushed the 04-29-wip_gitserver_grpc_create_chagned_files_impl_for_grpc_server branch from fc07518 to afd8bee Compare May 1, 2024 21:18
@ggilmore ggilmore force-pushed the 05-01-gitserver_grpc_add_new_changedfiles_method_to_gitserver_client branch from eaac69f to 337f48e Compare May 1, 2024 21:18
@ggilmore ggilmore force-pushed the 04-29-wip_gitserver_grpc_create_chagned_files_impl_for_grpc_server branch from afd8bee to 977b125 Compare May 1, 2024 21:21
@ggilmore ggilmore force-pushed the 05-01-gitserver_grpc_add_new_changedfiles_method_to_gitserver_client branch from 337f48e to 4da9e89 Compare May 1, 2024 21:21
@ggilmore ggilmore force-pushed the 04-29-wip_gitserver_grpc_create_chagned_files_impl_for_grpc_server branch from 977b125 to eac84a7 Compare May 1, 2024 21:25
@ggilmore ggilmore force-pushed the 05-01-gitserver_grpc_add_new_changedfiles_method_to_gitserver_client branch from 4da9e89 to a5d3f66 Compare May 1, 2024 21:25
@ggilmore ggilmore force-pushed the 04-29-wip_gitserver_grpc_create_chagned_files_impl_for_grpc_server branch from eac84a7 to f6dd6ff Compare May 1, 2024 21:30
@ggilmore ggilmore force-pushed the 05-01-gitserver_grpc_add_new_changedfiles_method_to_gitserver_client branch from a5d3f66 to a6d5687 Compare May 1, 2024 21:30
@ggilmore ggilmore marked this pull request as ready for review May 1, 2024 22:10
@ggilmore ggilmore force-pushed the 04-29-wip_gitserver_grpc_create_chagned_files_impl_for_grpc_server branch from 8b3d845 to e490d50 Compare May 6, 2024 18:16
@ggilmore ggilmore force-pushed the 05-01-gitserver_grpc_add_new_changedfiles_method_to_gitserver_client branch 3 times, most recently from 153c146 to 17573de Compare May 6, 2024 19:24
@ggilmore ggilmore force-pushed the 04-29-wip_gitserver_grpc_create_chagned_files_impl_for_grpc_server branch from e490d50 to 804cbdd Compare May 6, 2024 19:37
@ggilmore ggilmore force-pushed the 05-01-gitserver_grpc_add_new_changedfiles_method_to_gitserver_client branch from 17573de to 0af92c9 Compare May 6, 2024 19:38
Copy link
Contributor Author

ggilmore commented May 6, 2024

@sourcegraph/source Can you please take another look at this PR (and all the upstack PRs that use it)? I refactored the approach here to use iterators.

internal/gitserver/client.go Outdated Show resolved Hide resolved
internal/gitserver/commands.go Outdated Show resolved Hide resolved
internal/gitserver/commands.go Outdated Show resolved Hide resolved
@ggilmore ggilmore force-pushed the 04-29-wip_gitserver_grpc_create_chagned_files_impl_for_grpc_server branch from 804cbdd to 7a61aa2 Compare May 6, 2024 21:55
@ggilmore ggilmore force-pushed the 05-01-gitserver_grpc_add_new_changedfiles_method_to_gitserver_client branch from 0af92c9 to 6eb1d2f Compare May 6, 2024 21:55
@ggilmore ggilmore force-pushed the 04-29-wip_gitserver_grpc_create_chagned_files_impl_for_grpc_server branch from 7a61aa2 to 6248ab5 Compare May 6, 2024 23:28
@ggilmore ggilmore force-pushed the 05-01-gitserver_grpc_add_new_changedfiles_method_to_gitserver_client branch 2 times, most recently from cb06748 to 9c74216 Compare May 6, 2024 23:35
@ggilmore ggilmore force-pushed the 04-29-wip_gitserver_grpc_create_chagned_files_impl_for_grpc_server branch from 6248ab5 to b8070d0 Compare May 6, 2024 23:50
@ggilmore ggilmore force-pushed the 05-01-gitserver_grpc_add_new_changedfiles_method_to_gitserver_client branch from 9c74216 to aa9ed29 Compare May 6, 2024 23:50
@ggilmore ggilmore force-pushed the 04-29-wip_gitserver_grpc_create_chagned_files_impl_for_grpc_server branch from b8070d0 to 85a0105 Compare May 7, 2024 03:47
@ggilmore ggilmore force-pushed the 05-01-gitserver_grpc_add_new_changedfiles_method_to_gitserver_client branch 2 times, most recently from 41f212e to 5f646f0 Compare May 7, 2024 16:16
@ggilmore ggilmore force-pushed the 04-29-wip_gitserver_grpc_create_chagned_files_impl_for_grpc_server branch from 85a0105 to fbb2877 Compare May 7, 2024 16:17
@ggilmore ggilmore force-pushed the 05-01-gitserver_grpc_add_new_changedfiles_method_to_gitserver_client branch from 5f646f0 to 1bb89ac Compare May 7, 2024 16:17
@ggilmore ggilmore force-pushed the 04-29-wip_gitserver_grpc_create_chagned_files_impl_for_grpc_server branch from fbb2877 to 53c8d36 Compare May 7, 2024 17:33
Base automatically changed from 04-29-wip_gitserver_grpc_create_chagned_files_impl_for_grpc_server to main May 7, 2024 17:43
@ggilmore ggilmore force-pushed the 05-01-gitserver_grpc_add_new_changedfiles_method_to_gitserver_client branch from 1bb89ac to a54db0c Compare May 7, 2024 17:44
Copy link
Contributor Author

ggilmore commented May 7, 2024

Merge activity

  • May 7, 1:45 PM EDT: Graphite rebased this pull request after merging its parent, because this pull request is set to merge when ready.
  • May 7, 1:58 PM EDT: @ggilmore merged this pull request with Graphite.

@ggilmore ggilmore merged commit 3a3ce68 into main May 7, 2024
13 checks passed
@ggilmore ggilmore deleted the 05-01-gitserver_grpc_add_new_changedfiles_method_to_gitserver_client branch May 7, 2024 17:58
ggilmore added a commit that referenced this pull request May 7, 2024
…new ChangedFiles method (#62355)

Part of #60654

This PR builds on the new ChangedFiles method introduced in #62354, and changes the symbols service to use it instead of the old custom diff symbols method.

## Test plan

Existing CI pipeline
ggilmore added a commit that referenced this pull request May 7, 2024
…hangedFiles client method (#62358)

Part of #60654

This PR replaces hybrid's search use of the gitserver.DiffSymbols endpoint with the new gitserver.ChangedFiles gRPC endpoint introduced in #62354.

## Test plan

Existing CI pipeline
ggilmore added a commit that referenced this pull request May 7, 2024
… method with new gitserver.ChangedFiles method (#62359)

Part of #60654

This PR replaces the worker embedding job's use of the old gitserver.DiffSymbols endpoint with the gitserver.ChangedFiles gRPC endpoint introduced in #62354.

## Test plan

Existing CI
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed team/product-platform team/source Tickets under the purview of Source - the one Source to graph it all
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants